New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679510 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 468240



Sign in to add a comment

2.8%-10.1% regression in dromaeo.domcorequery at 441357:441378

Project Member Reported by benhenry@google.com, Jan 9 2017

Issue description

Links below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=679510

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDggM6mvQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_6_huwkM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-nvidia
Cc: mlippautz@chromium.org
Owner: mlippautz@chromium.org

=== Auto-CCing suspected CL author mlippautz@chromium.org ===

Hi mlippautz@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : mlippautz
  Commit : 3ea9f88ef8b0dcba9d1805293cc32dbfbd678615
  Date   : Wed Jan 04 14:07:36 2017
  Subject: [wrapper-tracing] Simplify tracing and reduce technical debt

Bisect Details
  Configuration: winx64ati_perf_bisect
  Benchmark    : dromaeo.domcorequery
  Metric       : dom/dom
  Change       : 3.38% | 30285.7879033 -> 29261.0503561

Revision             Result                  N
chromium@441356      30285.8 +- 539.185      6      good
chromium@441362      30149.5 +- 391.985      6      good
chromium@441365      30157.7 +- 359.484      6      good
chromium@441366      29543.9 +- 624.712      6      bad       <--
chromium@441367      29466.9 +- 687.705      6      bad
chromium@441378      29261.1 +- 1406.39      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests dromaeo.domcorequery

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8990905906266604192

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5776651289362432


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92b8a98af078e38774b2b1b1818fb0d461f5fc13

commit 92b8a98af078e38774b2b1b1818fb0d461f5fc13
Author: mlippautz <mlippautz@chromium.org>
Date: Wed Jan 18 15:25:32 2017

[wrapper-tracing] Force inlining of marking deque helper

BUG= 679510 

Review-Url: https://codereview.chromium.org/2640033002
Cr-Commit-Position: refs/heads/master@{#444361}

[modify] https://crrev.com/92b8a98af078e38774b2b1b1818fb0d461f5fc13/third_party/WebKit/Source/platform/heap/WrapperVisitor.h

Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jan 18 2017


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : mlippautz
  Commit : 3ea9f88ef8b0dcba9d1805293cc32dbfbd678615
  Date   : Wed Jan 04 14:07:36 2017
  Subject: [wrapper-tracing] Simplify tracing and reduce technical debt

Bisect Details
  Configuration: winx64nvidia_perf_bisect
  Benchmark    : blink_perf.bindings
  Metric       : get-elements-by-tag-name/get-elements-by-tag-name
  Change       : 9.34% | 651.366428875 -> 590.508242728

Revision             Result                  N
chromium@441356      651.366 +- 13.0804      6      good
chromium@441362      651.323 +- 10.3955      6      good
chromium@441365      639.986 +- 34.0784      6      good
chromium@441366      578.653 +- 18.6902      6      bad       <--
chromium@441367      589.132 +- 15.7779      6      bad
chromium@441378      590.508 +- 11.6844      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8990107348831547680

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6390804433600512


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Blocking: 468240
Components: Blink>JavaScript>GC Blink>Bindings
Status: Fixed (was: Assigned)
This is fixed with #5.

Sign in to add a comment