New issue
Advanced search Search tips

Issue 679470 link

Starred by 2 users
Status: Fixed
Owner:
vasi...@chromium.org
Closed: Jan 2017
Cc:
a-...@yandex-team.ru
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"ExtensionBrowserTest.OverrideHomePageSettings" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jan 9 2017 
"ExtensionBrowserTest.OverrideHomePageSettings" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOAsSBUZsYWtlIi1FeHRlbnNpb25Ccm93c2VyVGVzdC5PdmVycmlkZUhvbWVQYWdlU2V0dGluZ3MM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by foolip@chromium.org, Jan 10 2017 

Likely the same as  issue 679569 .

Comment 2 by foolip@chromium.org, Jan 10 2017 

The earliest failure happened with https://crrev.com/d0eda8fc58bd6357bb5a18e4d977b98de988857a not long after https://codereview.chromium.org/2479113002 which also modified the test. Will revert.

Comment 3 by foolip@chromium.org, Jan 10 2017 

 Issue 679569  has been merged into this issue.

Comment 4 by foolip@chromium.org, Jan 10 2017

Cc: a-...@yandex-team.ru
Owner: vasi...@chromium.org

Comment 5 by foolip@chromium.org, Jan 10 2017

Status: Assigned (was: Untriaged)

Comment 6 by a-...@yandex-team.ru, Jan 10 2017 

I will take a look at failure.

Comment 7 by foolip@chromium.org, Jan 10 2017 

The first failure looked like this:

ExtensionBrowserTest.OverrideHomePageSettings (run #1):
[ RUN      ] ExtensionBrowserTest.OverrideHomePageSettings
[6024:4000:0109/084141.615:ERROR:variations_util.cc(102)] Missing Worker Pool Configuration: Background
[1388:5704:0109/084141.725:INFO:media_foundation_video_encode_accelerator_win.cc(329)] Windows versions earlier than 8 are not supported.
[2952:3852:0109/084141.780:ERROR:variations_util.cc(102)] Missing Worker Pool Configuration: RendererBackground
[6024:4000:0109/084142.069:FATAL:template_url_service.cc(492)] Check failed: !FindTemplateURLForExtension(info->extension_id, template_url->type()).
Backtrace:
	base::debug::StackTrace::StackTrace [0x01952AC7+23]
	logging::LogMessage::~LogMessage [0x01905B01+49]
	TemplateURLService::AddExtensionControlledTURL [0x02AE7D0B+396]
	extensions::SettingsOverridesAPI::RegisterSearchProvider [0x02D41F5E+453]
	extensions::SettingsOverridesAPI::OnExtensionLoaded [0x02D41B90+957]
	extensions::ExtensionRegistry::TriggerOnLoaded [0x016CBA10+185]
	ExtensionService::NotifyExtensionLoaded [0x02C7BBA7+144]
	ExtensionService::EnableExtension [0x02C7ABAD+299]
	ExtensionService::AddExtension [0x02C79B5F+941]
	ExtensionService::FinishInstallation [0x02C7AE3E+164]
	ExtensionService::AddNewOrUpdatedExtension [0x02C79CBB+302]
	ExtensionService::OnExtensionInstalled [0x02C7C9D0+1545]
	extensions::UnpackedInstaller::InstallExtension [0x02C72067+266]
	extensions::UnpackedInstaller::OnInstallChecksComplete [0x02C72776+233]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::WebFileWriterImpl::WriterBridge::*)(enum base::File::Error),scoped_refptr<content::WebFileWriterImpl::WriterBridge> >,void __cdecl(enum base::File::Error)>::Run [0x03106523+32]
	base::internal::RunMixin<base::Callback<bool __cdecl(std::_Tree_const_iterator<std::_Tree_val<std::_Tree_simple_types<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> > const ,policy::PolicyMap::Entry> > > >),1,1> >::Run [0x02E484BC+32]
	extensions::ExtensionInstallChecker::MaybeInvokeCallback [0x02CFB857+108]
	extensions::ExtensionInstallChecker::OnRequirementsCheckDone [0x02CFB927+36]
	base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall local_discovery::ServiceDiscoveryDeviceLister::*const &)(enum local_discovery::ServiceWatcher::UpdateType,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &),base::W [0x01EA2E0A+41]
	base::internal::Invoker<base::internal::BindState<void (__thiscall extensions::app_file_handler_util::MimeTypeCollector::*)(unsigned int,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &),base::WeakPtr<extensions::app_file_handl [0x01520F01+26]
	base::internal::FunctorTraits<base::Callback<void __cdecl(gcm::MCSMessage const &),1,1>,void>::Invoke<base::Callback<void __cdecl(gcm::MCSMessage const &),1,1> const &,gcm::MCSMessage const &> [0x01576FDF+96]
	base::internal::Invoker<base::internal::BindState<base::Callback<void __cdecl(gcm::MCSMessage const &),1,1>,gcm::MCSMessage>,void __cdecl(void)>::Run [0x0157AE1D+19]
	base::debug::TaskAnnotator::RunTask [0x0198CC1F+383]
	base::MessageLoop::RunTask [0x01915B4C+1228]
	base::MessageLoop::DoWork [0x01914A03+611]
	base::MessagePumpForUI::DoRunLoop [0x0198DE7D+93]
	base::MessagePumpWin::Run [0x0198E61A+74]
	base::MessageLoop::RunHandler [0x01915671+305]
	base::RunLoop::Run [0x01918564+132]
	extensions::TestExtensionRegistryObserver::Wait [0x0401A383+24]
	extensions::TestExtensionRegistryObserver::WaitForExtensionLoaded [0x0401A3CB+9]
	ExtensionBrowserTest::LoadExtensionWithInstallParam [0x0083B46E+124]
	std::default_delete<TemplateURLData>::operator() [0x0047A252+1542]
	InProcessBrowserTest::RunTestOnMainThreadLoop [0x019B209D+180]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x01D48B9C+175]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x01C10761+3404]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x01C0F9DD+167]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x0138C773+112]
	base::internal::RunMixin<base::Callback<bool __cdecl(void),1,1> >::Run [0x02E9EFA2+25]
	content::BrowserMainRunnerImpl::Initialize [0x0138DB24+681]
	content::BrowserMain [0x01389148+117]
	content::RunNamedProcessTypeMain [0x018F0749+206]
	content::ContentMainRunnerImpl::Run [0x018F064A+280]
	content::ContentMain [0x018EFB14+35]
	content::BrowserTestBase::SetUp [0x01D491D4+971]
	InProcessBrowserTest::SetUp [0x019B240F+268]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x02258F34+32]
	testing::Test::Run [0x0225FF3F+51]
	testing::TestCase::Run [0x02260015+133]
	testing::internal::UnitTestImpl::RunAllTests [0x02260394+433]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x02258F78+32]
	testing::UnitTest::Run [0x022601BE+133]
	base::TestSuite::Run [0x019BE6B7+95]
	ChromeTestSuiteRunner::RunTestSuite [0x040843BC+40]
	content::LaunchTests [0x01D4297B+583]
	LaunchChromeTests [0x04084380+139]
	main [0x0408411C+63]
	__scrt_common_main_seh [0x04048EFF+249] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x773A336A+18]
	RtlInitializeExceptionChain [0x77B39882+99]
	RtlInitializeExceptionChain [0x77B39855+54]


ExtensionBrowserTest.OverrideHomePageSettings (run #2):
[ RUN      ] ExtensionBrowserTest.OverrideHomePageSettings
[3328:3208:0109/084541.528:ERROR:variations_util.cc(102)] Missing Worker Pool Configuration: Background
[1032:992:0109/084541.616:INFO:media_foundation_video_encode_accelerator_win.cc(329)] Windows versions earlier than 8 are not supported.
[5944:4604:0109/084541.672:ERROR:variations_util.cc(102)] Missing Worker Pool Configuration: RendererBackground
[3328:3208:0109/084541.788:FATAL:template_url_service.cc(492)] Check failed: !FindTemplateURLForExtension(info->extension_id, template_url->type()).
Backtrace:
	base::debug::StackTrace::StackTrace [0x01952AC7+23]
	logging::LogMessage::~LogMessage [0x01905B01+49]
	TemplateURLService::AddExtensionControlledTURL [0x02AE7D0B+396]
	extensions::SettingsOverridesAPI::RegisterSearchProvider [0x02D41F5E+453]
	extensions::SettingsOverridesAPI::OnExtensionLoaded [0x02D41B90+957]
	extensions::ExtensionRegistry::TriggerOnLoaded [0x016CBA10+185]
	ExtensionService::NotifyExtensionLoaded [0x02C7BBA7+144]
	ExtensionService::EnableExtension [0x02C7ABAD+299]
	ExtensionService::AddExtension [0x02C79B5F+941]
	ExtensionService::FinishInstallation [0x02C7AE3E+164]
	ExtensionService::AddNewOrUpdatedExtension [0x02C79CBB+302]
	ExtensionService::OnExtensionInstalled [0x02C7C9D0+1545]
	extensions::UnpackedInstaller::InstallExtension [0x02C72067+266]
	extensions::UnpackedInstaller::OnInstallChecksComplete [0x02C72776+233]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::WebFileWriterImpl::WriterBridge::*)(enum base::File::Error),scoped_refptr<content::WebFileWriterImpl::WriterBridge> >,void __cdecl(enum base::File::Error)>::Run [0x03106523+32]
	base::internal::RunMixin<base::Callback<bool __cdecl(std::_Tree_const_iterator<std::_Tree_val<std::_Tree_simple_types<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> > const ,policy::PolicyMap::Entry> > > >),1,1> >::Run [0x02E484BC+32]
	extensions::ExtensionInstallChecker::MaybeInvokeCallback [0x02CFB857+108]
	extensions::ExtensionInstallChecker::OnRequirementsCheckDone [0x02CFB927+36]
	base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall local_discovery::ServiceDiscoveryDeviceLister::*const &)(enum local_discovery::ServiceWatcher::UpdateType,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &),base::W [0x01EA2E0A+41]
	base::internal::Invoker<base::internal::BindState<void (__thiscall extensions::app_file_handler_util::MimeTypeCollector::*)(unsigned int,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &),base::WeakPtr<extensions::app_file_handl [0x01520F01+26]
	base::internal::FunctorTraits<base::Callback<void __cdecl(gcm::MCSMessage const &),1,1>,void>::Invoke<base::Callback<void __cdecl(gcm::MCSMessage const &),1,1> const &,gcm::MCSMessage const &> [0x01576FDF+96]
	base::internal::Invoker<base::internal::BindState<base::Callback<void __cdecl(gcm::MCSMessage const &),1,1>,gcm::MCSMessage>,void __cdecl(void)>::Run [0x0157AE1D+19]
	base::debug::TaskAnnotator::RunTask [0x0198CC1F+383]
	base::MessageLoop::RunTask [0x01915B4C+1228]
	base::MessageLoop::DoWork [0x01914A03+611]
	base::MessagePumpForUI::DoRunLoop [0x0198DE7D+93]
	base::MessagePumpWin::Run [0x0198E61A+74]
	base::MessageLoop::RunHandler [0x01915671+305]
	base::RunLoop::Run [0x01918564+132]
	extensions::TestExtensionRegistryObserver::Wait [0x0401A383+24]
	extensions::TestExtensionRegistryObserver::WaitForExtensionLoaded [0x0401A3CB+9]
	ExtensionBrowserTest::LoadExtensionWithInstallParam [0x0083B46E+124]
	std::default_delete<TemplateURLData>::operator() [0x0047A252+1542]
	InProcessBrowserTest::RunTestOnMainThreadLoop [0x019B209D+180]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x01D48B9C+175]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x01C10761+3404]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x01C0F9DD+167]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x0138C773+112]
	base::internal::RunMixin<base::Callback<bool __cdecl(void),1,1> >::Run [0x02E9EFA2+25]
	content::BrowserMainRunnerImpl::Initialize [0x0138DB24+681]
	content::BrowserMain [0x01389148+117]
	content::RunNamedProcessTypeMain [0x018F0749+206]
	content::ContentMainRunnerImpl::Run [0x018F064A+280]
	content::ContentMain [0x018EFB14+35]
	content::BrowserTestBase::SetUp [0x01D491D4+971]
	InProcessBrowserTest::SetUp [0x019B240F+268]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x02258F34+32]
	testing::Test::Run [0x0225FF3F+51]
	testing::TestCase::Run [0x02260015+133]
	testing::internal::UnitTestImpl::RunAllTests [0x02260394+433]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x02258F78+32]
	testing::UnitTest::Run [0x022601BE+133]
	base::TestSuite::Run [0x019BE6B7+95]
	ChromeTestSuiteRunner::RunTestSuite [0x040843BC+40]
	content::LaunchTests [0x01D4297B+583]
	LaunchChromeTests [0x04084380+139]
	main [0x0408411C+63]
	__scrt_common_main_seh [0x04048EFF+249] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x773A336A+18]
	RtlInitializeExceptionChain [0x77B39882+99]
	RtlInitializeExceptionChain [0x77B39855+54]


ExtensionBrowserTest.OverrideHomePageSettings (run #3):
[ RUN      ] ExtensionBrowserTest.OverrideHomePageSettings
[5496:1912:0109/084544.056:ERROR:variations_util.cc(102)] Missing Worker Pool Configuration: Background
[3316:5760:0109/084544.144:INFO:media_foundation_video_encode_accelerator_win.cc(329)] Windows versions earlier than 8 are not supported.
[3156:3280:0109/084544.198:ERROR:variations_util.cc(102)] Missing Worker Pool Configuration: RendererBackground
[5496:1912:0109/084544.304:FATAL:template_url_service.cc(492)] Check failed: !FindTemplateURLForExtension(info->extension_id, template_url->type()).
Backtrace:
	base::debug::StackTrace::StackTrace [0x01952AC7+23]
	logging::LogMessage::~LogMessage [0x01905B01+49]
	TemplateURLService::AddExtensionControlledTURL [0x02AE7D0B+396]
	extensions::SettingsOverridesAPI::RegisterSearchProvider [0x02D41F5E+453]
	extensions::SettingsOverridesAPI::OnExtensionLoaded [0x02D41B90+957]
	extensions::ExtensionRegistry::TriggerOnLoaded [0x016CBA10+185]
	ExtensionService::NotifyExtensionLoaded [0x02C7BBA7+144]
	ExtensionService::EnableExtension [0x02C7ABAD+299]
	ExtensionService::AddExtension [0x02C79B5F+941]
	ExtensionService::FinishInstallation [0x02C7AE3E+164]
	ExtensionService::AddNewOrUpdatedExtension [0x02C79CBB+302]
	ExtensionService::OnExtensionInstalled [0x02C7C9D0+1545]
	extensions::UnpackedInstaller::InstallExtension [0x02C72067+266]
	extensions::UnpackedInstaller::OnInstallChecksComplete [0x02C72776+233]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::WebFileWriterImpl::WriterBridge::*)(enum base::File::Error),scoped_refptr<content::WebFileWriterImpl::WriterBridge> >,void __cdecl(enum base::File::Error)>::Run [0x03106523+32]
	base::internal::RunMixin<base::Callback<bool __cdecl(std::_Tree_const_iterator<std::_Tree_val<std::_Tree_simple_types<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> > const ,policy::PolicyMap::Entry> > > >),1,1> >::Run [0x02E484BC+32]
	extensions::ExtensionInstallChecker::MaybeInvokeCallback [0x02CFB857+108]
	extensions::ExtensionInstallChecker::OnRequirementsCheckDone [0x02CFB927+36]
	base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall local_discovery::ServiceDiscoveryDeviceLister::*const &)(enum local_discovery::ServiceWatcher::UpdateType,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &),base::W [0x01EA2E0A+41]
	base::internal::Invoker<base::internal::BindState<void (__thiscall extensions::app_file_handler_util::MimeTypeCollector::*)(unsigned int,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &),base::WeakPtr<extensions::app_file_handl [0x01520F01+26]
	base::internal::FunctorTraits<base::Callback<void __cdecl(gcm::MCSMessage const &),1,1>,void>::Invoke<base::Callback<void __cdecl(gcm::MCSMessage const &),1,1> const &,gcm::MCSMessage const &> [0x01576FDF+96]
	base::internal::Invoker<base::internal::BindState<base::Callback<void __cdecl(gcm::MCSMessage const &),1,1>,gcm::MCSMessage>,void __cdecl(void)>::Run [0x0157AE1D+19]
	base::debug::TaskAnnotator::RunTask [0x0198CC1F+383]
	base::MessageLoop::RunTask [0x01915B4C+1228]
	base::MessageLoop::DoWork [0x01914A03+611]
	base::MessagePumpForUI::DoRunLoop [0x0198DE7D+93]
	base::MessagePumpWin::Run [0x0198E61A+74]
	base::MessageLoop::RunHandler [0x01915671+305]
	base::RunLoop::Run [0x01918564+132]
	extensions::TestExtensionRegistryObserver::Wait [0x0401A383+24]
	extensions::TestExtensionRegistryObserver::WaitForExtensionLoaded [0x0401A3CB+9]
	ExtensionBrowserTest::LoadExtensionWithInstallParam [0x0083B46E+124]
	std::default_delete<TemplateURLData>::operator() [0x0047A252+1542]
	InProcessBrowserTest::RunTestOnMainThreadLoop [0x019B209D+180]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x01D48B9C+175]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x01C10761+3404]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x01C0F9DD+167]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x0138C773+112]
	base::internal::RunMixin<base::Callback<bool __cdecl(void),1,1> >::Run [0x02E9EFA2+25]
	content::BrowserMainRunnerImpl::Initialize [0x0138DB24+681]
	content::BrowserMain [0x01389148+117]
	content::RunNamedProcessTypeMain [0x018F0749+206]
	content::ContentMainRunnerImpl::Run [0x018F064A+280]
	content::ContentMain [0x018EFB14+35]
	content::BrowserTestBase::SetUp [0x01D491D4+971]
	InProcessBrowserTest::SetUp [0x019B240F+268]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x02258F34+32]
	testing::Test::Run [0x0225FF3F+51]
	testing::TestCase::Run [0x02260015+133]
	testing::internal::UnitTestImpl::RunAllTests [0x02260394+433]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x02258F78+32]
	testing::UnitTest::Run [0x022601BE+133]
	base::TestSuite::Run [0x019BE6B7+95]
	ChromeTestSuiteRunner::RunTestSuite [0x040843BC+40]
	content::LaunchTests [0x01D4297B+583]
	LaunchChromeTests [0x04084380+139]
	main [0x0408411C+63]
	__scrt_common_main_seh [0x04048EFF+249] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x773A336A+18]
	RtlInitializeExceptionChain [0x77B39882+99]
	RtlInitializeExceptionChain [0x77B39855+54]


ExtensionBrowserTest.OverrideHomePageSettings (run #4):
[ RUN      ] ExtensionBrowserTest.OverrideHomePageSettings
[4052:4548:0109/084544.603:ERROR:variations_util.cc(102)] Missing Worker Pool Configuration: Background
[196:5092:0109/084544.691:INFO:media_foundation_video_encode_accelerator_win.cc(329)] Windows versions earlier than 8 are not supported.
[2220:3860:0109/084544.744:ERROR:variations_util.cc(102)] Missing Worker Pool Configuration: RendererBackground
[4052:4548:0109/084544.842:FATAL:template_url_service.cc(492)] Check failed: !FindTemplateURLForExtension(info->extension_id, template_url->type()).
Backtrace:
	base::debug::StackTrace::StackTrace [0x01952AC7+23]
	logging::LogMessage::~LogMessage [0x01905B01+49]
	TemplateURLService::AddExtensionControlledTURL [0x02AE7D0B+396]
	extensions::SettingsOverridesAPI::RegisterSearchProvider [0x02D41F5E+453]
	extensions::SettingsOverridesAPI::OnExtensionLoaded [0x02D41B90+957]
	extensions::ExtensionRegistry::TriggerOnLoaded [0x016CBA10+185]
	ExtensionService::NotifyExtensionLoaded [0x02C7BBA7+144]
	ExtensionService::EnableExtension [0x02C7ABAD+299]
	ExtensionService::AddExtension [0x02C79B5F+941]
	ExtensionService::FinishInstallation [0x02C7AE3E+164]
	ExtensionService::AddNewOrUpdatedExtension [0x02C79CBB+302]
	ExtensionService::OnExtensionInstalled [0x02C7C9D0+1545]
	extensions::UnpackedInstaller::InstallExtension [0x02C72067+266]
	extensions::UnpackedInstaller::OnInstallChecksComplete [0x02C72776+233]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::WebFileWriterImpl::WriterBridge::*)(enum base::File::Error),scoped_refptr<content::WebFileWriterImpl::WriterBridge> >,void __cdecl(enum base::File::Error)>::Run [0x03106523+32]
	base::internal::RunMixin<base::Callback<bool __cdecl(std::_Tree_const_iterator<std::_Tree_val<std::_Tree_simple_types<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> > const ,policy::PolicyMap::Entry> > > >),1,1> >::Run [0x02E484BC+32]
	extensions::ExtensionInstallChecker::MaybeInvokeCallback [0x02CFB857+108]
	extensions::ExtensionInstallChecker::OnRequirementsCheckDone [0x02CFB927+36]
	base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall local_discovery::ServiceDiscoveryDeviceLister::*const &)(enum local_discovery::ServiceWatcher::UpdateType,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &),base::W [0x01EA2E0A+41]
	base::internal::Invoker<base::internal::BindState<void (__thiscall extensions::app_file_handler_util::MimeTypeCollector::*)(unsigned int,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &),base::WeakPtr<extensions::app_file_handl [0x01520F01+26]
	base::internal::FunctorTraits<base::Callback<void __cdecl(gcm::MCSMessage const &),1,1>,void>::Invoke<base::Callback<void __cdecl(gcm::MCSMessage const &),1,1> const &,gcm::MCSMessage const &> [0x01576FDF+96]
	base::internal::Invoker<base::internal::BindState<base::Callback<void __cdecl(gcm::MCSMessage const &),1,1>,gcm::MCSMessage>,void __cdecl(void)>::Run [0x0157AE1D+19]
	base::debug::TaskAnnotator::RunTask [0x0198CC1F+383]
	base::MessageLoop::RunTask [0x01915B4C+1228]
	base::MessageLoop::DoWork [0x01914A03+611]
	base::MessagePumpForUI::DoRunLoop [0x0198DE7D+93]
	base::MessagePumpWin::Run [0x0198E61A+74]
	base::MessageLoop::RunHandler [0x01915671+305]
	base::RunLoop::Run [0x01918564+132]
	extensions::TestExtensionRegistryObserver::Wait [0x0401A383+24]
	extensions::TestExtensionRegistryObserver::WaitForExtensionLoaded [0x0401A3CB+9]
	ExtensionBrowserTest::LoadExtensionWithInstallParam [0x0083B46E+124]
	std::default_delete<TemplateURLData>::operator() [0x0047A252+1542]
	InProcessBrowserTest::RunTestOnMainThreadLoop [0x019B209D+180]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x01D48B9C+175]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x01C10761+3404]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x01C0F9DD+167]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x0138C773+112]
	base::internal::RunMixin<base::Callback<bool __cdecl(void),1,1> >::Run [0x02E9EFA2+25]
	content::BrowserMainRunnerImpl::Initialize [0x0138DB24+681]
	content::BrowserMain [0x01389148+117]
	content::RunNamedProcessTypeMain [0x018F0749+206]
	content::ContentMainRunnerImpl::Run [0x018F064A+280]
	content::ContentMain [0x018EFB14+35]
	content::BrowserTestBase::SetUp [0x01D491D4+971]
	InProcessBrowserTest::SetUp [0x019B240F+268]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x02258F34+32]
	testing::Test::Run [0x0225FF3F+51]
	testing::TestCase::Run [0x02260015+133]
	testing::internal::UnitTestImpl::RunAllTests [0x02260394+433]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x02258F78+32]
	testing::UnitTest::Run [0x022601BE+133]
	base::TestSuite::Run [0x019BE6B7+95]
	ChromeTestSuiteRunner::RunTestSuite [0x040843BC+40]
	content::LaunchTests [0x01D4297B+583]
	LaunchChromeTests [0x04084380+139]
	main [0x0408411C+63]
	__scrt_common_main_seh [0x04048EFF+249] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x773A336A+18]
	RtlInitializeExceptionChain [0x77B39882+99]
	RtlInitializeExceptionChain [0x77B39855+54]

Comment 8 by foolip@chromium.org, Jan 10 2017

Labels: -Sheriff-Chromium
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8534d16a27bc5999a28c0d964e1a5b5409617b39

commit 8534d16a27bc5999a28c0d964e1a5b5409617b39
Author: foolip <foolip@chromium.org>
Date: Tue Jan 10 16:51:03 2017

Revert of Make extensions DSE persistent in browser prefs (patchset #15 id:280001 of https://codereview.chromium.org/2479113002/ )

Reason for revert:
ExtensionBrowserTest.OverrideHomePageSettings and ExtensionBrowserTest.OverrideStartupPagesSettings are flaky.

BUG= 679470 , 679569 

Original issue's description:
> Make extensions DSE persistent in browser prefs
>
> This fix stores extension installed DSE in browser prefs using extension
> overriden preferences API. This is needed so extension installed default
> search would be available from browser before extensions subsystem load.
> This will affect url for first loaded NTP which is taken from current
> default search settings.
>
> BUG= 450534 
>
> R=pkasting@chromium.org, vasilii@chromium.org
>
> Review-Url: https://codereview.chromium.org/2479113002
> Cr-Commit-Position: refs/heads/master@{#442235}
> Committed: https://chromium.googlesource.com/chromium/src/+/f5f1407adee2b18b59b33fb8d74739dcc27d8c0b

TBR=gab@chromium.org,hashimoto@chromium.org,maxbogue@chromium.org,pkasting@chromium.org,vasilii@chromium.org,a-v-y@yandex-team.ru
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 450534 

Review-Url: https://codereview.chromium.org/2623833005
Cr-Commit-Position: refs/heads/master@{#442612}

[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/extensions/api/settings_overrides/settings_overrides_browsertest.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/prefs/session_startup_pref.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/search_engines/template_url_service_sync_unittest.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/search_engines/template_url_service_test_util.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/search_engines/template_url_service_test_util.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/chrome/browser/search_engines/template_url_service_unittest.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/BUILD.gn
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/default_search_manager.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/default_search_manager.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/default_search_manager_unittest.cc
[delete] https://crrev.com/2cad8b6680852a10a9e6e342c8b78dd701e8c656/components/search_engines/search_engines_test_util.cc
[delete] https://crrev.com/2cad8b6680852a10a9e6e342c8b78dd701e8c656/components/search_engines/search_engines_test_util.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/template_url.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/template_url.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/template_url_prepopulate_data.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/template_url_prepopulate_data.h
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/template_url_service.cc
[modify] https://crrev.com/8534d16a27bc5999a28c0d964e1a5b5409617b39/components/search_engines/template_url_service.h
Project Member

Comment 10 by chromium...@appspot.gserviceaccount.com, Jan 10 2017

Labels: Sheriff-Chromium
Detected 6 new flakes for test/step "ExtensionBrowserTest.OverrideHomePageSettings". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOAsSBUZsYWtlIi1FeHRlbnNpb25Ccm93c2VyVGVzdC5PdmVycmlkZUhvbWVQYWdlU2V0dGluZ3MM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 11 by timloh@chromium.org, Jan 11 2017

Labels: -Sheriff-Chromium
Status: Fixed (was: Assigned)
Looks like the revert fixed it, flakes linked from comment #10 are all prior to the revert patch. Marking this as fixed but please take care when re-landing that the flake has been resolved, thanks!
►

Sign in to add a comment