New issue
Advanced search Search tips

Issue 679466 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Preserve Wallet's credit card and address relationship

Project Member Reported by se...@chromium.org, Jan 9 2017 
When wallet cards are synced, they contain a billing_address_id field which refers to a wallet address.

We should use that information to make the wallet card in Autofill refer to it's associated wallet address in Autofill. 

That information should then be saved in the autofill_table on disc

NOTE: if the billing address id on disk points to a local autofill address, it should not be overwritten to a wallet address.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d46ba3e386640479b40c62ce9e7e53d61f4baa65

commit d46ba3e386640479b40c62ce9e7e53d61f4baa65
Author: sebsg <sebsg@chromium.org>
Date: Tue Jan 10 16:38:58 2017

[Payments] Preserve Wallet's card to billing address link after sync.

Uses the relationship between a card and its billing address pulled
from sync to populate the billing_address_id of the generated
CreditCard object.

Overwrites the billing_address_id saved on disk only if it is not 36
characters long, which would represent a local profile. This only
happens if the user manually associated the Card to a local Autofill
Profile in PaymentRequest.

BUG= 679466 

Review-Url: https://codereview.chromium.org/2619423002
Cr-Commit-Position: refs/heads/master@{#442610}

[modify] https://crrev.com/d46ba3e386640479b40c62ce9e7e53d61f4baa65/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/d46ba3e386640479b40c62ce9e7e53d61f4baa65/components/autofill/core/browser/webdata/autofill_table.cc
[modify] https://crrev.com/d46ba3e386640479b40c62ce9e7e53d61f4baa65/components/autofill/core/browser/webdata/autofill_table.h
[modify] https://crrev.com/d46ba3e386640479b40c62ce9e7e53d61f4baa65/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc
[modify] https://crrev.com/d46ba3e386640479b40c62ce9e7e53d61f4baa65/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.h
[add] https://crrev.com/d46ba3e386640479b40c62ce9e7e53d61f4baa65/components/autofill/core/browser/webdata/autofill_wallet_syncable_service_unittest.cc

Comment 2 by se...@chromium.org, Jan 10 2017

Status: Fixed (was: Started)

Comment 3 by se...@chromium.org, Feb 6 2017

Labels: Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 6 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Feb 6 2017 

Please merge your change to M57 branch 2987 before 5:00 PM PT, Tuesday (02/07/17) so we can pick it up for next Beta release. Thank you.

Comment 6 by se...@chromium.org, Feb 6 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-57
Cancelled the merge request

Comment 7 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment