Thanks for compiling, Evan!

I'm unfamiliar with the codebase, so I can't distinguish the in-product location of each link. I can create p-links/OTA contexts, but I would need screenshots for each of the 43 results in order to name them/track them intelligently :(

creating ~50 screenshots is going to be very difficult because no one individual knows how to trigger each feature that uses one of these links (or has the proper setup to do so, i.e. some may be unique to setups like supervised users on ChromeOS). Would a description not suffice? e.g. "this link is shown in an autofill dropdown to explain why Autofill is disabled when a site is not using valid https"

Sure, if screenshots aren't available, then a description would be helpful! Thank you :)

+the ConOps hotlist 

Taking care of 
a) finding all the links that need updating
b) gathering enough product context (screenshots, descriptions, etc.) to get new links

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e17314a0eeb014ead59c49754ee6bb2e301dfb2b

commit e17314a0eeb014ead59c49754ee6bb2e301dfb2b
Author: estade <estade@chromium.org>
Date: Thu Jan 12 16:22:16 2017

Add presubmit check for Google support URL format.

See bug for details. tl;dr: we should not use direct links like
support.google.com/chrome/answer/123456

For now this is an ignoreable upload-only prompt.

BUG=679462

Review-Url: https://codereview.chromium.org/2627023003
Cr-Commit-Position: refs/heads/master@{#443255}

[modify] https://crrev.com/e17314a0eeb014ead59c49754ee6bb2e301dfb2b/PRESUBMIT.py
[modify] https://crrev.com/e17314a0eeb014ead59c49754ee6bb2e301dfb2b/PRESUBMIT_test.py

(that presubmit check should help avoid adding new mis-formatted URLs)

Quick Summary of P-Links
P-Links is a source of analytics for Online Help Center team who use it to track traffic coming to a particular page from within the product. This is used to track impact of UI changes or bugs on consumers. No PII is collected when user clicks on an in-product link.

Link location in code, new P-Links (TBD) with names of product owners can be found in this trix https://goto.google.com/drtno

Code at the moment has 69 unique help center links for following products
Accounts Chromebook, Chrome, Chrome web store, Enterprise (G-Suite), Drive, Websearch, Chromecast, Youtube, Picasa (Google Photos), Calendar, webmasters, Google Plus, Adwords and Adsense

Met Meggyn and we agreed to add description or screenshot to this trix to request a P-Link.

Can we please give instructions on what we should do when we encounter this presubmit check? I ran into this presubmit check and am happy to do what is needed to fix it in my patch, however I have no idea what I should do to help correct this issue.

For now I am bypassing hooks because there are no details on what should be done to these cases.

P-Links are a way to symlink help articles in Chrome. This is better than linking direct articles which are deprecated as part of optimization and cleanup.

Can you provide me with Help center article you are trying to add and I can help you get a P-Link ?

@jainabhishek would it be possible for you to help get a P link for:
https://support.google.com/chrome/answer/99020

Or let me know the process for doing so. I see it's listed in the spreadsheet already.

I'm currently refactoring the safe browsing interstitials and need to have it ready for feature freeze - chrome://interstitials/safebrowsing?type=malware
https://cs.chromium.org/chromium/src/components/security_interstitials/core/safe_browsing_error_ui.cc

Can I have a P link for this help article please?
https://support.google.com/chrome/answer/142893

Hey Rouslan – I emailed you :)

To all others who come across this bug in the future:
(1) Please file a bug at go/chromehcrequest
(2) Include what platform you're working on. This is important for me to know, because Android uses OTA contexts instead of p-links (more info: go/open-to-article)
(3) Include a screenshot of where the p-link will live. This is good hygiene for tracking traffic :) It also helps me find out if a relevant p-link already exists so I can give you that one!

Cheers,
Megg

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc7fa859a420eeafb1b6050f0084f6765ee996ac

commit cc7fa859a420eeafb1b6050f0084f6765ee996ac
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Wed May 31 16:03:01 2017

[Payments] Use HelpAndFeedback instead of opening the help URL directly.

Before this patch, clicking on the question mark in the card editor on
Android web payment UI would open a Chrome custom tab with the
hard-coded URL of the help page. Chrome should be using Help articles
throughout, however. This patch switches from opening the hard-coded URL
directly to opening HelpAndFeedback for android_autofill_ota, which is
controlled server-side. After this patch, Chrome is launching Help
article for autofill instead of a Chrome custom tab. The URL is of the
article remains the same.

Bug: 679462
Change-Id: Ie5f511d964090d93c9f7f7814b1d9b120f9efdd2
Reviewed-on: https://chromium-review.googlesource.com/506747
Reviewed-by: Theresa Wellington <twellington@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475931}
[modify] https://crrev.com/cc7fa859a420eeafb1b6050f0084f6765ee996ac/chrome/android/java/res/values/values.xml
[modify] https://crrev.com/cc7fa859a420eeafb1b6050f0084f6765ee996ac/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDialog.java

At a glance, there are a few URLs which look like this:
https://support.google.com/chrome/answer/114836?p=settings_privacy

Should they instead be:
https://support.google.com/chrome/?p=settings_privacy"

Yes, p links should look like "https://support.google.com/chrome/?p=settings_privacy"

The answer/ID should not be included in the URL.

On iOS per https://bugs.chromium.org/p/chromium/issues/detail?id=863927#c21 using the id was the only way to display only iOS content. Removing the id displays the Android/Desktop tab as well, which could cause the App to get rejected by Apple. 
(Our PM brought up these concerns and thats why we're keeping the ID for now)