Some sites do not have an offline bage on the NTP even after users have downloaded them |
|||||
Issue descriptionVersion: 57.0.2970.0 OS: Android 6.0.1 Device: Nexus 7 Some sites do not have an offline bage on the NTP even after users have downloaded them. For example, www.yahoo.com; www.cnn.com; www.espn.com What steps will reproduce the problem? (1) Internet is on and start Chrome with offline pages enabled (2) Open a new tab and go to www.yahoo.com or www.cnn.com or www.espn.com (3) Click the download button and wait for the download to finish (4) Close Chrome and reopen Chrome (5) Open a new tab and observe What is the expected result? Items on the NTP for offline copies will have an offline badge. What happens instead? www.yahoo.com or www.cnn.com or www.espn.com did not have an offline badge. Please check out the attached screenshots.
,
Jan 9 2017
,
Jan 9 2017
The above are against Chrome Dev. I also tested the same testing scenarios in Chrome Beta in Nexus 7. In Nexus 7 the system behavior of Chrome Dev is the same as that of Chrome Beta: www.yahoo.com or www.cnn.com or www.espn.com does not have an offline badge on the NTP. And I tested the same testing scenarios in Chrome Beta in Sam Sung Galaxy S5. In S5 the system behavior of Chrome Dev is the same as that of Chrome Beta: www.yahoo.com or www.espn.com does not have an offline badge on the NTP but www.cnn.com has an offline badge on the NTP.
,
Jan 11 2017
I believe NTP should triage this one. Thought: This might be URL mismatch.
,
Jan 12 2017
peconn@, could you redirect accordingly? Unfortunately, I cannot find who is responsible for MostVisitedItems and it seems that treib@ was the last to touch them. Can this be the case when OfflinePage model is not loaded yet, but NTP has been built already?
,
Jan 12 2017
#5, that's totally possible but the time window is short. Tom, does this only occur for the first tab opened after restarting Chrome?
,
Jan 13 2017
dewittj@ "Tom, does this only occur for the first tab opened after restarting Chrome?" No. It occurred for not only the first tab but also other tabs.
,
Jan 25 2017
,
May 4 2017
Hi everyone. It can be verified that it is not a URL mismatch by doing the following. 1. Visit www.yahoo.com enough times to make it appear in the NTP as a tile. 2. Now click on this tile. In my case, it redirects to in.yahoo.com 3. Download the page. 4. Open a new tab. There is no offline badge on the tile. Since we started the navigation with the tile itself, the url of the tile should have matched the offline page's original_url. After a little bit of debugging, I could see that the original_url of the offline page was empty. We get the original url here OfflinePageUtils::GetOriginalURLFromWebContents If the original URL was present, it would have matched and the offline badge would have shown. I am a little new to offline pages so I might be wrong. But the problem might be due to NavigationEntry not getting the right redirect chain in case of yahoo.com and espn.com.
,
Jul 5 2017
Maybe issue 739289 helps as it shows a reproducible case of a wrong offline badge. (If there is such thing as priority inheritance and the bugs are related, we should consider promoting this P3 here a little bit). |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jiewu@chromium.org
, Jan 9 20171.7 MB
1.7 MB View Download
2.0 MB
2.0 MB View Download