Issue metadata
Sign in to add a comment
|
No separator should appear at the right-hand side of the shelf |
||||||||||||||||||||||
Issue descriptionAn extra separator sometimes appears on the right-hand side of the shelf as shown in the screenshot attached.
,
Jan 9 2017
yiyix@, could it be your recent change?
,
Jan 9 2017
#1, I can see it in dev - 57.0.2970.0 on samus.
,
Jan 9 2017
It is due to my changes. Sorry i didn't notice it when i test the UI.
,
Jan 9 2017
This bug is due to changes in this, https://bugs.chromium.org/p/chromium/issues/detail?id=657211, and it had made to M56. I will fix it and request to merge to M56.
,
Jan 9 2017
FYI https://bugs.chromium.org/p/chromium/issues/detail?id=657211 hasn't been merged to M56 yet. We can wait until this fix is ready and merge both together.
,
Jan 9 2017
@sgabriel, could you please correct the bug description? This bug should always appear.
,
Jan 9 2017
,
Jan 9 2017
Note that I see this consistently on dev channel in Guest mode.
,
Jan 9 2017
,
Jan 9 2017
Issue 677200 has been merged into this issue.
,
Jan 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee16fc4f187bb47b7a2a0535c59ae9feb152a169 commit ee16fc4f187bb47b7a2a0535c59ae9feb152a169 Author: yiyix <yiyix@chromium.org> Date: Tue Jan 10 05:49:29 2017 Remove the extra separator appears on the right side of the shelf TEST=MANUAL BUG= 679427 Review-Url: https://codereview.chromium.org/2618383003 Cr-Commit-Position: refs/heads/master@{#442502} [modify] https://crrev.com/ee16fc4f187bb47b7a2a0535c59ae9feb152a169/ash/common/system/chromeos/session/logout_button_tray.cc [modify] https://crrev.com/ee16fc4f187bb47b7a2a0535c59ae9feb152a169/ash/common/system/tray/system_tray.cc [modify] https://crrev.com/ee16fc4f187bb47b7a2a0535c59ae9feb152a169/ash/common/system/tray/tray_background_view.cc [modify] https://crrev.com/ee16fc4f187bb47b7a2a0535c59ae9feb152a169/ash/common/system/tray/tray_background_view.h
,
Jan 10 2017
,
Jan 11 2017
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 11 2017
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5aa9a1cdb8ccc25e665ace40f12f7d4a0bafe1e5 commit 5aa9a1cdb8ccc25e665ace40f12f7d4a0bafe1e5 Author: Ben Ruthig <bruthig@chromium.org> Date: Wed Jan 11 15:21:11 2017 Remove the extra separator appears on the right side of the shelf TEST=MANUAL BUG= 679427 Review-Url: https://codereview.chromium.org/2618383003 Cr-Commit-Position: refs/heads/master@{#442502} (cherry picked from commit ee16fc4f187bb47b7a2a0535c59ae9feb152a169) Review-Url: https://codereview.chromium.org/2621323003 . Cr-Commit-Position: refs/branch-heads/2924@{#731} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/5aa9a1cdb8ccc25e665ace40f12f7d4a0bafe1e5/ash/common/system/chromeos/session/logout_button_tray.cc [modify] https://crrev.com/5aa9a1cdb8ccc25e665ace40f12f7d4a0bafe1e5/ash/common/system/tray/system_tray.cc [modify] https://crrev.com/5aa9a1cdb8ccc25e665ace40f12f7d4a0bafe1e5/ash/common/system/tray/tray_background_view.cc [modify] https://crrev.com/5aa9a1cdb8ccc25e665ace40f12f7d4a0bafe1e5/ash/common/system/tray/tray_background_view.h
,
Jan 20 2017
Verified on ChromeOS 9202.0.0, 57.0.2984.0
,
Jan 20 2017
Also verified on 9000.66.0, 56.0.2924.67 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bruthig@chromium.org
, Jan 9 2017