New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679397 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Image notification popup overlaps on uber tray during animation

Project Member Reported by rookrishna@chromium.org, Jan 9 2017

Issue description

Chrome 57.0.2970.0/9150.0.0 samus

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:

(1) Have couple of notifications  with top one to be a image notification.
(2)Close all the notification below  the image notification.


Expected Result: Image notification must not overlap on the uber tray.

Actual Result:Image notification overlaps on the uber tray.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

This issue is only with the image notifications with above mentioned steps

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.




 
Screenshot 2017-01-09 at 9.34.17 AM.png
4.0 MB View Download
Cc: yoshiki@chromium.org
+yoshiki

rookrishna@, what happens if you move mouse out of the notification list? Would we re-layout and put the panel to a proper position?
Yes it does re-layout  for other image notification but for the Art project from Google cultural Institute notification it does not .
What is the app name? Is it "Google Arts & Culture"?
Its APOD wallpaper  for chromebooks
Thanks.

That is a chrome app. The screenshot looks like it shows up an a floating bubble rather than inside the notification list. So the problem is probably related to MessagePopupCollection code.
Owner: xiy...@chromium.org
xiyuan@ can you route to a better owner for the MessagePopupCollection code?
Status: Assigned (was: Untriaged)

Comment 8 by na...@chromium.org, Jan 19 2018

Hi xiyuan@! Requesting an update since this is marked as Pri1. If this no longer repros, please can you close the bug? If you're not the best person to deal with this right now, please can you unassign? Thanks!

Comment 9 by xiy...@chromium.org, Jan 19 2018

Labels: -Pri-1 -M-57 M-66 Pri-2
Owner: est...@chromium.org
Lowering to P2 since it is found for one app (APOD wallpaper for chromebooks) per #2 and #4.

Passing to estade@ to re-assign.

Comment 10 by estade@google.com, Jan 19 2018

Cc: est...@chromium.org
Owner: tetsui@chromium.org
I may have caused this regression, or it may be due to recent MD notifications work. Tetsui, could you ptal?
The original bug is quite old so I believe it's not related to either recent refactoring or MD notifications work.
I could not reproduce the bug on 65.0.3319.0 (#0 says the notification overlaps on the uber tray after the animation is finished, not just during the animation, right?). However, the notification does overlap on the uber tray during the animation, and it doesn't look WAI. Let me take a further look.
Summary: Image notification popup overlaps on uber tray during animation (was: Image notification glitch)
Status: Started (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f74b246af41caff323ea072d2aee02c7960a9bb

commit 3f74b246af41caff323ea072d2aee02c7960a9bb
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Thu Feb 08 01:53:46 2018

Use the bottom edge of notification toast for reposition target.

When the notification popup (or toast, the terms are interchangeable) is
removed, usually the remaining notifications would move down to fill the space.

Previously, we were using the top y coordinate of the removed notification as
the target location of the oldest notification toast, but this was assuming
all the notifications have the same height, which is not true.

This CL changes the behavior to use the bottom y coordinate for the aniamtion
target location.
On some platforms with the task bar on the top of the screen, notification
toasts are aligned top down. In such case, we still have to use the top y
coordinate. GetTargetEdge handles that.

TEST=MessagePopupCollectionTest.MultipleNotificationHeight
BUG= 679397 

Change-Id: I1831d594eea0d741660142f9c5623eaa9c376476
Reviewed-on: https://chromium-review.googlesource.com/895229
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535249}
[modify] https://crrev.com/3f74b246af41caff323ea072d2aee02c7960a9bb/ui/message_center/views/message_popup_collection.cc
[modify] https://crrev.com/3f74b246af41caff323ea072d2aee02c7960a9bb/ui/message_center/views/message_popup_collection.h
[modify] https://crrev.com/3f74b246af41caff323ea072d2aee02c7960a9bb/ui/message_center/views/message_popup_collection_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment