New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 679385 link

Starred by 3 users
Status: Fixed
Owner:
loonyb...@chromium.org
Closed: Jan 2017
Cc:
█ sanjoy....@samsung.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623682



Sign in to add a comment

Feature Policy: Support PaymentRequest API

Project Member Reported by lunalu@chromium.org, Jan 9 2017 
Add support for the "payment" feature in Feature Policy.

The feature has been defined already in FeaturePolicy.cpp as kPaymentFeature. It should be checked before allowing the use of the constructor PaymentRequest.PaymentRequest()

If not allowed by policy, the call to the constructor should result in an exception with a SecurityError.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/662473565c1dd46ec06077c8e6519c195814b46d

commit 662473565c1dd46ec06077c8e6519c195814b46d
Author: lunalu <lunalu@chromium.org>
Date: Thu Jan 19 18:36:15 2017

Initial implementation for feature policy - PaymentRequest

Disable PaymentRequest API unless enabled through feature policy.

BUG= 679385 

Review-Url: https://codereview.chromium.org/2618383002
Cr-Commit-Position: refs/heads/master@{#444797}

[add] https://crrev.com/662473565c1dd46ec06077c8e6519c195814b46d/third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-disabled-expected.txt
[add] https://crrev.com/662473565c1dd46ec06077c8e6519c195814b46d/third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-disabled.php
[add] https://crrev.com/662473565c1dd46ec06077c8e6519c195814b46d/third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-enabledforall-expected.txt
[add] https://crrev.com/662473565c1dd46ec06077c8e6519c195814b46d/third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-enabledforall.php
[add] https://crrev.com/662473565c1dd46ec06077c8e6519c195814b46d/third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-enabledforself-expected.txt
[add] https://crrev.com/662473565c1dd46ec06077c8e6519c195814b46d/third_party/WebKit/LayoutTests/http/tests/feature-policy/payment-enabledforself.php
[add] https://crrev.com/662473565c1dd46ec06077c8e6519c195814b46d/third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-payment-disabled.html
[add] https://crrev.com/662473565c1dd46ec06077c8e6519c195814b46d/third_party/WebKit/LayoutTests/http/tests/feature-policy/resources/feature-policy-payment-enabled.html
[add] https://crrev.com/662473565c1dd46ec06077c8e6519c195814b46d/third_party/WebKit/LayoutTests/virtual/feature-policy/http/tests/feature-policy/payment-disabled-expected.txt
[add] https://crrev.com/662473565c1dd46ec06077c8e6519c195814b46d/third_party/WebKit/LayoutTests/virtual/feature-policy/http/tests/feature-policy/payment-enabledforall-expected.txt
[add] https://crrev.com/662473565c1dd46ec06077c8e6519c195814b46d/third_party/WebKit/LayoutTests/virtual/feature-policy/http/tests/feature-policy/payment-enabledforself-expected.txt
[modify] https://crrev.com/662473565c1dd46ec06077c8e6519c195814b46d/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Comment 2 by lunalu@chromium.org, Jan 26 2017

Status: Fixed (was: Started)

Comment 3 by iclell...@chromium.org, Mar 24 2017

Cc: sanjoy....@samsung.com
 Issue 666762  has been merged into this issue.

Comment 4 by rbyers@chromium.org, Jul 18 2017

Owner: loonyb...@chromium.org
►

Sign in to add a comment