A UI is needed to display the suggestions offered by the suggestion service. This UI is a CollectionView.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5 commit 9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5 Author: gambard <gambard@chromium.org> Date: Wed Jan 11 10:23:08 2017 Creates the Suggestions UI This CL creates the Suggestions UI with a Collection View. BUG= 679369 Review-Url: https://codereview.chromium.org/2619353004 Cr-Commit-Position: refs/heads/master@{#442850} [add] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/chrome/browser/ui/suggestions/BUILD.gn [add] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/chrome/browser/ui/suggestions/OWNERS [add] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/chrome/browser/ui/suggestions/suggestions_commands.h [add] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/chrome/browser/ui/suggestions/suggestions_item_actions.h [add] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/chrome/browser/ui/suggestions/suggestions_view_controller.h [add] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/chrome/browser/ui/suggestions/suggestions_view_controller.mm [modify] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/showcase/BUILD.gn [modify] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/showcase/core/BUILD.gn [modify] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/showcase/core/showcase_model.mm [add] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/showcase/suggestions/BUILD.gn [add] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/showcase/suggestions/DEPS [add] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/showcase/suggestions/sc_suggestions_coordinator.h [add] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/showcase/suggestions/sc_suggestions_coordinator.mm [add] https://crrev.com/9bc6853db6c493cf5833496d2b92fd7e3ff7f5a5/ios/showcase/suggestions/sc_suggestions_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/184a5d740d8a272e114007a7822d4b5640ace354 commit 184a5d740d8a272e114007a7822d4b5640ace354 Author: gambard <gambard@chromium.org> Date: Thu Jan 12 12:53:43 2017 Suggestions UI - Add Data Source and Item BUG= 679369 Review-Url: https://codereview.chromium.org/2619963004 Cr-Commit-Position: refs/heads/master@{#443215} [modify] https://crrev.com/184a5d740d8a272e114007a7822d4b5640ace354/ios/chrome/browser/ui/suggestions/BUILD.gn [add] https://crrev.com/184a5d740d8a272e114007a7822d4b5640ace354/ios/chrome/browser/ui/suggestions/suggestions_collection_updater.h [add] https://crrev.com/184a5d740d8a272e114007a7822d4b5640ace354/ios/chrome/browser/ui/suggestions/suggestions_collection_updater.mm [add] https://crrev.com/184a5d740d8a272e114007a7822d4b5640ace354/ios/chrome/browser/ui/suggestions/suggestions_item.h [add] https://crrev.com/184a5d740d8a272e114007a7822d4b5640ace354/ios/chrome/browser/ui/suggestions/suggestions_item.mm [modify] https://crrev.com/184a5d740d8a272e114007a7822d4b5640ace354/ios/chrome/browser/ui/suggestions/suggestions_view_controller.h [modify] https://crrev.com/184a5d740d8a272e114007a7822d4b5640ace354/ios/chrome/browser/ui/suggestions/suggestions_view_controller.mm [modify] https://crrev.com/184a5d740d8a272e114007a7822d4b5640ace354/ios/showcase/suggestions/sc_suggestions_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1d73f239ba994051cf60f02d0531cef7875094a commit d1d73f239ba994051cf60f02d0531cef7875094a Author: gambard <gambard@chromium.org> Date: Thu Jan 12 17:06:48 2017 Suggestions UI - Add Article items BUG= 679369 Review-Url: https://codereview.chromium.org/2618333005 Cr-Commit-Position: refs/heads/master@{#443266} [modify] https://crrev.com/d1d73f239ba994051cf60f02d0531cef7875094a/ios/chrome/browser/ui/suggestions/BUILD.gn [add] https://crrev.com/d1d73f239ba994051cf60f02d0531cef7875094a/ios/chrome/browser/ui/suggestions/suggestions_article_item.h [add] https://crrev.com/d1d73f239ba994051cf60f02d0531cef7875094a/ios/chrome/browser/ui/suggestions/suggestions_article_item.mm [add] https://crrev.com/d1d73f239ba994051cf60f02d0531cef7875094a/ios/chrome/browser/ui/suggestions/suggestions_article_item_unittest.mm [modify] https://crrev.com/d1d73f239ba994051cf60f02d0531cef7875094a/ios/chrome/browser/ui/suggestions/suggestions_collection_updater.mm [modify] https://crrev.com/d1d73f239ba994051cf60f02d0531cef7875094a/ios/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a26ea51a7b89d72ea18a9bf3583440a63be766d commit 9a26ea51a7b89d72ea18a9bf3583440a63be766d Author: gambard <gambard@chromium.org> Date: Tue Jan 17 15:37:08 2017 Suggestions UI - expandable item BUG= 679369 Review-Url: https://codereview.chromium.org/2625693002 Cr-Commit-Position: refs/heads/master@{#444056} [modify] https://crrev.com/9a26ea51a7b89d72ea18a9bf3583440a63be766d/ios/chrome/browser/ui/suggestions/BUILD.gn [add] https://crrev.com/9a26ea51a7b89d72ea18a9bf3583440a63be766d/ios/chrome/browser/ui/suggestions/expandable_item.h [modify] https://crrev.com/9a26ea51a7b89d72ea18a9bf3583440a63be766d/ios/chrome/browser/ui/suggestions/suggestions_collection_updater.h [modify] https://crrev.com/9a26ea51a7b89d72ea18a9bf3583440a63be766d/ios/chrome/browser/ui/suggestions/suggestions_collection_updater.mm [add] https://crrev.com/9a26ea51a7b89d72ea18a9bf3583440a63be766d/ios/chrome/browser/ui/suggestions/suggestions_expandable_item.h [add] https://crrev.com/9a26ea51a7b89d72ea18a9bf3583440a63be766d/ios/chrome/browser/ui/suggestions/suggestions_expandable_item.mm [add] https://crrev.com/9a26ea51a7b89d72ea18a9bf3583440a63be766d/ios/chrome/browser/ui/suggestions/suggestions_expandable_item_unittest.mm [add] https://crrev.com/9a26ea51a7b89d72ea18a9bf3583440a63be766d/ios/chrome/browser/ui/suggestions/suggestions_item_unittest.mm [modify] https://crrev.com/9a26ea51a7b89d72ea18a9bf3583440a63be766d/ios/chrome/browser/ui/suggestions/suggestions_view_controller.h [modify] https://crrev.com/9a26ea51a7b89d72ea18a9bf3583440a63be766d/ios/chrome/browser/ui/suggestions/suggestions_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0eaba9df22671feb4ac013ec4257e053666d94fc commit 0eaba9df22671feb4ac013ec4257e053666d94fc Author: gambard <gambard@chromium.org> Date: Tue Jan 17 16:29:20 2017 Use ARC for Suggestions tests BUG= 679369 Review-Url: https://codereview.chromium.org/2633243003 Cr-Commit-Position: refs/heads/master@{#444068} [modify] https://crrev.com/0eaba9df22671feb4ac013ec4257e053666d94fc/ios/chrome/browser/ui/suggestions/BUILD.gn [modify] https://crrev.com/0eaba9df22671feb4ac013ec4257e053666d94fc/ios/chrome/browser/ui/suggestions/suggestions_article_item_unittest.mm [modify] https://crrev.com/0eaba9df22671feb4ac013ec4257e053666d94fc/ios/chrome/browser/ui/suggestions/suggestions_expandable_item_unittest.mm [modify] https://crrev.com/0eaba9df22671feb4ac013ec4257e053666d94fc/ios/chrome/browser/ui/suggestions/suggestions_item_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/359779f98091859cf37500d5ae3505aee346f955 commit 359779f98091859cf37500d5ae3505aee346f955 Author: gambard <gambard@chromium.org> Date: Tue Jan 17 17:29:47 2017 Suggestions UI - stack item BUG= 679369 Review-Url: https://codereview.chromium.org/2630313004 Cr-Commit-Position: refs/heads/master@{#444080} [modify] https://crrev.com/359779f98091859cf37500d5ae3505aee346f955/ios/chrome/browser/ui/suggestions/BUILD.gn [modify] https://crrev.com/359779f98091859cf37500d5ae3505aee346f955/ios/chrome/browser/ui/suggestions/suggestions_collection_updater.h [modify] https://crrev.com/359779f98091859cf37500d5ae3505aee346f955/ios/chrome/browser/ui/suggestions/suggestions_collection_updater.mm [modify] https://crrev.com/359779f98091859cf37500d5ae3505aee346f955/ios/chrome/browser/ui/suggestions/suggestions_commands.h [add] https://crrev.com/359779f98091859cf37500d5ae3505aee346f955/ios/chrome/browser/ui/suggestions/suggestions_stack_item.h [add] https://crrev.com/359779f98091859cf37500d5ae3505aee346f955/ios/chrome/browser/ui/suggestions/suggestions_stack_item.mm [add] https://crrev.com/359779f98091859cf37500d5ae3505aee346f955/ios/chrome/browser/ui/suggestions/suggestions_stack_item_actions.h [add] https://crrev.com/359779f98091859cf37500d5ae3505aee346f955/ios/chrome/browser/ui/suggestions/suggestions_stack_item_unittest.mm [modify] https://crrev.com/359779f98091859cf37500d5ae3505aee346f955/ios/chrome/browser/ui/suggestions/suggestions_view_controller.mm [modify] https://crrev.com/359779f98091859cf37500d5ae3505aee346f955/ios/showcase/suggestions/sc_suggestions_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7de29d98ff473630649264e9837bfc4235d0921d commit 7de29d98ff473630649264e9837bfc4235d0921d Author: gambard <gambard@chromium.org> Date: Fri Jan 20 16:22:11 2017 Suggestions UI - favicon item BUG= 679369 Review-Url: https://codereview.chromium.org/2640473002 Cr-Commit-Position: refs/heads/master@{#445069} [modify] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/chrome/browser/ui/suggestions/BUILD.gn [modify] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/chrome/browser/ui/suggestions/suggestions_collection_updater.h [modify] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/chrome/browser/ui/suggestions/suggestions_collection_updater.mm [modify] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/chrome/browser/ui/suggestions/suggestions_commands.h [add] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/chrome/browser/ui/suggestions/suggestions_favicon_internal_cell.h [add] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/chrome/browser/ui/suggestions/suggestions_favicon_internal_cell.mm [add] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/chrome/browser/ui/suggestions/suggestions_favicon_item.h [add] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/chrome/browser/ui/suggestions/suggestions_favicon_item.mm [add] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/chrome/browser/ui/suggestions/suggestions_favicon_item_unittest.mm [modify] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/chrome/browser/ui/suggestions/suggestions_item.mm [modify] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/chrome/browser/ui/suggestions/suggestions_view_controller.h [modify] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/chrome/browser/ui/suggestions/suggestions_view_controller.mm [modify] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/showcase/common/protocol_alerter.mm [modify] https://crrev.com/7de29d98ff473630649264e9837bfc4235d0921d/ios/showcase/suggestions/sc_suggestions_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2e44fbf6b351a10a698b1571019fe0a06bf132c commit d2e44fbf6b351a10a698b1571019fe0a06bf132c Author: gambard <gambard@chromium.org> Date: Wed Jan 25 09:14:21 2017 Add the suggestions UI in chrome This CL adds an entry to the toolbar menu to enter the suggestions UI. The position in the toolbar menu is not ideal but it is useful to test the UI in the context of Chrome. It will be changed. This entry is accessible using an experimental setting. BUG= 679369 Review-Url: https://codereview.chromium.org/2643753002 Cr-Commit-Position: refs/heads/master@{#445984} [modify] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/chrome_switches.cc [modify] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/chrome_switches.h [add] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/content_suggestions/BUILD.gn [add] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/content_suggestions/OWNERS [add] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.h [add] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/experimental_flags.h [modify] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/experimental_flags.mm [modify] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/resources/Settings.bundle/Experimental.plist [modify] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/ui/commands/ios_command_ids.h [modify] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h [modify] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm [modify] https://crrev.com/d2e44fbf6b351a10a698b1571019fe0a06bf132c/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9756a18af5acb7fcc5f674b7908d9daeaf3357ba commit 9756a18af5acb7fcc5f674b7908d9daeaf3357ba Author: gambard <gambard@chromium.org> Date: Wed Jan 25 10:13:08 2017 Move ios/ui/suggestions to ios/ui/content_suggestions BUG= 679369 Review-Url: https://codereview.chromium.org/2644123003 Cr-Commit-Position: refs/heads/master@{#445991} [modify] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.h [modify] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [add] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/BUILD.gn [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/OWNERS [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm [add] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item_unittest.mm [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [add] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_expandable_item.h [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_expandable_item.mm [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_expandable_item_unittest.mm [add] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_internal_cell.h [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_internal_cell.mm [add] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_item.h [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_item.mm [add] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_item_unittest.mm [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_item.h [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_item.mm [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_item_actions.h [add] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_item_unittest.mm [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_stack_item.h [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_stack_item.mm [add] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_stack_item_actions.h [add] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_stack_item_unittest.mm [add] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [rename] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [add] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/browser/ui/content_suggestions/expandable_item.h [delete] https://crrev.com/0e2e641ac55f155f73ed276b07be5e3f417ae009/ios/chrome/browser/ui/suggestions/BUILD.gn [delete] https://crrev.com/0e2e641ac55f155f73ed276b07be5e3f417ae009/ios/chrome/browser/ui/suggestions/expandable_item.h [delete] https://crrev.com/0e2e641ac55f155f73ed276b07be5e3f417ae009/ios/chrome/browser/ui/suggestions/suggestions_article_item_unittest.mm [delete] https://crrev.com/0e2e641ac55f155f73ed276b07be5e3f417ae009/ios/chrome/browser/ui/suggestions/suggestions_commands.h [delete] https://crrev.com/0e2e641ac55f155f73ed276b07be5e3f417ae009/ios/chrome/browser/ui/suggestions/suggestions_favicon_internal_cell.h [delete] https://crrev.com/0e2e641ac55f155f73ed276b07be5e3f417ae009/ios/chrome/browser/ui/suggestions/suggestions_favicon_item.h [delete] https://crrev.com/0e2e641ac55f155f73ed276b07be5e3f417ae009/ios/chrome/browser/ui/suggestions/suggestions_favicon_item_unittest.mm [delete] https://crrev.com/0e2e641ac55f155f73ed276b07be5e3f417ae009/ios/chrome/browser/ui/suggestions/suggestions_item_unittest.mm [delete] https://crrev.com/0e2e641ac55f155f73ed276b07be5e3f417ae009/ios/chrome/browser/ui/suggestions/suggestions_stack_item_actions.h [delete] https://crrev.com/0e2e641ac55f155f73ed276b07be5e3f417ae009/ios/chrome/browser/ui/suggestions/suggestions_stack_item_unittest.mm [delete] https://crrev.com/0e2e641ac55f155f73ed276b07be5e3f417ae009/ios/chrome/browser/ui/suggestions/suggestions_view_controller.h [modify] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/chrome/test/BUILD.gn [modify] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/showcase/core/showcase_model.mm [modify] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/showcase/suggestions/BUILD.gn [modify] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/showcase/suggestions/sc_suggestions_coordinator.mm [modify] https://crrev.com/9756a18af5acb7fcc5f674b7908d9daeaf3357ba/ios/showcase/suggestions/sc_suggestions_egtest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f9928016a709f3de591e1045fcbbc89ae83d8ce commit 8f9928016a709f3de591e1045fcbbc89ae83d8ce Author: gambard <gambard@chromium.org> Date: Wed Jan 25 12:12:20 2017 Add prefs for ContentSuggestions on iOS This CL registers the prefs needed to use ContentSuggestionsService on iOS. BUG= 679369 Review-Url: https://codereview.chromium.org/2650153002 Cr-Commit-Position: refs/heads/master@{#446002} [modify] https://crrev.com/8f9928016a709f3de591e1045fcbbc89ae83d8ce/ios/chrome/browser/prefs/browser_prefs.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157 commit 0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157 Author: gambard <gambard@chromium.org> Date: Wed Feb 01 14:53:14 2017 Add ContentSuggestionsMediator This CL adds a Mediator level in ContentSuggestions. The mediator classes are used to create a interface between the data source in C++ and the UI in Objective-C. This CL only creates the classes to see the interactions from an architectural point. Most of the methods are no-op for now. BUG= 679369 Review-Url: https://codereview.chromium.org/2638413006 Cr-Commit-Position: refs/heads/master@{#447511} [modify] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.h [modify] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [add] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h [add] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [add] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/content_suggestions/content_suggestions_service_bridge_observer.h [add] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/content_suggestions/content_suggestions_service_bridge_observer.mm [modify] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/suggestions/image_fetcher_impl.mm [modify] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/ui/content_suggestions/BUILD.gn [add] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/ui/content_suggestions/content_suggestion.h [add] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/ui/content_suggestions/content_suggestion.mm [modify] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h [modify] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [add] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h [add] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h [modify] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [modify] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/0ac7f3e7f45b25cf8b3283a7df27bf68b3a72157/ios/showcase/suggestions/sc_suggestions_coordinator.mm
Comment 1 by bugdroid1@chromium.org
, Jan 11 2017