Clear browsing data dialog doesn't clear all filesystems |
|||||||
Issue descriptionThe clear browsing data dialog only clears filesystems associated with a quota manager type in FileSystemQuotaClient::DeleteOriginData. This doesn't remove all filesystem data, e.g. data from plugins is left behind. The chrome://settings/cookies dialog uses FileSystemContext::DeleteDataForOriginOnFileTaskRunner in addition to the quota manager, which deletes all filesystems. Clear browsing data should either use this as well or the quota manager should remove all filesystems. Steps for reproduction: - visit a site which uses a plugin filesystem (e.g. yahoo.com) - remove cookies and site data in CBD dialog. - check chrome://settings/cookies and notice that yahoo still has filesystem data.
,
Jan 9 2017
I don't have direct knowledge. I don't know if this is intentional (to preserve plugin data) or an oversight.
,
Jan 9 2017
,
Jan 10 2017
PluginPrivate filesystem was associated with chrome://settings/cookies dialog by following patches: https://codereview.chromium.org/1979733002/ https://codereview.chromium.org/2359393002/ jrummel@ (author of the patches) may know if this is intentional.
,
Jan 10 2017
My changes allowed the PluginPrivate filesystem to be cleared (in bulk using CBD or individually from the cookies dialog). Files found show up as "Media Licenses". AFAICT, the PluginPrivate filesystem is only used by Widevine. (Widevine is a hybrid component/plugin, and some day it will no longer be a plugin.) I created a new profile, went to yahoo.com, and it doesn't appear to create a PluginPrivate filesystem (profile directory "File System/Plugins/" doesn't exist). In the cookies dialog I see 2 cookies, "Local Storage", and "File System" for www.yahoo.com. I cleared "Cookies and other site and plugin data", and afterwards the "File System" object was the only entry for yahoo.com. In fact, selecting all choices in CBD never removes the "File System" object. (www.google.com had "Database Storage", "Service Workers", and "Cache Storage" that went away when "Hosted app data" was cleared.) So I think this bug is that "File System" objects are never removed by CBD. It's not clear to me how this object was created by a plugin.
,
Jan 11 2017
Oh sorry, you're right. It looks like I identified the wrong problem. I still don't understand, why the "File system" entries remain. CBD calls FileSystemQuotaClient::DeleteOriginData for FileSystemTypeTemporary, syncable and persistent.
,
Jan 24 2017
,
Feb 15 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 20 2018
,
Jul 2
I will close this issue as I can't reproduce it anymore (Chrome 69, visit a number of sites, delete cookies for all time, check chrome://settings/siteData) |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by msramek@chromium.org
, Jan 9 2017Components: Privacy