New issue
Advanced search Search tips

Issue 679328 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
jochen@chromium.org
yhirano@chromium.org
japhet@chromium.org
hirosh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ContentSettingsObserver::allowImage is called often per image load

Project Member Reported by csharrison@chromium.org, Jan 9 2017 
For images loaded from Memory Cache, we call this
1. determineRevalidationPolicy
2. resourceNeedsLoad

We also call it
 - When appending bytes to an image document
 - When following a redirect to an image document

It might make sense to cache this setting on the ImageResource. [1] Was written to make this path faster, but it will still be slow for users with non-empty content settings.

[1] https://codereview.chromium.org/2617803002/

Comment 1 by yhirano@chromium.org, Feb 15 2017

Cc: hirosh...@chromium.org yhirano@chromium.org
ContentSettingsObserver is specific to Frame (at least it's accessed via FetchContext) and I don't think it's a good idea to store frame-specific data in [Image]Resource.

Comment 2 by kouhei@chromium.org, Apr 11 2017

Status: Available (was: Untriaged)
Triager marking this out of Untriaged

I wonder if we can kill allowImage itself.

Comment 3 by jochen@chromium.org, Apr 11 2017 

how else would you implement image blocking?
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by csharrison@chromium.org, Apr 11 2018

Status: Available (was: Untriaged)
Back to available.
►

Sign in to add a comment