Issue metadata
Sign in to add a comment
|
Regression: Slider for font size misplaced after changing language to French.
Reported by
lpa...@etouch.net,
Jan 9 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 57.0.2976.0 (Official Build) 062d7b445d6d0ebf509fd923ef027a0a3c6818b1-refs/heads/master@{#442165} (64-bit) OS: Windows(7,8,8.1,10) 1. Launch chrome > goto chrome://md-settings > Change lagunage to French and Relaunch Browser 2. Go to Appearances > Customize Font > Change font size to Maximum for "Minimum Font Size" option and observe Actual Result: Slider for font size is slightly misplaced. Expected Result: Slider should not be misplaced This is regression issue broken in 'M 57' and below is bisect info: Manual bisect info: Good Build No: 57.0.2963.0 Bad Build No: 57..2965.0 Note: This issue is not seen on MAC and LINUX OS.
,
Jan 10 2017
Narrow bisect:: Good ::57.0.2963.0 -- (build revision 440688 ) Bad ::57.0.2965.0 -- (build revision 440816 ) Change Log:: https://chromium.googlesource.com/chromium/src/+log/59ec2c1b938fc633a64079b176283b800d96f689..26b1599ba3f24f4124d8d78227fb815dc1c2e696 Possible suspect:: https://chromium.googlesource.com/chromium/src/+/26b1599ba3f24f4124d8d78227fb815dc1c2e696 Review-Url: https://codereview.chromium.org/2587913007 stevenjb@ Could you please look into this issue if it is related to your change,else please route this to an appropriate dev person. Thanks,
,
Jan 10 2017
tbuckley@ / bettes@ - Question: Should the slider label size change with the default font size? i.e. should they be a fixed size (currently 12px) or a percentage of the default font size (i.e. 92.3%)? (We can't help that they change with the minimum font size).
,
Jan 10 2017
,
Jan 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c9cbe19a0fcbf5386caec36010d201ec3430713 commit 2c9cbe19a0fcbf5386caec36010d201ec3430713 Author: stevenjb <stevenjb@chromium.org> Date: Thu Jan 12 00:47:41 2017 WebUI: cr-slider: Fix layout with large fonts paper-slider uses a fixed size of 200px. This does not work well with cr-slider when the size of the labels increases. Instead, set the minimum width of cr-slider to be 200px, and the width of the embedded paper-slider to 100%. BUG= 679319 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2628633002 Cr-Commit-Position: refs/heads/master@{#443091} [modify] https://crrev.com/2c9cbe19a0fcbf5386caec36010d201ec3430713/ui/webui/resources/cr_elements/cr_slider/cr_slider.html
,
Jan 12 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Jan 9 2017