New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit 27 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Feature



Sign in to add a comment
link

Issue 679313: Request File Transfer during Chrome remote desktop session

Reported by doug.bag...@gmail.com, Jan 9 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36

Steps to reproduce the problem:
1. N/A
2. 
3. 

What is the expected behavior?
N/A

What went wrong?
N/A

Did this work before? N/A 

Chrome version: 55.0.2883.87  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 24.0 r0

It would be REALLY useful to be able to do a file transfer to the destination system I'm Chromoting into. I put this as a suggestion under chromoting instead of separate because it seems you could easily piggy back the communications channel already being used for chromoting.

thanks for listening!
 

Comment 1 by ajha@chromium.org, Jan 10 2017

Components: Services>Chromoting
Labels: Needs-Triage-M55

Comment 2 by kelv...@chromium.org, Jan 10 2017

Owner: joedow@chromium.org

Comment 3 by joedow@chromium.org, Jan 10 2017

Status: Assigned (was: Unconfirmed)
Great suggestion, thanks!

Comment 4 by joedow@chromium.org, Jan 20 2017

Labels: -Needs-Triage-M55

Comment 5 by joedow@chromium.org, Oct 2

Owner: rkjnsn@chromium.org

Comment 6 by bugdroid1@chromium.org, Nov 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebf3f1381df9da377dd07eb3ce91dacfb29e87a1

commit ebf3f1381df9da377dd07eb3ce91dacfb29e87a1
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Fri Nov 02 20:10:20 2018

Update file transfer proto for more flexibility.

This does not add any new functionality, but sets the stage for things
like requesting the host to show a file picker.

Bug: 679313
Change-Id: Id0a25d038f274584dfd6661df50658437ad29258
Reviewed-on: https://chromium-review.googlesource.com/c/1265028
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605033}
[modify] https://crrev.com/ebf3f1381df9da377dd07eb3ce91dacfb29e87a1/remoting/host/file_proxy_wrapper.h
[modify] https://crrev.com/ebf3f1381df9da377dd07eb3ce91dacfb29e87a1/remoting/host/file_proxy_wrapper_linux.cc
[modify] https://crrev.com/ebf3f1381df9da377dd07eb3ce91dacfb29e87a1/remoting/host/file_proxy_wrapper_linux_unittest.cc
[modify] https://crrev.com/ebf3f1381df9da377dd07eb3ce91dacfb29e87a1/remoting/host/file_transfer_message_handler.cc
[modify] https://crrev.com/ebf3f1381df9da377dd07eb3ce91dacfb29e87a1/remoting/host/file_transfer_message_handler.h
[modify] https://crrev.com/ebf3f1381df9da377dd07eb3ce91dacfb29e87a1/remoting/host/file_transfer_message_handler_unittest.cc
[modify] https://crrev.com/ebf3f1381df9da377dd07eb3ce91dacfb29e87a1/remoting/proto/file_transfer.proto
[modify] https://crrev.com/ebf3f1381df9da377dd07eb3ce91dacfb29e87a1/remoting/protocol/BUILD.gn
[add] https://crrev.com/ebf3f1381df9da377dd07eb3ce91dacfb29e87a1/remoting/protocol/file_transfer_helpers.cc
[add] https://crrev.com/ebf3f1381df9da377dd07eb3ce91dacfb29e87a1/remoting/protocol/file_transfer_helpers.h

Comment 7 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ef4fe1c0c57e5b3fc448708a3f651e11ca7b1d0

commit 5ef4fe1c0c57e5b3fc448708a3f651e11ca7b1d0
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Thu Nov 29 21:42:30 2018

Create new FileOperations interface

This creates a basic FileOperations interface for use with file
transfers that should be relatively straightforward to proxy over IPC.

It also creates a ThreadedFileOperations implementation of the
FileOperations interface using FileProxy, which will eventually replace
FileProxyWrapper. This implementation should be platform agnostic. A
future CL will add an IpcFileOperations implementation for Windows, which
will proxy operations from the network process to a ThreadedFileOperation
instance in the desktop process.

Bug: 679313
Change-Id: Ic7d6ce35f498e469f86f9ed7a8fbcc8bd0cafda9
Reviewed-on: https://chromium-review.googlesource.com/c/1325213
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612377}
[modify] https://crrev.com/5ef4fe1c0c57e5b3fc448708a3f651e11ca7b1d0/remoting/host/BUILD.gn
[add] https://crrev.com/5ef4fe1c0c57e5b3fc448708a3f651e11ca7b1d0/remoting/host/file_transfer/BUILD.gn
[add] https://crrev.com/5ef4fe1c0c57e5b3fc448708a3f651e11ca7b1d0/remoting/host/file_transfer/file_operations.h
[add] https://crrev.com/5ef4fe1c0c57e5b3fc448708a3f651e11ca7b1d0/remoting/host/file_transfer/local_file_operations.cc
[add] https://crrev.com/5ef4fe1c0c57e5b3fc448708a3f651e11ca7b1d0/remoting/host/file_transfer/local_file_operations.h
[add] https://crrev.com/5ef4fe1c0c57e5b3fc448708a3f651e11ca7b1d0/remoting/host/file_transfer/local_file_operations_unittest.cc

Comment 8 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad6a38199aa947ed053a75a19b89172f4a4ee0ba

commit ad6a38199aa947ed053a75a19b89172f4a4ee0ba
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Fri Dec 07 01:04:52 2018

Add BufferedFileWriter class.

FileOperations::Writer only allows one operation to be pending at a
time, while chunks from the network will be delivered to
FileTransferMessageHandler as soon as they arrive. BufferedFileWriter
will sit between the two and maintain a queue of chunks to be written,
passing them to the Writer in sequence.

Bug: 679313
Change-Id: Id10c8d3f34c4811feb373e6cb60f470d2a2a59d5
Reviewed-on: https://chromium-review.googlesource.com/c/1362455
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614519}
[modify] https://crrev.com/ad6a38199aa947ed053a75a19b89172f4a4ee0ba/remoting/host/file_transfer/BUILD.gn
[add] https://crrev.com/ad6a38199aa947ed053a75a19b89172f4a4ee0ba/remoting/host/file_transfer/buffered_file_writer.cc
[add] https://crrev.com/ad6a38199aa947ed053a75a19b89172f4a4ee0ba/remoting/host/file_transfer/buffered_file_writer.h
[add] https://crrev.com/ad6a38199aa947ed053a75a19b89172f4a4ee0ba/remoting/host/file_transfer/buffered_file_writer_unittest.cc
[add] https://crrev.com/ad6a38199aa947ed053a75a19b89172f4a4ee0ba/remoting/host/file_transfer/fake_file_operations.cc
[add] https://crrev.com/ad6a38199aa947ed053a75a19b89172f4a4ee0ba/remoting/host/file_transfer/fake_file_operations.h

Comment 9 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d500ddae3b6f9997854f9234c4848ed34949884

commit 5d500ddae3b6f9997854f9234c4848ed34949884
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Mon Dec 10 23:27:53 2018

Migrate to FileOperations and remove FileProxyWrapper

This updates FileTransferMessageHandler to use the new FileOperations
interface. Windows is left unimplemented for now, as thas will require
the forthcoming IpcFileOperations implementation.

Bug: 679313
Change-Id: Ia6c31ed4ae5fbc4c2fda4d93cdecbdf11573d3fa
Reviewed-on: https://chromium-review.googlesource.com/c/1357385
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615311}
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/BUILD.gn
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/basic_desktop_environment.cc
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/basic_desktop_environment.h
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/client_session.cc
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/desktop_environment.h
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/fake_desktop_environment.cc
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/fake_desktop_environment.h
[delete] https://crrev.com/05d8b86a3c01a0998a914009263a74d3a093c533/remoting/host/file_proxy_wrapper.cc
[delete] https://crrev.com/05d8b86a3c01a0998a914009263a74d3a093c533/remoting/host/file_proxy_wrapper.h
[delete] https://crrev.com/05d8b86a3c01a0998a914009263a74d3a093c533/remoting/host/file_proxy_wrapper_linux.cc
[delete] https://crrev.com/05d8b86a3c01a0998a914009263a74d3a093c533/remoting/host/file_proxy_wrapper_linux_unittest.cc
[delete] https://crrev.com/05d8b86a3c01a0998a914009263a74d3a093c533/remoting/host/file_proxy_wrapper_mac.cc
[delete] https://crrev.com/05d8b86a3c01a0998a914009263a74d3a093c533/remoting/host/file_proxy_wrapper_win.cc
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/file_transfer/BUILD.gn
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/file_transfer/buffered_file_writer.h
[add] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/file_transfer/file_transfer_message_handler.cc
[add] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/file_transfer/file_transfer_message_handler.h
[add] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/file_transfer/file_transfer_message_handler_unittest.cc
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/file_transfer/local_file_operations.cc
[delete] https://crrev.com/05d8b86a3c01a0998a914009263a74d3a093c533/remoting/host/file_transfer_message_handler.cc
[delete] https://crrev.com/05d8b86a3c01a0998a914009263a74d3a093c533/remoting/host/file_transfer_message_handler.h
[delete] https://crrev.com/05d8b86a3c01a0998a914009263a74d3a093c533/remoting/host/file_transfer_message_handler_unittest.cc
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/host_mock_objects.cc
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/host_mock_objects.h
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/ipc_desktop_environment.cc
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/host/ipc_desktop_environment.h
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/protocol/file_transfer_helpers.cc
[modify] https://crrev.com/5d500ddae3b6f9997854f9234c4848ed34949884/remoting/protocol/file_transfer_helpers.h

Comment 10 by bugdroid1@chromium.org, Jan 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f1acc1bc79381110501dce1ef1424e261d8c4c9

commit 8f1acc1bc79381110501dce1ef1424e261d8c4c9
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Mon Jan 14 20:18:31 2019

Implement IpcFileOperations

Now that FileTransferMessageHandler has been migrated to the new
FileOperations interface, the next step is to enable proxying the
FileOperations interface over IPC, which is required for Windows support
due to the multi-process architecture we use there.

Bug: 679313
Change-Id: Ib6ed3c90abd8ddc4d84b23b78e3877dfb0048dd9
Reviewed-on: https://chromium-review.googlesource.com/c/1371220
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622575}
[modify] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/chromoting_messages.h
[modify] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/chromoting_param_traits.cc
[modify] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/chromoting_param_traits.h
[modify] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/desktop_process_main.cc
[modify] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/desktop_session_agent.cc
[modify] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/desktop_session_agent.h
[modify] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/desktop_session_proxy.cc
[modify] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/desktop_session_proxy.h
[modify] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/file_transfer/BUILD.gn
[modify] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/file_transfer/file_operations.h
[add] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/file_transfer/ipc_file_operations.cc
[add] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/file_transfer/ipc_file_operations.h
[add] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/file_transfer/session_file_operations_handler.cc
[add] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/file_transfer/session_file_operations_handler.h
[modify] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/ipc_desktop_environment.cc
[modify] https://crrev.com/8f1acc1bc79381110501dce1ef1424e261d8c4c9/remoting/host/ipc_desktop_environment.h

Comment 11 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e291b999151d98454e913bdbecdd27319ad7a4ed

commit e291b999151d98454e913bdbecdd27319ad7a4ed
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Thu Jan 17 18:59:21 2019

Add Result<Success, Error> type.

Result<Success, Error> is a tagged union that represents the success or
failure of an operation, along with either the success value or error
details.

Bug: 679313
Change-Id: Ic815cf1af0ad7f283460494db241b03957546f6b
Reviewed-on: https://chromium-review.googlesource.com/c/1393668
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623778}
[modify] https://crrev.com/e291b999151d98454e913bdbecdd27319ad7a4ed/remoting/base/BUILD.gn
[add] https://crrev.com/e291b999151d98454e913bdbecdd27319ad7a4ed/remoting/base/result.h
[add] https://crrev.com/e291b999151d98454e913bdbecdd27319ad7a4ed/remoting/base/result_unittest.cc

Comment 12 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/042b439b5687b757fb38dbf5eda8858d996f27e6

commit 042b439b5687b757fb38dbf5eda8858d996f27e6
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Thu Jan 17 20:32:31 2019

Use the new Result type in file-transfer code.

Bug: 679313
Change-Id: Iedb6d88e54849fd7f68d59f4261be9b78228a837
Reviewed-on: https://chromium-review.googlesource.com/c/1401280
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623821}
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/BUILD.gn
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/chromoting_messages.cc
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/chromoting_messages.h
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/chromoting_param_traits.cc
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/chromoting_param_traits.h
[add] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/chromoting_param_traits_impl.h
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/desktop_session_agent.cc
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/desktop_session_agent.h
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/file_transfer/buffered_file_writer.cc
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/file_transfer/buffered_file_writer.h
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/file_transfer/fake_file_operations.cc
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/file_transfer/file_operations.h
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/file_transfer/file_transfer_message_handler.cc
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/file_transfer/file_transfer_message_handler.h
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/file_transfer/ipc_file_operations.cc
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/file_transfer/ipc_file_operations.h
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/file_transfer/local_file_operations.cc
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/file_transfer/local_file_operations_unittest.cc
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/file_transfer/session_file_operations_handler.cc
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/host/file_transfer/session_file_operations_handler.h
[modify] https://crrev.com/042b439b5687b757fb38dbf5eda8858d996f27e6/remoting/protocol/file_transfer_helpers.h

Comment 13 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2e46515f608b1318ce73acb0087ac40ff820432

commit a2e46515f608b1318ce73acb0087ac40ff820432
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Thu Jan 17 21:13:01 2019

Don't save file transfers in elevated contexts.

On Windows, impersonate the logged-in user (if any) before writing
the file, aborting if impersonation fails, such as if at the log-in
screen where there's no logged-in user.

On MacOS, abort the transfer if running as root, which signifies that
the host is running on the log-in screen.

Note that this will not prevent uploads on the lock screen, as the OS
still considers the user to be logged in, in that case.

Bug: 679313
Change-Id: I8031473547c180e377ad858221de1ad2711813f8
Reviewed-on: https://chromium-review.googlesource.com/c/1398382
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623844}
[modify] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/build/config/linux/gtk/BUILD.gn
[modify] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/BUILD.gn
[modify] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/chromeos/BUILD.gn
[modify] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/file_transfer/BUILD.gn
[add] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/file_transfer/ensure_user.h
[add] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/file_transfer/ensure_user_mac.cc
[add] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/file_transfer/ensure_user_no_op.cc
[add] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/file_transfer/ensure_user_win.cc
[add] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/file_transfer/get_desktop_directory.cc
[add] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/file_transfer/get_desktop_directory.h
[add] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/file_transfer/get_desktop_directory_win.cc
[modify] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/file_transfer/local_file_operations.cc
[modify] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/it2me/BUILD.gn
[modify] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/linux/BUILD.gn
[modify] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/host/setup/BUILD.gn
[modify] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/proto/file_transfer.proto
[modify] https://crrev.com/a2e46515f608b1318ce73acb0087ac40ff820432/remoting/test/BUILD.gn

Comment 14 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/507521d5cc46ffd8e02ba54133fc9c57db8070d1

commit 507521d5cc46ffd8e02ba54133fc9c57db8070d1
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Fri Jan 18 01:40:08 2019

Enable file upload by default.

Now that file upload has a cross-platform implementation, it should be
safe to enable for testing and eventual rollout to the client. We
decided we didn't need a Chrome policy for now, so enable
unconditionally.

Bug: 679313
Change-Id: I7abd23561d7c485191cfade854b0cfcc035e25be
Reviewed-on: https://chromium-review.googlesource.com/c/1419097
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623947}
[modify] https://crrev.com/507521d5cc46ffd8e02ba54133fc9c57db8070d1/remoting/host/remoting_me2me_host.cc

Comment 15 by palmer@chromium.org, Jan 18

This seems like a fairly major feature, worthy of the feature launch review process: go/ChromeLaunchProcess (Google-internal link, sorry). Also, doesn't it affect more platforms than just Windows?

Comment 16 by rkjnsn@chromium.org, Jan 23

Labels: OS-Linux OS-Mac

Comment 17 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b22c36eaec28198ae3ff8d5f9116f75004fbf3b4

commit b22c36eaec28198ae3ff8d5f9116f75004fbf3b4
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Thu Jan 24 17:23:42 2019

Revert "Enable file upload by default."

This reverts commit 507521d5cc46ffd8e02ba54133fc9c57db8070d1.

Reason for revert: We wanted this for testing prior to release, but we don't want it in the release branch until we've gone through security review.

Original change's description:
> Enable file upload by default.
> 
> Now that file upload has a cross-platform implementation, it should be
> safe to enable for testing and eventual rollout to the client. We
> decided we didn't need a Chrome policy for now, so enable
> unconditionally.
> 
> Bug: 679313
> Change-Id: I7abd23561d7c485191cfade854b0cfcc035e25be
> Reviewed-on: https://chromium-review.googlesource.com/c/1419097
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623947}

TBR=jamiewalch@chromium.org,joedow@chromium.org,rkjnsn@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 679313
Change-Id: I8479766fbdbfbca9a10c179c49cd745fe13904e2
Reviewed-on: https://chromium-review.googlesource.com/c/1434517
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625693}

Comment 18 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dccb06a408bb21b0b1a61e7eae715959e6f4f14b

commit dccb06a408bb21b0b1a61e7eae715959e6f4f14b
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Fri Jan 25 01:19:27 2019

Add IPC messages for file reading.

Bug: 679313
Change-Id: Ic63123612706b5a20612716100406b6bb0a16ba7
Reviewed-on: https://chromium-review.googlesource.com/c/1419013
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625926}

Comment 19 by bugdroid, Jan 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/253ee7c5b71828f5a0c3856ba30aa0a5679a5c7a

commit 253ee7c5b71828f5a0c3856ba30aa0a5679a5c7a
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Sat Jan 26 01:18:40 2019

Remove cancel message in favor of CANCELED error type.

Most code doesn't care to distinguish between an error and cancelation,
as both abort the transfer. The few places that do care (e.g., the code
that decides whether to show an error to the user) can explicitly check
the type. This also allows cancellation to be easily propagated through
the error path from the source, instead of requiring a secondary
cancellation path.

Bug: 679313
Change-Id: I3c90ff55e7a58043535244a9d92cfc9e6814a4e6
Reviewed-on: https://chromium-review.googlesource.com/c/1437657
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626294}

Comment 20 by bugdroid, Jan 30

Project Member

Comment 21 by bugdroid, Jan 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e75b07acaccd0a19903b09bf8de388107c3fb18

commit 0e75b07acaccd0a19903b09bf8de388107c3fb18
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Wed Jan 30 01:59:25 2019

Fallback to English in remoting_localize.py

Currently, remoting_localize.py will fail with an exception if the
requested string has not yet been translated to the requested language.
This makes it difficult to introduce new strings to files localized
using the script (such as core.rc.jinja2), as the build will fail until
all translations have landed. To make life easier, this change makes
remoting_localize.py fall back to English if the appropriate translation
is not available, similarly to how localization is handled elsewhere in
Chromoting.

Bug: 679313
Change-Id: I3e02104ba9b84b838dd152c7d7fe8e236addc109
Reviewed-on: https://chromium-review.googlesource.com/c/1444751
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627274}
[modify] https://crrev.com/0e75b07acaccd0a19903b09bf8de388107c3fb18/remoting/tools/build/remoting_localize.py

Comment 22 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c87e054e0e78867b6fc9c538053d937ac32c6299

commit c87e054e0e78867b6fc9c538053d937ac32c6299
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Wed Feb 06 00:36:06 2019

Implement Windows file dialog.

On Windows, we need to run the dialog in a separate process run with
user privileges.

Bug: 679313
Change-Id: I54b3a1288f72ec9c11964fac379ef72e0589e8a4
Reviewed-on: https://chromium-review.googlesource.com/c/1434794
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629385}
[modify] https://crrev.com/c87e054e0e78867b6fc9c538053d937ac32c6299/remoting/base/result.h
[modify] https://crrev.com/c87e054e0e78867b6fc9c538053d937ac32c6299/remoting/host/file_transfer/BUILD.gn
[add] https://crrev.com/c87e054e0e78867b6fc9c538053d937ac32c6299/remoting/host/file_transfer/file_chooser_common_win.h
[add] https://crrev.com/c87e054e0e78867b6fc9c538053d937ac32c6299/remoting/host/file_transfer/file_chooser_main_win.cc
[add] https://crrev.com/c87e054e0e78867b6fc9c538053d937ac32c6299/remoting/host/file_transfer/file_chooser_win.cc
[modify] https://crrev.com/c87e054e0e78867b6fc9c538053d937ac32c6299/remoting/host/host_main.cc
[modify] https://crrev.com/c87e054e0e78867b6fc9c538053d937ac32c6299/remoting/host/switches.cc
[modify] https://crrev.com/c87e054e0e78867b6fc9c538053d937ac32c6299/remoting/host/switches.h
[modify] https://crrev.com/c87e054e0e78867b6fc9c538053d937ac32c6299/remoting/host/win/core.rc.jinja2
[modify] https://crrev.com/c87e054e0e78867b6fc9c538053d937ac32c6299/remoting/host/win/core_resource.h

Comment 23 by bugdroid, Feb 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec161d6b994f7d8ffc9ec208fff48fa169e3a543

commit ec161d6b994f7d8ffc9ec208fff48fa169e3a543
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Thu Feb 07 01:05:14 2019

Add Mac file chooser dialog.

Bug: 679313
Change-Id: Iae29d398c31e8791420ab27ce6cf08d46db79574
Reviewed-on: https://chromium-review.googlesource.com/c/1447311
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629819}
[modify] https://crrev.com/ec161d6b994f7d8ffc9ec208fff48fa169e3a543/remoting/host/file_transfer/BUILD.gn
[add] https://crrev.com/ec161d6b994f7d8ffc9ec208fff48fa169e3a543/remoting/host/file_transfer/file_chooser_mac.mm

Comment 24 by bugdroid, Feb 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21ee08d71d3bf4ad1baefa92390a99baa4e5cded

commit 21ee08d71d3bf4ad1baefa92390a99baa4e5cded
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Fri Feb 08 21:46:20 2019

Apply Mac chooser takeaways to Linux chooser.

The code review for the Mac chooser led to some changes that are also
applicable to the Linux chooser.

Bug: 679313
Change-Id: I301f9c08aa6afcbf356023b9c0eaea39e171b435
Reviewed-on: https://chromium-review.googlesource.com/c/1457480
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630478}
[modify] https://crrev.com/21ee08d71d3bf4ad1baefa92390a99baa4e5cded/remoting/host/file_transfer/file_chooser_linux.cc

Sign in to add a comment