New issue
Advanced search Search tips

Issue 679302 link

Starred by 1 user
Status: Fixed
Owner:
tommi@chromium.org
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Android audio layer doesn't report audio source initialized event

Project Member Reported by tommi@chromium.org, Jan 9 2017 
The audio stack implementation for Android doesn't report an event (see OnAudioSourceStarted in user_media_client_impl.cc) for when the audio source has been started.  This needs to be fixed to be in line with how we do things on other platforms.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9047236448cceb86f314cd9ea9d0056f51bccb63

commit 9047236448cceb86f314cd9ea9d0056f51bccb63
Author: henrika <henrika@chromium.org>
Date: Wed Jan 25 22:57:25 2017

Add missing permission for webview tests and remove OS specific #ifdef in getUserMedia code.

The reason for the failures on android turned out to be because of the test configuration and not the getUserMedia code. The failure we were hitting was in AndroidAudioManager.java where it turned out that the MODIFY_AUDIO_SETTINGS was missing from the manifest.

See: https://cs.chromium.org/chromium/src/media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java?rcl=0&l=385

BUG= 679302 

Review-Url: https://codereview.chromium.org/2648173005
Cr-Commit-Position: refs/heads/master@{#446150}

[modify] https://crrev.com/9047236448cceb86f314cd9ea9d0056f51bccb63/android_webview/test/shell/AndroidManifest.xml
[modify] https://crrev.com/9047236448cceb86f314cd9ea9d0056f51bccb63/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/9047236448cceb86f314cd9ea9d0056f51bccb63/content/renderer/media/user_media_client_impl.cc

Comment 2 by tommi@chromium.org, Jan 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment