New issue
Advanced search Search tips

Issue 679288 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

2 vr webkit_tests failure (crashes)

Project Member Reported by vitaliii@chromium.org, Jan 9 2017

Issue description

Build:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/1297

unexpected_failures:
vr/requestAnimationFrame_invalidhandle.html
vr/requestAnimationFrame_unregister.html

Relevant lines:
19:07:45.459 24323 worker/0 vr/requestAnimationFrame_invalidhandle.html leaked
19:07:45.459 24323   [24327:24445:0106/190745.268031:2536501198:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://content/shell/renderer/layout_test/frame_interface_registry
19:07:45.459 24323   [24327:24445:0106/190745.268541:2536501705:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://content/shell/renderer/layout_test/interface_registry
19:07:45.459 24323   [24327:24445:0106/190745.270398:2536503561:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://Mojo Helpers
19:07:45.459 24323   [1:1:0106/190745.276206:2536509461:ERROR:mojo_context_state.cc(194)] Failed to fetch source for module "content/shell/renderer/layout_test/frame_interface_registry"
19:07:45.459 24323   [1:1:0106/190745.276516:2536509727:ERROR:mojo_context_state.cc(194)] Failed to fetch source for module "content/shell/renderer/layout_test/interface_registry"
19:07:45.459 24323   [1:1:0106/190745.276739:2536509939:ERROR:mojo_context_state.cc(194)] Failed to fetch source for module "Mojo Helpers"
19:07:45.468 14119 [29/37] vr/requestAnimationFrame_invalidhandle.html failed unexpectedly (leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,24],"numberOfLiveResources":[0,5],"numberOfLiveSuspendableObjects":[2,3]}))

19:07:46.504 24323 worker/0 vr/requestAnimationFrame_unregister.html leaked
19:07:46.504 24323   Xlib:  extension "RANDR" missing on display ":9".
19:07:46.504 24323   [25327:25512:0106/190746.408983:2537642150:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://content/shell/renderer/layout_test/frame_interface_registry
19:07:46.504 24323   [25327:25512:0106/190746.409106:2537642269:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://content/shell/renderer/layout_test/interface_registry
19:07:46.504 24323   [25327:25512:0106/190746.409698:2537642861:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://Mojo Helpers
19:07:46.504 24323   [1:1:0106/190746.412614:2537645894:ERROR:mojo_context_state.cc(194)] Failed to fetch source for module "content/shell/renderer/layout_test/frame_interface_registry"
19:07:46.504 24323   [1:1:0106/190746.412805:2537646022:ERROR:mojo_context_state.cc(194)] Failed to fetch source for module "content/shell/renderer/layout_test/interface_registry"
19:07:46.504 24323   [1:1:0106/190746.412906:2537646122:ERROR:mojo_context_state.cc(194)] Failed to fetch source for module "Mojo Helpers"
19:07:46.506 14119 [34/37] vr/requestAnimationFrame_unregister.html failed unexpectedly (leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,24],"numberOfLiveResources":[0,5],"numberOfLiveSuspendableObjects":[2,3]}))

I suspect https://codereview.chromium.org/2617183002, where both the tests were touched.
 
There are 3 more CLs touching WebKit
https://codereview.chromium.org/2619023002
https://codereview.chromium.org/2617553002
https://codereview.chromium.org/2614883002
in the batch, so I am disabling the tests.
(the previous comment (disabling instead of reverting) is according to Gardening Leak bots guid https://docs.google.com/document/d/11C7zFNKydrorESnE6Nbq98QNmKRMrhSwVMGxkx4fiZM/edit#heading=h.26irfde6145p)
Cc: bsheedy@chromium.org
Actually the tests in question were added in https://codereview.chromium.org/2617183002 together with other tests, so there is no point to revert all of them and I am going to disable them.
Actually since this is my first sheriff shift, I asked a more knowledgeable mkwst@, who advised me to revert (even though we revert other tests added in that CL). So I'm reverting. 
Summary: 2 vr webkit_tests failure (crashes) (was: vr webkit_tests failure)
The revert CL is checked on trybots
https://codereview.chromium.org/2616403002/.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/161af0077dffbdd6aa5846677da04c4e3d3d6677

commit 161af0077dffbdd6aa5846677da04c4e3d3d6677
Author: vitaliii <vitaliii@chromium.org>
Date: Mon Jan 09 12:16:11 2017

Revert of Add more WebVR layout tests, adjust test format (patchset #4 id:60001 of https://codereview.chromium.org/2617183002/ )

Reason for revert:
Two of the added tests crash:
vr/requestAnimationFrame_invalidhandle.html
vr/requestAnimationFrame_unregister.html

BUG= 679288 

Original issue's description:
> Add more WebVR layout tests, adjust test format
>
> Adds a handful of new WebVR layout tests using mocking.
>
> Adjusts the vr_test to pass the provided function an async_test handle. This
> was done due to how easy it was for the previous promise_test implementation
> to resolve earlier than expected, causing the test to pass before all code was
> run with no visible difference in the output. The use of the async_test makes
> the tests slightly more verbose, but ensures that we're only ending the test
> when we expect to.
>
> Add a fix for VRDisplay not initializing layer bounds to defaults correctly.
>
> BUG= 675325 , 670490 ,650703
>
> Review-Url: https://codereview.chromium.org/2617183002
> Cr-Commit-Position: refs/heads/master@{#442135}
> Committed: https://chromium.googlesource.com/chromium/src/+/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41

TBR=bajones@chromium.org,dglazkov@chromium.org,bsheedy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 675325 , 670490 ,650703

Review-Url: https://codereview.chromium.org/2616403002
Cr-Commit-Position: refs/heads/master@{#442237}

[delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/exitPresent_reject_notpresenting.html
[delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/exitPresent_resolve.html
[delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/getEyeParameters_match.html
[delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/getLayers_notpresenting.html
[delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/getLayers_presenting.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/getVRDisplays_one_display.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/getVRDisplays_two_display.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/getVRDisplays_zero_display.html
[delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_called.html
[delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_invalidhandle.html
[delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_unregister.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_badleftbounds.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_badrightbounds.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nogesture.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nolayers.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nosource.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_notsupported.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nowebgl.html
[delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nullsource.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_reject_toomanylayers.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_resolve.html
[delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithoutgesture.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_webgl2.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/resources/fake-vr-displays.js
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
[delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/resources/test-constants.js
[delete] https://crrev.com/302263bedf6549ed0225fa3f8e32895faf815a81/third_party/WebKit/LayoutTests/vr/stageParameters_match.html
[modify] https://crrev.com/161af0077dffbdd6aa5846677da04c4e3d3d6677/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Status: Fixed (was: Started)
These tests do not crash anymore.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7f90cae827044cfb2280c8382d993848ef33340

commit b7f90cae827044cfb2280c8382d993848ef33340
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Jan 13 04:14:43 2017

Add more WebVR layout tests and fix small issues they found

Adds several additional WebVR layout tests.

Refactors the WebVR Mojo mocking to more closely emulate the actual
actual implementation.

Fixes several issues in the WebVR source code that were encountered by these
tests.

BUG= 679952 , 679288 

Review-Url: https://codereview.chromium.org/2624263003
Cr-Commit-Position: refs/heads/master@{#443485}

[add] https://crrev.com/b7f90cae827044cfb2280c8382d993848ef33340/third_party/WebKit/LayoutTests/vr/events_vrdisplayactivate.html
[add] https://crrev.com/b7f90cae827044cfb2280c8382d993848ef33340/third_party/WebKit/LayoutTests/vr/events_vrdisplayconnect.html
[add] https://crrev.com/b7f90cae827044cfb2280c8382d993848ef33340/third_party/WebKit/LayoutTests/vr/events_vrdisplaypresentchange.html
[modify] https://crrev.com/b7f90cae827044cfb2280c8382d993848ef33340/third_party/WebKit/LayoutTests/vr/getLayers_presenting.html
[add] https://crrev.com/b7f90cae827044cfb2280c8382d993848ef33340/third_party/WebKit/LayoutTests/vr/getLayers_presenting_nondefaultbounds.html
[add] https://crrev.com/b7f90cae827044cfb2280c8382d993848ef33340/third_party/WebKit/LayoutTests/vr/getLayers_update.html
[add] https://crrev.com/b7f90cae827044cfb2280c8382d993848ef33340/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_then_reject.html
[modify] https://crrev.com/b7f90cae827044cfb2280c8382d993848ef33340/third_party/WebKit/LayoutTests/vr/resources/fake-vr-displays.js
[modify] https://crrev.com/b7f90cae827044cfb2280c8382d993848ef33340/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
[modify] https://crrev.com/b7f90cae827044cfb2280c8382d993848ef33340/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/b7f90cae827044cfb2280c8382d993848ef33340/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Sign in to add a comment