Build is broken: sizes Relevant build logs here: Linux: https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/31040 Mac: https://uberchromegw.corp.google.com/i/chromium/builders/Mac/builds/22402 Relevant lines from the error log: Linux: FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7, better lower Mac: FAILED mac-release/sizes/chrome-si/initializers: actual 2, expected 0, better lower Something similar has happened before ( issue 625728 ). There skia roll at introduced a new static initializer. I suspect https://chromium.googlesource.com/chromium/src/+/8283cad74e0cad4840d1f222052d2244136ffeda since both OS started to fail on this CL.
I am checking whether reverting the mentioned CL helps (https://codereview.chromium.org/2621503003).
It seems that the mentioned CL https://codereview.chromium.org/2610163003 added vector_icons.cc file, but forget to "register" it somewhere. From https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F31040%2F%2B%2Frecipes%2Fsteps%2Fsizes%2F0%2Fstdout # Found 1033 static initializers in 8 files. and in the last successful run https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F31039%2F%2B%2Frecipes%2Fsteps%2Fsizes%2F0%2Fstdout # Found 39 static initializers in 7 files. This seems to explain the error message FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7, better lower
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c2a3a29a5ad22d423151a835bc67582395870c6 commit 0c2a3a29a5ad22d423151a835bc67582395870c6 Author: vitaliii <vitaliii@chromium.org> Date: Mon Jan 09 08:52:07 2017 Revert of Create vector icon resource directory specific to Chrome. (patchset #7 id:140001 of https://codereview.chromium.org/2610163003/ ) Reason for revert: Speculative revert, likely broke: Linux: https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/31040 Mac: https://uberchromegw.corp.google.com/i/chromium/builders/Mac/builds/22402 BUG= 679272 Original issue's description: > Create vector icon resource directory specific to Chrome. > > BUG= 626786 > > Review-Url: https://codereview.chromium.org/2610163003 > Cr-Commit-Position: refs/heads/master@{#442183} > Committed: https://chromium.googlesource.com/chromium/src/+/8283cad74e0cad4840d1f222052d2244136ffeda TBR=oshima@chromium.org,tdanderson@chromium.org,sky@chromium.org,avi@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 626786 Review-Url: https://codereview.chromium.org/2614333002 Cr-Commit-Position: refs/heads/master@{#442212} [delete] https://crrev.com/07c4f6235908cf73368e37301404a911401fb86e/chrome/app/vector_icons/BUILD.gn [delete] https://crrev.com/07c4f6235908cf73368e37301404a911401fb86e/chrome/app/vector_icons/vector_icons.cc.template [delete] https://crrev.com/07c4f6235908cf73368e37301404a911401fb86e/chrome/app/vector_icons/vector_icons.h.template [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/recovery/recovery_install_global_error.cc [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.h [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/global_error/global_error.cc [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/views/payments/payment_request_views_util.cc [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/views/toolbar/app_menu_button.cc [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/views/toolbar/reload_button.cc [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/upgrade_detector.cc [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/BUILD.gn [rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/browser_tools.icon [rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/browser_tools_error.icon [rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/browser_tools_update.icon [rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_back.1x.icon [rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_back.icon [rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_forward.1x.icon [rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_forward.icon [rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_home.1x.icon [rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_home.icon [rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_reload.1x.icon [rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_reload.icon [rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_stop.1x.icon [rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_stop.icon [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/views/controls/button/vector_icon_button.cc [modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/views/controls/button/vector_icon_button.h
Comment 1 by vitaliii@chromium.org
, Jan 9 2017