New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 679237 link

Starred by 2 users
Status: Fixed
Owner:
█ victoriaytsu@google.com
Last visit > 30 days ago
Closed: Feb 2018
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , All , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

CSS scale property: scale with one value should affect X and Y

Project Member Reported by cbracefield@google.com, Jan 9 2017 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2970.0 Safari/537.36

Steps to reproduce the problem:
1. Set scale: 2
2. Observe new width and height.

What is the expected behavior?
Only width gets doubled.

What went wrong?
Both width and height have doubled.

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 57.0.2970.0  Channel: dev
OS Version: 
Flash Version: 

https://drafts.csswg.org/css-transforms-2/#individual-transforms

Comment 1 by ericwilligers@chromium.org, Jan 9 2017

Labels: OS-All
Owner: ericwilligers@chromium.org
Status: Started (was: Unconfirmed)
cbracefield has uploaded a patch:
https://codereview.chromium.org/2623453002/

Comment 3 by ericwilligers@chromium.org, Jan 10 2017

Status: Fixed (was: Started)

Comment 4 by victoriaytsu@google.com, Feb 8 2018

Labels: OS-Android OS-Chrome OS-Fuchsia OS-Mac OS-Windows
Owner: victoriaytsu@google.com
Status: Assigned (was: Fixed)
CSS WG have changed the spec for the behaviour of scale

https://github.com/w3c/csswg-drafts/issues/2109

Comment 5 by victoriaytsu@google.com, Feb 8 2018

Summary: CSS scale property: scale with one value should affect X and Y (was: CSS scale property: scale with one value should only affect X)

Comment 6 by victoriaytsu@google.com, Feb 9 2018

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f298c5e83c7ade370eb84522f01849643f050057

commit f298c5e83c7ade370eb84522f01849643f050057
Author: Victoria Su <victoriaytsu@google.com>
Date: Fri Feb 09 21:15:11 2018

CSS scale: Modified behaviour to match spec

The spec for CSS scale has been updated to have the y-scale equal to the x-scale when only one number is provided

Spec: https://drafts.csswg.org/css-transforms-2/#propdef-scale

Bug:  679237 
Change-Id: I3b36434e8761efa9e0eb349a495a3ef5631e8d16
Reviewed-on: https://chromium-review.googlesource.com/910129
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535831}
[modify] https://crrev.com/f298c5e83c7ade370eb84522f01849643f050057/third_party/WebKit/LayoutTests/animations/composition/scale-composition.html
[modify] https://crrev.com/f298c5e83c7ade370eb84522f01849643f050057/third_party/WebKit/LayoutTests/animations/interpolation/scale-interpolation.html
[modify] https://crrev.com/f298c5e83c7ade370eb84522f01849643f050057/third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/translate-rotate-scale.js
[modify] https://crrev.com/f298c5e83c7ade370eb84522f01849643f050057/third_party/WebKit/LayoutTests/animations/responsive/interpolation/scale-responsive.html
[modify] https://crrev.com/f298c5e83c7ade370eb84522f01849643f050057/third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/animation/scale-interpolation.html
[modify] https://crrev.com/f298c5e83c7ade370eb84522f01849643f050057/third_party/WebKit/LayoutTests/external/wpt/css/css-transforms/individual-transform/individual-transform-1-ref.html
[modify] https://crrev.com/f298c5e83c7ade370eb84522f01849643f050057/third_party/WebKit/LayoutTests/transforms/scale-expected.html
[modify] https://crrev.com/f298c5e83c7ade370eb84522f01849643f050057/third_party/WebKit/LayoutTests/transforms/scale-parsing.html
[modify] https://crrev.com/f298c5e83c7ade370eb84522f01849643f050057/third_party/WebKit/Source/core/css/properties/longhands/ScaleCustom.cpp
[modify] https://crrev.com/f298c5e83c7ade370eb84522f01849643f050057/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Comment 8 by cnardi@chromium.org, Apr 27 2018 

 Issue 837547  has been merged into this issue.
►

Sign in to add a comment