It's working as intended/implemented. :) Each PaygenTest and PaygenBuild stage is associated with a particular channel that is being generated. The issue is, it's not currently obvious. I plan to write a CL next week that will add the channel to the stage name so we'd have "PaygenBuild - Dev" or "PaygenTest - Canary"

I see.  Yes maybe PaygenBuildDev, PaygenTestCanary etc.  Otherwise I'll just number them: PaygenBuild1, etc.

Do we really need to test multiple paygens in each build?  I guess it never hurts, but I wonder how much it buys vs. time and space requirements.

That was the wrong summary.  It's fine to have many stages, I am just wondering whether the names should be unique.

The names will be, I promised to put up a CL to fix that on Friday, and didn't get it done.

PS: This is not a chance in what we do, only in how it's presented.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/23ec9dffb52d4cbf43ff28fc453f769d09185bb0

commit 23ec9dffb52d4cbf43ff28fc453f769d09185bb0
Author: Don Garrett <dgarrett@google.com>
Date: Tue Jan 10 00:53:47 2017

PaygenStage: Add channel to sub-stage names.

Add the channel to the PaygenBuild and PaygenTest stages so that we
don't see apparently duplicate channels on the waterfall.

Also tweak with unitests a bit, just because.

BUG= chromium:679225 
TEST=Unitests

Change-Id: I0712098f8194aa25dead932cc52a6b8b3662272b
Reviewed-on: https://chromium-review.googlesource.com/425849
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>

[modify] https://crrev.com/23ec9dffb52d4cbf43ff28fc453f769d09185bb0/cbuildbot/stages/release_stages_unittest.py
[modify] https://crrev.com/23ec9dffb52d4cbf43ff28fc453f769d09185bb0/cbuildbot/stages/release_stages.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/23ec9dffb52d4cbf43ff28fc453f769d09185bb0

commit 23ec9dffb52d4cbf43ff28fc453f769d09185bb0
Author: Don Garrett <dgarrett@google.com>
Date: Tue Jan 10 00:53:47 2017

PaygenStage: Add channel to sub-stage names.

Add the channel to the PaygenBuild and PaygenTest stages so that we
don't see apparently duplicate channels on the waterfall.

Also tweak with unitests a bit, just because.

BUG= chromium:679225 
TEST=Unitests

Change-Id: I0712098f8194aa25dead932cc52a6b8b3662272b
Reviewed-on: https://chromium-review.googlesource.com/425849
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>

[modify] https://crrev.com/23ec9dffb52d4cbf43ff28fc453f769d09185bb0/cbuildbot/stages/release_stages_unittest.py
[modify] https://crrev.com/23ec9dffb52d4cbf43ff28fc453f769d09185bb0/cbuildbot/stages/release_stages.py

 Issue 680287  has been merged into this issue.

Thank you, the names look like these now:

PaygenBuildCanary
PaygenTestCanary-channel
PaygenBuildDev
PaygenTestDev-channel

I looked at the review but it wasn't obvious that some of the names were going to have the "-channel" suffix.  Is that worth removing?  It's totally functional this way, just a little confusing (it suggests that there could be other suffixes).

I think it's a bug. I found it in the review and left a comment.

Posted a CL to fix it: https://chromium-review.googlesource.com/c/427958/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/127be91353563d705812a608ec7e344c443eed49

commit 127be91353563d705812a608ec7e344c443eed49
Author: Aseda Aboagye <aaboagye@google.com>
Date: Thu Jan 12 19:01:24 2017

release_stages: Fixup PaygenTest stage naming.

Recently, the Paygen stage was split up into substages: PaygenBuild and
PaygenTest.  In order to make things clearer on the waterfall, the
channel of the payloads being generated was added to the stage name,
however, for the PaygenTest stage, it had an extra suffix of '-channel'.

This commit fixes that.  The stage names should now be PaygenBuildFoo and
PaygenTestFoo.  Additionally, this commit also fixes the unit tests to prevent
polluting the source directory with 'foo-build_uri' files as well as
'archive_build_uri' directory.

BUG= chromium:680357 
BUG= chromium:679225 
BRANCH=None
TEST=python cbuildbot/stages/release_stages_unittest
TEST=python lib/paygen/paygen_build_lib_unittest
TEST=python lib/paygen/paygen_build_lib_unittest --network

Change-Id: I5513321bd056bf99bae10958dc2a67861127e443
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/427958
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/127be91353563d705812a608ec7e344c443eed49/cbuildbot/stages/release_stages_unittest.py
[modify] https://crrev.com/127be91353563d705812a608ec7e344c443eed49/lib/paygen/paygen_build_lib_unittest.py
[modify] https://crrev.com/127be91353563d705812a608ec7e344c443eed49/cbuildbot/stages/release_stages.py

Everything appears to be in good working order now. (At least regarding the Paygen stage names. :) )