ChromeOS forgets shelf position after reboot
Reported by
tri...@gmail.com,
Jan 8 2017
|
|||||||
Issue descriptionChrome Version : 57.0.2970.0 OS Version: 9150.0.0 What steps will reproduce the problem? 1. Set shelf position to right and left of screens (2 monitor setup) 2. Shutdown 3. Startup 4. Login 5. Shelves are both back at bottom of screen. What is the expected result? Shelves should be on left and right What happens instead of that? Both shelf positions lost. UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 9150.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2970.0 Safari/537.36
,
Jan 18 2017
I can confirm repro on my ToT linux-desktop build of cros, I'll investigate. This also seems to reproduce for a single display, so this is pretty bad... After step 5 with multi-display, if you toggle auto-hide (or change one shelf's alignment), the shelves (or other shelf) pops into the expected alignment. Perhaps the preferences are not being loaded at the correct time, but are indeed stored correctly.
,
Jan 18 2017
It might help to find the CL that introduced this regression.
,
Jan 18 2017
This might have changed recently, but in general I don't think QA can bisect Chrome OS chrome revisions. You might not be able to rely on getting a bisect.
,
Jan 19 2017
FWIW, things work OK with M56 beta on samus with a single (internal) display. That is, I can set shelf alignment to left, power-down by holding the power key, login, and shelf is still left.
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/185ea388249bc19676a7f44a12d6fe0881fb0957 commit 185ea388249bc19676a7f44a12d6fe0881fb0957 Author: msw <msw@chromium.org> Date: Thu Jan 19 03:37:29 2017 Load shelf preferences from ChromeLauncherController::AttachProfile. Load prefs on AttachProfile for initialization and user changes. ( the previous ActiveUserChanged call only addressed user changes ) BUG= 679208 TEST=Shelf preferences are respected on login/startup. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2640023005 Cr-Commit-Position: refs/heads/master@{#444625} [modify] https://crrev.com/185ea388249bc19676a7f44a12d6fe0881fb0957/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc [modify] https://crrev.com/185ea388249bc19676a7f44a12d6fe0881fb0957/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
,
Jan 19 2017
,
Jan 20 2017
See also issue 683400 which may be the same root cause.
,
Jan 23 2017
Issue 683400 is a duplicate of Issue 675599 , and I am requesting merge there for a separate fix: https://codereview.chromium.org/2613303003 As James notes in comment #5, and from my own local testing of the latest 56 beta (56.0.2924.67), this defect is not present on M-56, so no merge should be required here.
,
Feb 10 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by warx@chromium.org
, Jan 17 2017