New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679156 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Can't call gl.getUniform for usampler2D and isampler2D uniforms

Project Member Reported by gman@chromium.org, Jan 7 2017

Issue description

Chrome Version: Version 57.0.2975.0 (Official Build) canary (64-bit)
OS: All?

What steps will reproduce the problem?
(1) Make a shader with `uniform isampler2D foo;`
(2) Compile and link the shader
(3) Try to call `gl.getUniform(program, foo)`

See: https://jsfiddle.net/greggman/05ay9gqe/

What is the expected result?

It should return the value of the uniform

What happens instead?

INVALID_VALUE

Note it works in firefoxnightly so I'm guessing it's a cross platform chrome only bug. A little surprised this isn't checked in the conformance tests

This bug makes it so the WebGL-Inspector can not deal with isampler2D, usampler2D, I'm guessing maybe isampler3D and usampler3d etc but I haven't checked which types of uniforms can't be read.

 

Comment 1 by zmo@chromium.org, Jan 9 2017

This sounds pretty bad.  Thanks for reporting it.  I am also surprised there is no dEQP tests covering this ...

Comment 2 by zmo@chromium.org, Jan 9 2017

Cc: kainino@chromium.org
Labels: -Pri-3 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c281383a4a0459271ea2a258c4e1a5262fa30f78

commit c281383a4a0459271ea2a258c4e1a5262fa30f78
Author: zmo <zmo@chromium.org>
Date: Tue Jan 10 00:56:00 2017

Handle ES3 Sampler types in getUniform in WebGL2RenderingContext

BUG= 679156 
TEST=https://github.com/KhronosGroup/WebGL/pull/2248
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2626543002
Cr-Commit-Position: refs/heads/master@{#442429}

[modify] https://crrev.com/c281383a4a0459271ea2a258c4e1a5262fa30f78/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Comment 4 by zmo@chromium.org, Jan 10 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment