checkteamtags.py fails for a deleted OWNERS file |
||||
Issue descriptionIf you have a patch that deletes an OWNERS file, this script prevents the presubmit hooks from running. See https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/336966/steps/presubmit/logs/stdio for example: DEBUG:root:/usr/bin/python /b/build/slave/linux/build/src/tools/checkteamtags/checkteamtags.py --root /b/build/slave/linux/build/src content/common/presentation/OWNERS Traceback (most recent call last): File "/b/build/slave/linux/build/src/tools/checkteamtags/checkteamtags.py", line 117, in <module> sys.exit(main()) File "/b/build/slave/linux/build/src/tools/checkteamtags/checkteamtags.py", line 98, in main errors = filter(None, [check_owners(options.root, f) for f in args]) File "/b/build/slave/linux/build/src/tools/checkteamtags/checkteamtags.py", line 32, in check_owners with open(full_path) as f: IOError: [Errno 2] No such file or directory: '/b/build/slave/linux/build/src/content/common/presentation/OWNERS'
,
Jan 8 2017
,
Jan 9 2017
,
Jan 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5eb8231b9d558affe437070cb338cc7ee47a6ee3 commit 5eb8231b9d558affe437070cb338cc7ee47a6ee3 Author: robertocn <robertocn@chromium.org> Date: Mon Jan 09 20:27:22 2017 Exclude deleted OWNERS files from presubmit tag check. R=stgao@chromium.org,mfoltz@chromium.org,dpranke@chromium.org BUG= 679129 Review-Url: https://codereview.chromium.org/2619763004 Cr-Commit-Position: refs/heads/master@{#442326} [modify] https://crrev.com/5eb8231b9d558affe437070cb338cc7ee47a6ee3/PRESUBMIT.py
,
Jan 9 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mfo...@chromium.org
, Jan 7 2017Owner: robert...@chromium.org