New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679127 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocked on:
issue 696029


Participants' hotlists:
Payments-TechDebt


Sign in to add a comment

[Payment Request] Investigate interactive_ui_tests failures for PaymentRequest

Project Member Reported by ma...@chromium.org, Jan 7 2017

Issue description

Currently the mojo interface registration is ifdef'ed out for Mac.

We should investigate how to turn it on for MacViews
 

Comment 1 by ma...@chromium.org, Jan 7 2017

^^ See https://cs.chromium.org/chromium/src/chrome/browser/chrome_content_browser_client.cc?rcl=0&l=3010 for where the Mojo interface is registered on the browser side.
Cc: shrike@chromium.org
Owner: tmartino@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2869150d31cb0529f16f7d571ef650d1d2bebd99

commit 2869150d31cb0529f16f7d571ef650d1d2bebd99
Author: tmartino <tmartino@chromium.org>
Date: Fri Feb 24 21:34:38 2017

[WebPayments] Enabling unit + browser tests on Mac

BUG=679127

Review-Url: https://codereview.chromium.org/2691343009
Cr-Commit-Position: refs/heads/master@{#452931}

[modify] https://crrev.com/2869150d31cb0529f16f7d571ef650d1d2bebd99/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/2869150d31cb0529f16f7d571ef650d1d2bebd99/chrome/test/BUILD.gn

Status: Fixed (was: Started)

Comment 8 by ma...@chromium.org, Feb 24 2017

Status: Assigned (was: Fixed)
Summary: [Payment Request] Investigate interactive_ui_tests failures for PaymentRequest (was: [Payment Request] Enable Payment Request API for MacViews)
Probably need to leave this bug open since it's referenced in a TODO
Blockedon: 696029
Whoops, just filed crbug/696029 to document what was left to do. Will mark that as a blocker instead.
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment