A lot of old classes rely heavily on setters and getters. It masks side effects and closure has some trouble with them.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7b01ac5e2085ad23f1a01b84b2ce27daced0f70 commit b7b01ac5e2085ad23f1a01b84b2ce27daced0f70 Author: allada <allada@chromium.org> Date: Tue Jan 10 06:59:59 2017 [Devtools] Removed getters/setters for NetworkRequest requestId R=caseq BUG= 679105 Review-Url: https://codereview.chromium.org/2617283003 Cr-Commit-Position: refs/heads/master@{#442521} [modify] https://crrev.com/b7b01ac5e2085ad23f1a01b84b2ce27daced0f70/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-replay.html [modify] https://crrev.com/b7b01ac5e2085ad23f1a01b84b2ce27daced0f70/third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html [modify] https://crrev.com/b7b01ac5e2085ad23f1a01b84b2ce27daced0f70/third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html [modify] https://crrev.com/b7b01ac5e2085ad23f1a01b84b2ce27daced0f70/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js [modify] https://crrev.com/b7b01ac5e2085ad23f1a01b84b2ce27daced0f70/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js [modify] https://crrev.com/b7b01ac5e2085ad23f1a01b84b2ce27daced0f70/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js [modify] https://crrev.com/b7b01ac5e2085ad23f1a01b84b2ce27daced0f70/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js [modify] https://crrev.com/b7b01ac5e2085ad23f1a01b84b2ce27daced0f70/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a062852968b7a329e313ab789bc69856ad8af29 commit 8a062852968b7a329e313ab789bc69856ad8af29 Author: allada <allada@chromium.org> Date: Tue Jan 10 23:58:12 2017 [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter This patch moves NetworkRequest.prototype.url to a proper getter/setter function to be within our styleguide. R=caseq,luoe,einbinder,dgozman BUG= 679105 Review-Url: https://codereview.chromium.org/2626553002 Cr-Commit-Position: refs/heads/master@{#442736} [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/fragment.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network-preflight-options.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/async-xhr-json-mime-type.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/download.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/from-disk-cache-timing.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-cachedresources-with-same-urls.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-content-replacement-xhr.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-cyrillic-xhr.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-disable-cache-cors.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-disable-cache-xhrs.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-document-initiator.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-empty-xhr.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-eventsource.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-fetch-post-payload.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-fetch.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-iframe-load-and-delete.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-image-404.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-imported-resource-content.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator-from-console.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-memory-cached-resource.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-request-revision-content.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-timing.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-async-response-type-blob.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-async.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-data-received-async-response-type-blob.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-post-payload.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-redirect-body.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-redirect-method.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-replay.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-sync.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xsl-content.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/ping-response.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/ping.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-conversion.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters-ipv6.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/resource-parameters.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resource-request-content-while-loading.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-image.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/inspector/curl-command.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/LayoutTests/inspector/reveal-objects.html [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/Tests.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js [modify] https://crrev.com/8a062852968b7a329e313ab789bc69856ad8af29/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/beffc4fe07d6a0ca0964db6fbd895da77c36d455 commit beffc4fe07d6a0ca0964db6fbd895da77c36d455 Author: allada <allada@chromium.org> Date: Tue Jan 17 21:29:29 2017 [Devtools] Bug fix with url as undefined in blocked requests This patch fixes a small bug with blocked requests in network panel shoing the blocked requests in console caused by a recent code change of chaning SDK.NetworkRequest.url from getter to function. R=dgozman,luoe,pfeldman BUG= 679105 Review-Url: https://codereview.chromium.org/2631313003 Cr-Commit-Position: refs/heads/master@{#444151} [modify] https://crrev.com/beffc4fe07d6a0ca0964db6fbd895da77c36d455/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
Comment 1 by bugdroid1@chromium.org
, Jan 10 2017