New issue
Advanced search Search tips

Issue 679090 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

PrerenderBrowserTest.FirstContentfulPaintTimingReuse failing on chromium.linux/Linux Tests (dbg)(1)

Project Member Reported by dewittj@chromium.org, Jan 7 2017

Issue description

browser_side_navigation_browser_tests failing on chromium.linux/Linux Tests (dbg)(1)

Type: build-failure

Builders failed on: 
- Linux Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29

This appears to be a flaky test.

[ RUN      ] PrerenderBrowserTest.FirstContentfulPaintTimingReuse
Xlib:  extension "RANDR" missing on display ":99".
Xlib:  extension "RANDR" missing on display ":99".
[12032:12032:0106/151935.000247:ERROR:variations_util.cc(88)] Missing Worker Pool Configuration: Background
[12032:12032:0106/151935.017969:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected
[12032:12032:0106/151935.018021:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected
[12032:12032:0106/151935.260004:WARNING:password_store_factory.cc(248)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[12032:12051:0106/151936.279851:WARNING:simple_synchronous_entry.cc(1054)] Could not open platform files for entry.
[12032:12057:0106/151936.526716:ERROR:test_database_manager.cc(58)] Not implemented reached in virtual bool safe_browsing::TestSafeBrowsingDatabaseManager::CheckResourceUrl(const GURL &, safe_browsing::SafeBrowsingDatabaseManager::Client *)
[12032:12089:0106/151936.650718:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/prerender/prerender_browsertest.cc:966: Failure
Value of: prerenders[0]->number_of_loads()
  Actual: 1
Expected: expected_number_of_loads
Which is: 0
../../chrome/browser/prerender/prerender_browsertest.cc:968: Failure
Value of: GetPrerenderLoadEventCountForLinkNumber(0)
  Actual: 1
Expected: expected_number_of_loads
Which is: 0
[12032:12057:0106/151937.164513:ERROR:test_database_manager.cc(58)] Not implemented reached in virtual bool safe_browsing::TestSafeBrowsingDatabaseManager::CheckResourceUrl(const GURL &, safe_browsing::SafeBrowsingDatabaseManager::Client *)
[12032:12032:0106/151938.171111:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] PrerenderBrowserTest.FirstContentfulPaintTimingReuse, where TypeParam =  and GetParam() =  (4672 ms)

 
Owner: mattcary@chromium.org
Status: Started (was: Available)
Labels: -Sheriff-Chromium
Owner started work, doesn't need to be in sheriff queue for the moment.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/841efc17964ac66ffa6b8b5ff63436f4ff6d52c1

commit 841efc17964ac66ffa6b8b5ff63436f4ff6d52c1
Author: mattcary <mattcary@chromium.org>
Date: Wed Jan 11 16:21:04 2017

Prerender: avoid race condition with canceling prerender in test.

The test which started flaking started two prerenderers, the second which canceled the first. ChromeOS in particular exposed a race condition where the first prerender would complete before the second had a chance to cancel it. This in retrospect obvious situation exists elsewhere and has an easy fix in a HangingFirstRequestInterceptor which stalls the first prerender indefinitely, causing it to be reliably canceled by the second.

BUG= 679090 

TBR=droger

Review-Url: https://codereview.chromium.org/2616383002
Cr-Commit-Position: refs/heads/master@{#442918}

[modify] https://crrev.com/841efc17964ac66ffa6b8b5ff63436f4ff6d52c1/chrome/browser/prerender/prerender_browsertest.cc

Status: Fixed (was: Started)
Bots seem to be healthy after change submitted.

Sign in to add a comment