See if incremental linking can be enabled for x64 in goma/symbol_level=1 builds |
|||||
Issue descriptionIncremental linking is off for some modules for x64 builds due to VC++ limitations. However in goma builds, such as these settings: enable_nacl = false is_component_build = true is_debug = true use_goma = true it can probably be enabled. These are the relevant settings and they are very confusing: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/BUILD.gn?rcl=0&l=216 https://cs.chromium.org/chromium/src/build/config/win/BUILD.gn?rcl=0&l=366
,
Nov 22 2017
,
Nov 22 2017
,
Nov 22 2017
,
Apr 2 2018
Note that use_lld=true is now recommended (it is faster for full builds and avoids the problems associated with is_win_fastlink=true) and it doesn't currently support incremental linking, making this bug irrelevant in the near term.
,
Jun 19 2018
The switch to lld makes this irrelevant or fixed, depending on how you look at it. Incremental linking is now "enabled" on x64 builds (as of crrev.com/c/1092611) so that we get the optimization where import libraries aren't unnecessarily rewritten when /incremental is specified, and that's all that we can do. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by brucedaw...@chromium.org
, Feb 23 2017