New issue
Advanced search Search tips

Issue 679088 link

Starred by 2 users
Status: Fixed
Owner:
msw@chromium.org
Closed: Jan 2017
Cc:
jamescook@chromium.org
sky@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

mash: Shelf doesn't create items for windows open on startup.

Project Member Reported by msw@chromium.org, Jan 7 2017 
mash: Shelf doesn't create items for windows open on startup.
On ToT @ #441615, having built 'chrome' and 'mash:all':
(1) Run chrome --mash
(2) Observe the opened windows and the shelf items.
Expected: A shelf items exists for each open window.
Actual: The 'QuickLaunch' window doesn't have a shelf item.

A recent CL delayed the construction/initialization of the shelf.
ShelfWindowWatcher should scan appropriate containers for pre-existing windows.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24ccd0688d195440d8c37f0f256d9a379a25db25

commit 24ccd0688d195440d8c37f0f256d9a379a25db25
Author: msw <msw@chromium.org>
Date: Tue Jan 10 20:42:38 2017

Add ShelfWindowWatcher support for pre-existing windows.

Call OnDisplayAdded from ctor; consolidate code.
Call OnUserWindowAdded for each pre-existing window.
(catches windows constructed earlier than the shelf [window watcher])

Add ShelfWindowWatcherSessionStartTest.PreExistingWindow.

BUG= 679088 
TEST="chrome --mash" shows a QuickLaunch shelf item.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2618333004
Cr-Commit-Position: refs/heads/master@{#442678}

[modify] https://crrev.com/24ccd0688d195440d8c37f0f256d9a379a25db25/ash/common/shelf/shelf_window_watcher.cc
[modify] https://crrev.com/24ccd0688d195440d8c37f0f256d9a379a25db25/ash/common/shelf/shelf_window_watcher_unittest.cc

Comment 2 by msw@chromium.org, Jan 10 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment