i thought we triaged this to glibc's fortify logic under clang throwing false positives.   issue 676228  tracks it.

i'm not sure we cherry picked the fix back though.

is the priority for this bug correct?

@3: Good point.  Probably not.  Apparently this is causing problems on "RunIn.BadBlocks".  See http://crosbug.com/p/61731

Seems like it should be at least priority 2 because of that.

Cherrypick attempt for the workaround: https://chromium-review.googlesource.com/#/c/426778/

We can revert it when we cherrypick the fix to LLVM back.

The glibc upgrade roll
https://chromium-review.googlesource.com/#/c/424122/
also contains this workaround.

TIL cherrypicks into release branches require more effort than regular patches. :)

We'd like to merge: https://chromium-review.googlesource.com/#/c/426778/ , please!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a1c3f1f744286495572120aed25779952db61025

commit a1c3f1f744286495572120aed25779952db61025
Author: George Burgess IV <gbiv@google.com>
Date: Wed Dec 21 20:59:59 2016

glibc: make __bos check for NULL in clang FORTIFY

Clang's implementation of __builtin_object_size may hand back 0 if
null is passed into it. This is incompatible with gcc's
__builtin_object_size implementation, which answers conservatively in
this case.

Until this is fixed in clang
(https://llvm.org/bugs/show_bug.cgi?id=23277), we should do these checks
ourselves to keep FORTIFY from being overly aggressive.

Cherry-picking because we believe this is causing issues with badblocks
on R56. Please see the bug.

BUG= chromium:679081 
TEST=Local smoke tests pass on amd64-generic; will run cbuildbots on
oak+daisy+peppy.

Change-Id: I491c2bc09ba0b19df5c64a1ab00423e0e839972f
Reviewed-on: https://chromium-review.googlesource.com/422462
Commit-Ready: George Burgess <gbiv@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit e811746e2aad3a9135f800eeaaec8f8170d632d8)
Reviewed-on: https://chromium-review.googlesource.com/426778
Commit-Queue: George Burgess <gbiv@chromium.org>

[modify] https://crrev.com/a1c3f1f744286495572120aed25779952db61025/sys-libs/glibc/files/local/glibc-2.19-clang-fortify.patch
[rename] https://crrev.com/a1c3f1f744286495572120aed25779952db61025/sys-libs/glibc/glibc-2.19-r14.ebuild

Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

 Issue 683338  has been merged into this issue.

 Issue 696683  has been merged into this issue.

 Issue 698504  has been merged into this issue.

 Issue 698589  has been merged into this issue.

 Issue 704094  has been merged into this issue.

Closing. Please reopen it if its not fixed. Thanks!