New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679075 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 632623



Sign in to add a comment

Move presentation_session.{h,cc} to content/public/common

Project Member Reported by mfo...@chromium.org, Jan 6 2017

Issue description

Converting presentation.mojom to typemaps requires that these declarations be accessible from content/renderer and content/browser.

This patch is blocked until this is resolved.
https://codereview.chromium.org/2613153003

 
Blocking: 632623

Comment 2 by mfo...@chromium.org, Jan 10 2017

Also need to move presentation.mojom to content/

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f67aec28e1dc7f2d06865309ca99c16191a291d3

commit f67aec28e1dc7f2d06865309ca99c16191a291d3
Author: mfoltz <mfoltz@chromium.org>
Date: Tue Jan 10 21:20:24 2017

[Presentation API] Move Presentation API structs to public/common

This moves presentation_session.{h,cc} and
presentation_connection_message.{h,cc} to public/common so Mojo typemaps can be
written for presentation.mojom.

BUG= 679075 

Review-Url: https://codereview.chromium.org/2617143006
Cr-Commit-Position: refs/heads/master@{#442691}

[modify] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/chrome/browser/media/router/media_route.h
[modify] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/chrome/browser/media/router/media_router_base_unittest.cc
[modify] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/chrome/browser/media/router/mojo/media_router_type_converters.h
[modify] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/content/browser/presentation/presentation_type_converters.h
[modify] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/content/public/browser/BUILD.gn
[modify] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/content/public/common/BUILD.gn
[rename] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/content/public/common/presentation_connection_message.cc
[rename] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/content/public/common/presentation_connection_message.h
[rename] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/content/public/common/presentation_session.cc
[rename] https://crrev.com/f67aec28e1dc7f2d06865309ca99c16191a291d3/content/public/common/presentation_session.h

Comment 4 by sko...@chromium.org, Jan 12 2017

Status: Assigned (was: Untriaged)
Is this fixed now, or is there more to do?

Comment 5 by mfo...@chromium.org, Jan 12 2017

We also have to move presentation.mojom out of Blink and into content/common, which unfortunately is currently in a catch-22: either the layout tests or the Android build will break. 

Comment 6 by mfo...@chromium.org, Jan 30 2017

Status: Fixed (was: Assigned)
Turns out we don't need to move the mojom.  CLosing.

Sign in to add a comment