CQ: use updated delete-vote REST API to cancel CQ use |
|||||||
Issue descriptionDELETE vote now accepts revision property, and if revision is old, does nothing and raises exception. So, this can superseed our prior usage of voting on behalf of the user. This will also make log look better and will prevent potential security thread of CQ voting >0 on behalf of the users. internal bug: b/32273798 change to Gerrit: https://gerrit-review.googlesource.com/#/c/93482/ note: we have to wait for new Gerrit to be deployed to prod and be stable.
,
Jan 23 2017
,
Aug 31 2017
,
Aug 31 2017
,
Jan 3 2018
tandrii, any update on getting to this? Will this also help resolve https://bugs.chromium.org/p/chromium/issues/detail?id=733520?
,
Jan 3 2018
Yes, it's probably nicer this way, but today most users are already used to the way CQ works. This will take ~2 hours of work from start to post-deploy end2end test, but I don't see high enough impact to increase to Pri1. Also, this will only somewhat help with 733520, since there'd still be several calls to Gerrit instead of one.
,
Jan 4
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 7
To be revisited soon, because it can all be replaced by a plugin IFF cq had api. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by aga...@chromium.org
, Jan 11 2017