New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 679056 link

Starred by 5 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 731255



Sign in to add a comment

Mus needs to support api for extending hit region of children

Project Member Reported by sky@chromium.org, Jan 6 2017

Issue description

In ash resizing windows by clicking/pressing outside the window bounds works by way of EasyResizeWindowTargeter. Mus needs an api on the windowmanager to enable an api like this for containers. See EasyResizeWindowTargeter for the specifics.
 

Comment 1 by sky@chromium.org, Feb 10 2017

Cc: mfomitchev@chromium.org sky@chromium.org
 Issue 690978  has been merged into this issue.
Components: Internals>MUS
Labels: Proj-Mustash-Mash-WM Proj-Mustash-Milestone-Tadpole

Comment 3 by sky@chromium.org, Jun 23 2017

Blocking: 731255
Owner: sky@chromium.org
Status: Started (was: Untriaged)

Comment 4 by sky@chromium.org, Jun 23 2017

Cc: jonr...@chromium.org riajiang@chromium.org sadrul@chromium.org varkha@chromium.org
 Issue 736435  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c7105adf8bad38b09ab6ac73ba4162d152d72a3

commit 3c7105adf8bad38b09ab6ac73ba4162d152d72a3
Author: Scott Violet <sky@chromium.org>
Date: Mon Jun 26 21:16:44 2017

chromeos: makes EasyResizeWindowTargeter work with mus

Mus now supports this by way of converting (and renaming)
SetExtendedHitArea() to match the logic of
EasyResizeWindowTargeter. EasyResizeWindowTargeter itself then calls
to mus as appropriate.

BUG= 679056 
TEST=covered by tests

Change-Id: I5367807fbc419ed172364ef531f603b48b3aa010
Reviewed-on: https://chromium-review.googlesource.com/546638
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482401}
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ash/mus/non_client_frame_controller.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ash/shelf/shelf_window_targeter.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ash/wm/panels/attached_panel_window_targeter.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ash/wm/panels/attached_panel_window_targeter.h
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ash/wm/window_properties.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ash/wm/window_properties.h
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ash/wm/window_util.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ash/wm/window_util.h
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/services/ui/ws/event_dispatcher.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/services/ui/ws/event_dispatcher_unittest.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/services/ui/ws/event_targeter.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/services/ui/ws/event_targeter.h
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/services/ui/ws/focus_controller.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/services/ui/ws/server_window.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/services/ui/ws/server_window.h
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/services/ui/ws/window_finder.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/services/ui/ws/window_finder.h
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/services/ui/ws/window_finder_unittest.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/services/ui/ws/window_tree.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/services/ui/ws/window_tree.h
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ui/aura/test/mus/test_window_manager_client.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ui/aura/test/mus/test_window_manager_client.h
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ui/wm/BUILD.gn
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ui/wm/core/DEPS
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ui/wm/core/easy_resize_window_targeter.cc
[modify] https://crrev.com/3c7105adf8bad38b09ab6ac73ba4162d152d72a3/ui/wm/core/easy_resize_window_targeter.h

Comment 6 by sky@chromium.org, Jun 27 2017

Status: Fixed (was: Started)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment