New issue
Advanced search Search tips

Issue 679049 link

Starred by 2 users
Status: Fixed
Owner:
tguilbert@chromium.org
Closed: Jan 2017
Cc:
liber...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

MediaControls do not handle OnDurationChanges correctly

Project Member Reported by tguilbert@chromium.org, Jan 6 2017 
When WMPI encounters an OnDurationChanged event, HTMLMediaElement properly receives a notification, and the MediaControlTimelineElement gets properly updated, but not MediaControls::m_durationDisplay.

Example: https://developer.apple.com/streaming/examples/basic-stream-osx-ios4-3.html (using the new HLS playback path on Android) receives an initial duration of 0:00, and never updates to the proper duration once we receive the proper metadata.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e9a62259f89620d6c31829937af7dd59b486f10

commit 5e9a62259f89620d6c31829937af7dd59b486f10
Author: tguilbert <tguilbert@chromium.org>
Date: Mon Jan 09 20:38:24 2017

Fix displayed duration after onDurationChange

MediaControls::onDurationChange updates m_timeline, but does not update
the displayed duration. This means that HLS streams (and propably other
types of media) always have a duration of '0:00', because we don't know
the duration until we have started playing the media (and we initially
report a 0s duration).

This change fixes onDurationChange.

BUG= 679049 
TEST= Manually confirmed using a test HLS stream

Review-Url: https://codereview.chromium.org/2617993003
Cr-Commit-Position: refs/heads/master@{#442330}

[modify] https://crrev.com/5e9a62259f89620d6c31829937af7dd59b486f10/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Comment 2 by tguilbert@chromium.org, Jan 9 2017

Status: Fixed (was: Started)
►

Sign in to add a comment