mash: Device suspend/resume does not work with chrome --mash |
||||
Issue descriptionRight now if you close the lid the device stays running. I'm not sure what's breaking this. Probably PowerManagerClient isn't hooked up correctly. Ideally this would be fixed in such a way that we can suspend when chrome isn't running. Note: For Q1 we're not worrying about enterprise, so if there is policy code around suspend/resume feel free to ignore it (use IsRunningInMash() to skip). Mustash build instructions are at go/mustash-intro
,
Jan 6 2017
powerd suspends independently of Chrome -- it watches the lid switch to know when it's time to perform the lid-closed action. My best guesses about why this is broken would be: a) Chrome/ash/etc. is sending a power management policy to powerd telling it not to do anything when the lid is closed (this could happen for reasons independent of enterprise policy), or b) Chrome/ash/etc. is registering a suspend delay with powerd but then failing to tell powerd when it's actually ready to suspend. If you attach /var/log/power_manager/powerd.LATEST, grabbed after you leave the lid closed for at least twenty seconds (that's the timeout after which powerd goes ahead and suspends even if there are still-pending suspend delays), I can probably quickly see which of those two it is.
,
Jan 6 2017
OK, this is embarrassing - on cave, with R57-9152.0.0 everything seems to work fine. Here's the powerd logs: [0106/224522:INFO:daemon.cc(507)] Lid closed [0106/224522:INFO:wakeup_controller.cc(171)] Inhibiting /sys/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-ELAN0001:00/input/input4 [0106/224522:INFO:wakeup_controller.cc(171)] Inhibiting /sys/devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-7/i2c-ELAN0000:00/input/input5 [0106/224522:INFO:wakeup_controller.cc(171)] Inhibiting /sys/devices/platform/i8042/serio0/input/input3 [0106/224522:INFO:wakeup_controller.cc(158)] Disabling wakeup for /sys/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-ELAN0001:00/input/input4 through /sys/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-ELAN0001:00 [0106/224522:INFO:wakeup_controller.cc(158)] Disabling wakeup for /sys/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-ELAN0001:00/input/input4/event4 through /sys/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-ELAN0001:00 [0106/224522:INFO:wakeup_controller.cc(158)] Disabling wakeup for /sys/devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-7/i2c-ELAN0000:00/input/input5 through /sys/devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-7/i2c-ELAN0000:00 [0106/224522:INFO:wakeup_controller.cc(158)] Disabling wakeup for /sys/devices/platform/i8042/serio0/input/input3 through /sys/devices/platform/i8042/serio0 [0106/224522:INFO:state_controller.cc(899)] Ready to perform lid-closed action (suspend) [0106/224522:INFO:suspender.cc(397)] Starting request 88080385 [0106/224522:INFO:daemon.cc(596)] Reading wakeup count from /sys/power/wakeup_count [0106/224522:INFO:daemon.cc(600)] Read wakeup count 7944 [0106/224522:INFO:internal_backlight_controller.cc(674)] Setting brightness to 0 (0%) over 0 ms [0106/224522:INFO:internal_backlight_controller.cc(690)] Setting resume brightness to 116 (80%) [0106/224522:INFO:keyboard_backlight_controller.cc(493)] Setting brightness to 0 (0%) over 0 ms [0106/224522:INFO:suspend_delay_controller.cc(139)] Announcing suspend request 88080385 with 4 pending delay(s) and 0 outstanding delay(s) from previous request [0106/224522:INFO:suspend_delay_controller.cc(88)] Got notification that delay 88080394 (chrome) is ready for suspend request 88080385 from :1.1250 [0106/224522:INFO:suspend_delay_controller.cc(88)] Got notification that delay 88080395 (chrome) is ready for suspend request 88080385 from :1.1251 [0106/224522:INFO:suspend_delay_controller.cc(88)] Got notification that delay 88080385 (shill) is ready for suspend request 88080385 from :1.9 [0106/224542:WARNING:suspend_delay_controller.cc(207)] Timed out while waiting for suspend request 88080385 readiness confirmation for 1 delay(s): 88080396 (:1.1252: chrome) [0106/224542:INFO:suspend_delay_controller.cc(224)] Notifying observers that suspend is ready [0106/224542:INFO:suspender.cc(466)] Starting suspend [0106/224542:INFO:main.cc(259)] Running "/usr/bin/powerd_setuid_helper --action=suspend --suspend_wakeup_count_valid --suspend_wakeup_count=7944" [0106/224711:INFO:daemon.cc(693)] powerd_suspend returned 0 [0106/224711:INFO:suspender.cc(424)] Finishing request 88080385 successfully [0106/224711:INFO:internal_backlight_controller.cc(674)] Setting brightness to 116 (80%) over 0 ms [0106/224711:INFO:keyboard_backlight_controller.cc(493)] Setting brightness to 40 (40%) over 200 ms [0106/224711:INFO:activity_logger.cc(20)] Hovering stopped 21 sec ago [0106/224711:INFO:daemon.cc(516)] Lid opened [0106/224711:INFO:wakeup_controller.cc(171)] Un-inhibiting /sys/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-ELAN0001:00/input/input4 [0106/224711:INFO:wakeup_controller.cc(171)] Un-inhibiting /sys/devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-7/i2c-ELAN0000:00/input/input5 [0106/224711:INFO:wakeup_controller.cc(171)] Un-inhibiting /sys/devices/platform/i8042/serio0/input/input3 [0106/224711:INFO:wakeup_controller.cc(158)] Disabling wakeup for /sys/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-ELAN0001:00/input/input4 through /sys/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-ELAN0001:00 [0106/224711:INFO:wakeup_controller.cc(158)] Disabling wakeup for /sys/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-ELAN0001:00/input/input4/event4 through /sys/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-6/i2c-ELAN0001:00 [0106/224711:INFO:wakeup_controller.cc(158)] Enabling wakeup for /sys/devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-7/i2c-ELAN0000:00/input/input5 through /sys/devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-7/i2c-ELAN0000:00 [0106/224711:INFO:wakeup_controller.cc(158)] Enabling wakeup for /sys/devices/platform/i8042/serio0/input/input3 through /sys/devices/platform/i8042/serio0 [0106/224711:INFO:daemon.cc(772)] On AC (USB_PD, 0.000A at 19.8V, max 2.2A at 20.0V) with battery at 100%, 4.838/4.838Ah at 0.634A, full [0106/224711:INFO:activity_logger.cc(20)] Hovering started [0106/224713:INFO:ambient_light_handler.cc(195)] Hysteresis overcome; transitioning to 0% (step 1) for lux 44 (keyboard) [0106/224713:INFO:keyboard_backlight_controller.cc(493)] Setting brightness to 0 (0%) over 2000 ms [0106/224716:INFO:daemon.cc(772)] On AC (USB_PD, 0.000A at 19.9V, max 2.2A at 20.0V) with battery at 100%, 4.838/4.838Ah at 0.645A, full Hooray, nothing to do! I'm quite certain that shutdown doesn't work, though -- I'll file a bug for that.
,
Feb 26 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jamescook@chromium.org
, Jan 6 2017