ios_web_unittests (iPad Air 2 iOS 10.0) failing on chromium.mac/ios-simulator |
||
Issue descriptionios_web_unittests (iPad Air 2 iOS 10.0) failing on chromium.mac/ios-simulator Type: build-failure Builders failed on: - ios-simulator: https://build.chromium.org/p/chromium.mac/builders/ios-simulator Tests: [ RUN ] CRWWebControllerPageDialogOpenPolicyTest.AllowPrompt ../../ios/web/web_state/ui/crw_web_controller_unittest.mm:608: Failure Value of: ExecuteJavaScript(@"prompt('Yes?', 'No')") Actual: <null> Expected: @"Maybe" Which is: Maybe [ FAILED ] CRWWebControllerPageDialogOpenPolicyTest.AllowPrompt (280 ms) [ RUN ] CRWWebControllerPageDialogOpenPolicyTest.AllowConfirmWithTrue ../../ios/web/web_state/ui/crw_web_controller_unittest.mm:553: Failure Value of: ExecuteJavaScript(@"confirm('test')") Actual: 0 Expected: @__objc_yes Which is: 1 [ FAILED ] CRWWebControllerPageDialogOpenPolicyTest.AllowConfirmWithTrue (290 ms)
,
Jan 6 2017
Issue 679059 has been merged into this issue.
,
Jan 6 2017
Fixed on review: https://codereview.chromium.org/2612423003/
,
Jan 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d41c27d99e1f50349bee096fa92efe91635c9f1 commit 1d41c27d99e1f50349bee096fa92efe91635c9f1 Author: eugenebut <eugenebut@chromium.org> Date: Fri Jan 06 23:26:37 2017 [ios] Fixed memory management bug in TestJavaScriptDialogPresenter. Copy strings before passing them to scoped_nsobjects. BUG= 679032 Review-Url: https://codereview.chromium.org/2612423003 Cr-Commit-Position: refs/heads/master@{#442093} [modify] https://crrev.com/1d41c27d99e1f50349bee096fa92efe91635c9f1/ios/web/public/test/fakes/test_java_script_dialog_presenter.mm
,
Jan 9 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by eugene...@chromium.org
, Jan 6 2017Status: Started (was: Available)