ChromeNativeAppWindowViewsAuraAsh doesn't work with mash |
|||||
Issue descriptionThis class is using WindowState and Shell, both of which won't work outside of chrome. It needs to be ported to work in mash. For the time being I'll make it use ChromeNativeAppWindowViewsAura when running in mash.
,
Jan 17 2017
,
Jan 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f49f1ae7c8896402177da53ff27d53be29fcca5c commit f49f1ae7c8896402177da53ff27d53be29fcca5c Author: msw <msw@chromium.org> Date: Mon Jan 30 18:08:25 2017 mash: Use ChromeNativeAppWindowViewsAuraAsh; workaround crashes. Revert the ChromeNativeAppWindowViewsAura workaround. Initialize the views::Widget::InitParams::mus_properties for mash. (set the correct container, display id, and shelf item type) Use ChromeNativeAppWindowViews's NonClientFrameView for panels too. (ash::CustomFrameViewAsh and ash::PanelFrameView are still broken in mash) BUG= 679028 , 672599 TEST=chrome --mash panel windows are right-aligned. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2665523002 Cr-Commit-Position: refs/heads/master@{#447014} [modify] https://crrev.com/f49f1ae7c8896402177da53ff27d53be29fcca5c/chrome/browser/ui/views/apps/chrome_app_window_client_views_chromeos.cc [modify] https://crrev.com/f49f1ae7c8896402177da53ff27d53be29fcca5c/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
,
Jan 30 2017
I restored use of ChromeNativeAppWindowViewsAuraAsh, but mash still doesn't use CustomFrameViewAsh and PanelFrameView here (maybe it's okay as-is and should just rely on the wm-provided frame?), and there's a shelf visibility update that's skipped on mash. These are more minor details, but I'll leave this open for now.
,
Feb 15 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 15 2018
I think the core issue here has been resolved. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jan 6 2017