New issue
Advanced search Search tips

Issue 679028 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 672599



Sign in to add a comment

ChromeNativeAppWindowViewsAuraAsh doesn't work with mash

Project Member Reported by sky@chromium.org, Jan 6 2017

Issue description

This class is using WindowState and Shell, both of which won't work outside of chrome. It needs to be ported to work in mash. For the time being I'll make it use ChromeNativeAppWindowViewsAura when running in mash.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/148ae8075bfdc22e122b3307d3344337db12d00c

commit 148ae8075bfdc22e122b3307d3344337db12d00c
Author: sky <sky@chromium.org>
Date: Fri Jan 06 21:53:27 2017

Makes mash use ChromeNativeAppWindowViewsAura

Mash should really use ChromeNativeAppWindowViewsAuraAsh, but that
depends upon a bunch of types in ash. So, make mash use
ChromeNativeAppWindowViewsAura, which isn't perfect, but at least it
doesn't crash.

BUG= 679028 
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2617923004
Cr-Commit-Position: refs/heads/master@{#442067}

[modify] https://crrev.com/148ae8075bfdc22e122b3307d3344337db12d00c/chrome/browser/ui/views/apps/chrome_app_window_client_views_chromeos.cc

Comment 2 by msw@chromium.org, Jan 17 2017

Blocking: 672599
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f49f1ae7c8896402177da53ff27d53be29fcca5c

commit f49f1ae7c8896402177da53ff27d53be29fcca5c
Author: msw <msw@chromium.org>
Date: Mon Jan 30 18:08:25 2017

mash: Use ChromeNativeAppWindowViewsAuraAsh; workaround crashes.

Revert the ChromeNativeAppWindowViewsAura workaround.
Initialize the views::Widget::InitParams::mus_properties for mash.
(set the correct container, display id, and shelf item type)

Use ChromeNativeAppWindowViews's NonClientFrameView for panels too.
(ash::CustomFrameViewAsh and ash::PanelFrameView are still broken in mash)

BUG= 679028 , 672599 
TEST=chrome --mash panel windows are right-aligned.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2665523002
Cr-Commit-Position: refs/heads/master@{#447014}

[modify] https://crrev.com/f49f1ae7c8896402177da53ff27d53be29fcca5c/chrome/browser/ui/views/apps/chrome_app_window_client_views_chromeos.cc
[modify] https://crrev.com/f49f1ae7c8896402177da53ff27d53be29fcca5c/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

Comment 4 by msw@chromium.org, Jan 30 2017

Cc: msw@chromium.org
Status: Available (was: Untriaged)
I restored use of ChromeNativeAppWindowViewsAuraAsh, but mash still doesn't use CustomFrameViewAsh and PanelFrameView here (maybe it's okay as-is and should just rely on the wm-provided frame?), and there's a shelf visibility update that's skipped on mash. These are more minor details, but I'll leave this open for now.
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 15 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by msw@chromium.org, Feb 15 2018

Status: WontFix (was: Untriaged)
I think the core issue here has been resolved.

Sign in to add a comment