mash: chrome should not use ash::Shell::Get()->RecordUserMetricsAction |
||||
Issue descriptionThere is no WmShell instance. Just inline calls to base::RecordAction / base::UserMetricsAction
,
Jun 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/465370c70b01e9934ae061510d7a2f5e80f3dafc commit 465370c70b01e9934ae061510d7a2f5e80f3dafc Author: James Cook <jamescook@chromium.org> Date: Thu Jun 29 15:31:30 2017 chromeos: Remove IME values from the ash UserMetricsAction enum Ash doesn't need to use UserMetricsRecorder anymore -- I think it dates back to when metrics had to go through the content module. The code can directly call base::RecordAction() now. Bug: 678998 Test: ash_unittests, manually switch IMEs Change-Id: I53ce99037972d6f580b7130b64609afbc1f9146d Reviewed-on: https://chromium-review.googlesource.com/553461 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#483368} [modify] https://crrev.com/465370c70b01e9934ae061510d7a2f5e80f3dafc/ash/metrics/user_metrics_action.h [modify] https://crrev.com/465370c70b01e9934ae061510d7a2f5e80f3dafc/ash/metrics/user_metrics_recorder.cc [modify] https://crrev.com/465370c70b01e9934ae061510d7a2f5e80f3dafc/ash/system/ime/tray_ime_chromeos.cc [modify] https://crrev.com/465370c70b01e9934ae061510d7a2f5e80f3dafc/ash/system/ime_menu/ime_list_view.cc [modify] https://crrev.com/465370c70b01e9934ae061510d7a2f5e80f3dafc/ash/system/ime_menu/ime_menu_tray.cc
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcdb7dda930d365288aadfe4449a0c972b77d5a3 commit bcdb7dda930d365288aadfe4449a0c972b77d5a3 Author: James Cook <jamescook@chromium.org> Date: Fri Jun 30 19:18:16 2017 chromeos: Remove calls to ash metrics recorder from chrome browser For the go/mustash project code in //ash runs in a separate process. Code in chrome browser cannot call directly into it. Convert calls to the ash metrics service to directly call base::RecordAction/base::UserMetricsAction. Under classic ash the code is equivalent and under mash the metrics will eventually be collected by a mojo metrics service. Convert a11y calls inside of ash as well. Fix a case where we were double-counting when the user enabled spoken feedback. Bug: 678998 Test: ash_unittests, unit_tests, manually toggle a11y options in status area and check chrome://user-actions Change-Id: I2590b043eaec64e16b7553986c9f2bae6358ac3e Reviewed-on: https://chromium-review.googlesource.com/556304 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#483786} [modify] https://crrev.com/bcdb7dda930d365288aadfe4449a0c972b77d5a3/ash/metrics/user_metrics_action.h [modify] https://crrev.com/bcdb7dda930d365288aadfe4449a0c972b77d5a3/ash/metrics/user_metrics_recorder.cc [modify] https://crrev.com/bcdb7dda930d365288aadfe4449a0c972b77d5a3/ash/system/tray_accessibility.cc [modify] https://crrev.com/bcdb7dda930d365288aadfe4449a0c972b77d5a3/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/bcdb7dda930d365288aadfe4449a0c972b77d5a3/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
,
Jun 30 2017
,
Jan 22 2018
,
Feb 26 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jamescook@chromium.org
, Jun 28 2017Status: Started (was: Untriaged)
Summary: mash: chrome should not use ash::Shell::Get()->RecordUserMetricsAction (was: mash: chrome should not use ash::WmShell::RecordUserMetricsAction)