New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678995 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: ----
Type: ----



Sign in to add a comment

Should house_arrest failures turn a step red?

Project Member Reported by rohitrao@chromium.org, Jan 6 2017

Issue description

A number of device bots have failed recently because some problem with the house_arrest service is preventing us from copying logs off of the device.  This is turning the corresponding step red, even though all of the tests themselves passed.

Should we make copying logs be "best effort" and not turn the step red on failure?  If we did so, would there be any other way to notice and fix the problem when a device broke?
 
Maybe the step should go purple?  It looks like SoM might ignore exceptions.  But having a tree full of purple isn't much better than a tree full of red.

Another alternative is to copy logs in a separate step and exclude that from the gatekeeper configs.

Comment 2 by s...@google.com, Jan 7 2017

I can make it purple if we fail to copy test data off the device but the test succeeds, but I think house_arrest is usually indicative of a bigger problem with the device and the device should probably be restarted anyway before the test itself stops launching.
Can we / should we take the device out of the swarming pool when this happens?

The device I'm looking at now (build36-b7) consistently failed every device test once it entered this state, but I don't know if that is always true.

Comment 4 by s...@google.com, Jan 7 2017

Making it purple as in #2 will implicitly take it out of the pool, so sure.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c948f45780a4dbdd9b3fac209b72977d407953b

commit 4c948f45780a4dbdd9b3fac209b72977d407953b
Author: smut <smut@google.com>
Date: Mon Jan 09 21:31:12 2017

Raise an exception if test data or crash reports can't be copied off a device

BUG= 678995 

Review-Url: https://codereview.chromium.org/2618163002
Cr-Commit-Position: refs/heads/master@{#442355}

[modify] https://crrev.com/4c948f45780a4dbdd9b3fac209b72977d407953b/ios/build/bots/scripts/test_runner.py

Owner: smut@chromium.org
Status: Assigned (was: Untriaged)

Comment 7 by s...@google.com, Jan 11 2017

Cc: -smut@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment