New issue
Advanced search Search tips

Issue 678990 link

Starred by 2 users
Status: Duplicate
Merged: issue 871840
Owner:
wzang@chromium.org
Closed: Dec 3
Cc:
derat@chromium.org
xiy...@chromium.org
est...@chromium.org
jdufault@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 678705



Sign in to add a comment

mash: chrome SigninScreenHandler should not access ash::Shell

Project Member Reported by jamescook@chromium.org, Jan 6 2017 
This is used to trigger shutdown from the login screen.

This should switch to mojo, sending a message to whoever controls shutdown (probably ash via the shutdown.mojom interface).

See also  issue 678988  for login.

Comment 1 by est...@chromium.org, Aug 9 2017

Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b95cbc39d36ff8e7061734ce421fc163b7e24df5

commit b95cbc39d36ff8e7061734ce421fc163b7e24df5
Author: Evan Stade <estade@chromium.org>
Date: Wed Aug 09 20:42:41 2017

Use mojo for handling shutdown from ChromeOS login screen.

Bug:  678990 
Change-Id: I57b2306235b34ccf04027828e74c7db0bdda4b3a
Reviewed-on: https://chromium-review.googlesource.com/607708
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493132}
[modify] https://crrev.com/b95cbc39d36ff8e7061734ce421fc163b7e24df5/ash/public/interfaces/shutdown.mojom
[modify] https://crrev.com/b95cbc39d36ff8e7061734ce421fc163b7e24df5/ash/shutdown_controller.cc
[modify] https://crrev.com/b95cbc39d36ff8e7061734ce421fc163b7e24df5/ash/shutdown_controller.h
[modify] https://crrev.com/b95cbc39d36ff8e7061734ce421fc163b7e24df5/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Comment 3 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService

Comment 4 by est...@chromium.org, Mar 13 2018

Cc: est...@chromium.org
Owner: wzang@chromium.org
what's left to do here is all wallpaper controller related. I think wzang@ is working on that?

Comment 5 by wzang@chromium.org, Mar 13 2018 

I'll clean up the wallpaper related code there after the views-based login is enabled by default: https://chromium-review.googlesource.com/c/chromium/src/+/957967

Comment 6 by wzang@chromium.org, Apr 16 2018 

The wallpaper controller access has been converted to mojo. But there's a recently added |DetachableBaseHandler| access that's not using mojo. Will continue to work on this.

Comment 7 by jamescook@chromium.org, Apr 19 2018

Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash

Comment 8 by steve...@chromium.org, Aug 7 

DetachableBaseHandler dependency is being tracked in  issue 871840

Comment 9 by wzang@chromium.org, Aug 7

Status: Fixed (was: Assigned)
Close this issue per #8.

Comment 10 by steve...@chromium.org, Dec 3

Cc: jdufault@chromium.org
Status: Assigned (was: Fixed)
There are still unresolved dependencies on ash/detachable_base.

Comment 11 by wzang@chromium.org, Dec 3

Mergedinto: 871840
Status: Duplicate (was: Assigned)
ash/detachable_base is tracked by  issue 871840 , so I believe the two issues should be merged.
►

Sign in to add a comment