I was also able to reproduce this on Windows 10 on Canary.

Additional Example:
https://support.jwplayer.com/customer/en/portal/articles/1430358-using-rtmp-streaming 

I'm seeing intermittent failure setting properties on "object" elements. JW Player depends on methods it adds to the object element for communication between Flash and JavaScript. When object.prop = x does not actually update object.prop, this breaks our player when configured to play using Flash.

We have taken steps to attempt an embed with flash and if there is no "ack" ignore the developers choice to force Flash playback, however the exception thrown in this example breaks this failsafe.

Reproduction Steps: Here is a block of code that reproduces the issue. I've found that results vary depending on the page's protocol or number of times this block is executed. The page should be set to "Allow" or "Ask" for Flash plugin playback.

Expected: The code should run without any exceptions. 
Actual: Intermittently (more that not with 56.0.2924.51) setting properties on the object element fails. Attempting to access the property returns the previous value (undefined or in some cases where it was set previously, it is not updated)
 "Uncaught TypeError: swf.on is not a function"

var swf = document.createElement('object');
swf.setAttribute('type', 'application/x-shockwave-flash');
swf.setAttribute('data', '//ssl.p.jwpcdn.com/player/v/7.8.7/jwplayer.loader.swf');
swf.setAttribute('width', '100%');
swf.setAttribute('height', '100%');
swf.setAttribute('id', 'jwplayer');
swf.setAttribute('name', 'jwplayer');
document.body.appendChild(swf);
swf.className = 'jw-swf';
swf.style.display = 'block';
swf.style.position = 'absolute';
swf.style.left = 0;
swf.style.right = 0;
swf.style.top = 0;
swf.style.bottom = 0;

// Add custom properties
swf['on'] = function() {};
swf['once'] = function() {};
swf.trigger = function() {};

// Attempt to envoke functions added to object element
swf.on();
swf.once();
swf.trigger();

The problem is visible here as well.

https://erikdonohoo.github.io/jwplayer-flash-player-issue/

On Mac OSX 10.12.2 and Chrome 56

I could not repro this given the PBS & support.jswplayer examples on Win10+chrome canary 57.0.2970.0 (Official Build) canary (64-bit). videos both played fine.

For the erikdonohoo.github.io example (same OS+chrome canary), I get the "Error loading player : no playable sources found". 

@danny, rob, erik : can you check chrome://flags/#prefer-html-over-flash and set to Enabled? this is the HTML5-by-default feature (see also : https://blog.chromium.org/2016/12/roll-out-plan-for-html5-by-default.html).

If I "Allow" Flash for erik's example (after HTML5 by default is enabled) I get a JWPlayer timeout error : "Setup Timeout Error: setup took longer than 30 seconds to complete". 

what does JWPlayer do in the case that Flash is unavailable (doesn't appear in navigator.plugins or navigator.mimetypes)? 

moving this back to untriaged as I cannot repro the issues outside of erik's site. Even when I disable HTML5 by default (so flash is available), i get the same setup timeout error on erik's example.

That timeout issue is the issue. You will notice a console error from
jwplayer trying to access the object tag and it isn't there to work with

JW Player does not use Flash when it is not available. "Error loading player : no playable sources found" means that an HTML5 compatible source was not provided. Our player works as expected with HTML5-by-default - no bugs there.

Developers can configure JW Player to use Flash if available. Since Flash can still be blocked when installed (navigator.plugins reports a Flash version, but the plugin will not run) we still require the swf to execute a JavaScript callback before JW Player considers Flash "available".

The bug Danny and I are concerned with here is a new issue with setting properties on object elements. The behavior I described ("Uncaught TypeError: swf.on is not a function") prevents our flash swf from calling back to JavaScript.

I came up with a workaround for the next release of JW Player https://github.com/jwplayer/jwplayer/pull/1686, but there will still be many sites hosting their own jwplayer.js that will be impacted by this issue, so we're hoping the cause can be identified and fix made before 56 is released.

I am able to reproduce the problem in the console. If you'd like a standalone test page (so you don't hit CORS issues loading the swf) we can put one up.

var swf = document.createElement('object');
swf.setAttribute('type', 'application/x-shockwave-flash');
swf.setAttribute('data', '//ssl.p.jwpcdn.com/player/v/7.8.7/jwplayer.loader.swf');
document.body.appendChild(swf);
swf['on'] = function() {};
console.log(swf.on);
// logs "undefined"
swf.on();
// Uncaught TypeError: swf.on is not a function

What @rob mentioned is the issue at hand. 

Even with chrome://flags/#prefer-html-over-flash set to Enabled the issue is reproducible. 

Here's an isolated test case:

http://demo.jwplayer.com/flash-object/

`swf.embedCallback` is never set and can never be invoked by Flash.

> If I "Allow" Flash for erik's example (after HTML5 by default is enabled) I get a JWPlayer timeout error : "Setup Timeout Error: setup took longer than 30 seconds to complete". 

That's the bug, if you have a look in the console you'll see "Uncaught TypeError: x.once is not a function"

Unable to reproduce the issue on Mac 10.12.2 , Linux Ubuntu 14.04 & windows 10 with latest Canary version-57.0.2977.0 ,reported beta version-56.0.2924.51 & observed below: 

1.URL->http://www.pbs.org/video/2365921903/ ---> loaded successfully.

2."Failed to set property on object element: [object HTMLObjectElement]"  message observed in Devtools->Console as per the steps mentioned in Comment#9,10 & 11.

Note: Above error not observed in Chrome stable version-55.0.2883.87

Please find the attached screencast for reference .

Could you please check the issue in latest Canary  and update the thread with clear reproduce steps if still issue persists.

Thanks in advance.

Deleted: 678986.mp4 12.0 MB

	678986.mp4 12.0 MB View Download

I can still reproduce the issue on the latest chrome canary.  I'm not sure why you aren't seeing it.  This is on Mac 10.12.2 having just downloaded and installed Chrome Canary.  I also show the issue still occurring on Chrome 56 as well

Deleted: flash issue.mp4 1.0 MB

	flash issue.mp4 1.0 MB View Download

@jmukthavaram The page should be set to "Allow" or "Ask" for Flash plugin playback.


"Failed to set property on object element" is not an issue in stable. Only in beta and canary.

@jmukthavaram were you able to verify on Beta or Canary? 

Here is an additional example:
http://www.wwe.com/videos/john-cena-vs-baron-corbin-smackdown-live-jan-10-2017

Hey Prudhvi/ Krishna,

Could you help me find someone to bisect this issue?  It looks like a potential regression over 54.

I am working on the Bisect will update soon.

Please find the bisect range below :

Last good build : 56.0.2924.36
First bad build : 56.0.2924.37

Change log :
https://chromium.googlesource.com/chromium/src/+log/56.0.2924.36..56.0.2924.37?pretty=fuller&n=10000

The issue is present on Windows 10(Not on Windows 7), Mac(10.12).

Note: Since the machine where I was able to reproduce the bug are non corp machine and I can't perform the per-cl bisect. The range which provided has 13 Cl's can't figure out which would have caused this to issue. 

Able to reproduce the issue on Mac 10.12.2 and Win-10 using chrome reported version #56.0.2924.51 but unable to reproduce using latest canary #57.0.2982.0.

Issue is not reproducible on Linux.

Reverse Bisect Information:
============================
Good build: 57.0.2980.0	 Revision(443474)
Bad Build : 57.0.2979.0	 Revision(443120)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/f651acf25aaea54d6aed2488c8237214f1a2b38f..314c0c8fcb9c97c7588a2302df4df7b4b0097c0c

From the above change log suspecting below change

Review url: https://codereview.chromium.org/2610393003

yunchao.he@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks...!!

We will be affected by this bug too once version 56 build is released. Will this be fixed in the version 56 build?

Mo, could you please confirm whether the patch mentioned in #23 would have fixed the issue in canary? If yes, could we merge the Cl to M56.

I don't know what tool the reverse bisect used, but the result is wrong.

I did another reverse bisect, and last bad 443211, first good, 443216.  I think crrev.com/443212 fixed the bug.

Thanks Mo. 

Looks like - https://chromium.googlesource.com/chromium/src/+/8a4fe2fc28bb45f58445d5802057efdafbe7719b seems to be the Cl which fixed the issue in canary.

This is already patched to M56 - https://chromium.googlesource.com/chromium/src/+/45f356d8a3036166754170d36019bb25ab128328

We will verify in today's RC.

Verified the fix on Mac 10.12.2 and Win-10 using Chrome beta version #56.0.2924.67 as per the comment #0.

Observed that the video player loaded with flash content and played without any issues. 

Hence, the fix is working as expected.

Attaching the screencast for reference

Adding the verified labels.

Thanks...!!

Deleted: 678986.mp4 2.4 MB

	678986.mp4 2.4 MB View Download

Thanks, tagging as verified.

[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.