New issue
Advanced search Search tips

Issue 678967 link

Starred by 4 users

Issue metadata

Status: Archived
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

"DownloadExtensionTest.DownloadExtensionTest_FileIcon_Active" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jan 6 2017

Issue description

"DownloadExtensionTest.DownloadExtensionTest_FileIcon_Active" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRgsSBUZsYWtlIjtEb3dubG9hZEV4dGVuc2lvblRlc3QuRG93bmxvYWRFeHRlbnNpb25UZXN0X0ZpbGVJY29uX0FjdGl2ZQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: OS-Windows
Owner: benjhayden@chromium.org
Status: Assigned (was: Untriaged)
Assigning to owner of relevant directory.
Cc: asanka@chromium.org
+asanka who just touched the files in this backtrace:

[5716:4200:0105/144346.392:FATAL:download_manager_impl.cc(195)] Check failed: !base::ContainsKey(downloads_, id).
Backtrace:
	base::debug::StackTrace::StackTrace [0x0000000141EEB6F1+33]
	logging::LogMessage::~LogMessage [0x0000000141E88F6A+74]
	content::DownloadManagerImpl::CreateActiveItem [0x0000000141785FA5+285]
	content::DownloadManagerImpl::StartDownloadWithId [0x000000014178831E+334]
	base::internal::InvokeHelper<1,void>::MakeItSo<void (__cdecl content::DownloadManagerImpl::*const & __ptr64)(std::unique_ptr<content::DownloadCreateInfo,std::default_delete<content::DownloadCreateInfo> >,std::unique_ptr<content::ByteStreamReader,std::defa [0x0000000141784B09+169]
	base::internal::Invoker<base::internal::BindState<void (__cdecl content::DownloadManagerImpl::*)(std::unique_ptr<content::DownloadCreateInfo,std::default_delete<content::DownloadCreateInfo> >,std::unique_ptr<content::ByteStreamReader,std::default_delete<c [0x0000000141784F59+93]
	ChromeDownloadManagerDelegate::ReturnNextId [0x0000000141FE8FC8+396]
	ChromeDownloadManagerDelegate::GetNextId [0x0000000141FE7BA2+294]
	content::DownloadManagerImpl::GetNextId [0x00000001417874F0+224]
	content::DownloadManagerImpl::StartDownload [0x0000000141788159+813]
	base::internal::Invoker<base::internal::BindState<void (__cdecl*)(std::unique_ptr<content::DownloadCreateInfo,std::default_delete<content::DownloadCreateInfo> >,std::unique_ptr<content::DownloadResourceHandler::DownloadTabInfo,std::default_delete<content: [0x000000014178D5A0+516]
	base::internal::Invoker<base::internal::BindState<void (__cdecl*)(std::unique_ptr<content::DownloadCreateInfo,std::default_delete<content::DownloadCreateInfo> >,std::unique_ptr<content::DownloadResourceHandler::DownloadTabInfo,std::default_delete<content: [0x000000014178C731+117]
	base::debug::TaskAnnotator::RunTask [0x0000000141F346F6+390]
	base::MessageLoop::RunTask [0x0000000141E9C25E+1294]
	base::MessageLoop::DoWork [0x0000000141E9AECA+394]
	base::MessagePumpForUI::DoRunLoop [0x0000000141F35DE1+113]
	base::MessagePumpWin::Run [0x0000000141F365A4+84]
	base::RunLoop::Run [0x0000000141E9F6D1+161]
	content::RunThisRunLoop [0x00000001424A90F2+54]
	content::MessageLoopRunner::Run [0x00000001424A8C21+121]
	ui_test_utils::NavigateToURLWithDispositionBlockUntilNavigationsComplete [0x0000000141F67E03+1087]
	ui_test_utils::NavigateToURL [0x0000000141F67986+26]
	extensions::`anonymous namespace'::MockIconExtractorImpl::`scalar deleting destructor' [0x0000000140159DF8+3872]
	extensions::DownloadExtensionTest_DownloadExtensionTest_FileIcon_Active_Test::RunTestOnMainThread [0x000000014016D90E+2322]
	InProcessBrowserTest::RunTestOnMainThreadLoop [0x0000000141F65E6E+238]
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0aa1ff22fb300c789dab802b83ff9fdbada88df

commit d0aa1ff22fb300c789dab802b83ff9fdbada88df
Author: dewittj <dewittj@chromium.org>
Date: Fri Jan 06 20:26:21 2017

Disable DownloadExtensionTest.DownloadExtensionTest_FileIcon_Active on Windows.

"DownloadExtensionTest.DownloadExtensionTest_FileIcon_Active" is flaky.

BUG= 678967 
TBR=benjhayden@chromium.org

Review-Url: https://codereview.chromium.org/2616133002
Cr-Commit-Position: refs/heads/master@{#442027}

[modify] https://crrev.com/d0aa1ff22fb300c789dab802b83ff9fdbada88df/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Labels: -Pri-1 Pri-2

Comment 5 by timloh@chromium.org, Jan 10 2017

Labels: -Sheriff-Chromium
Removing from sheriff queue since this has an owner assigned.
Cc: benjhayden@chromium.org
 Issue 708588  has been merged into this issue.
Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, Jun 13 2017

Labels: Sheriff-Chromium
Detected 5 new flakes for test/step "DownloadExtensionTest.DownloadExtensionTest_FileIcon_Active". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRgsSBUZsYWtlIjtEb3dubG9hZEV4dGVuc2lvblRlc3QuRG93bmxvYWRFeHRlbnNpb25UZXN0X0ZpbGVJY29uX0FjdGl2ZQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Pri-2 Pri-1
This is flaky try bots and increasing commit time for all developers. Please address immediately or disable the test. The stack trace in c#2 is still the failure culprit.
Components: UI>Browser>Downloads
+Downloads team.
Labels: OS-Linux
Disabling for linux since already disabled for windows,

https://chromium-review.googlesource.com/c/534834/
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37df2ae529148adcb5f8a867ed90aa1d05dd5fe8

commit 37df2ae529148adcb5f8a867ed90aa1d05dd5fe8
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Wed Jun 14 00:07:56 2017

Disable flaky DownloadExtensionTest_FileIcon_Active.

BUG= 678967 
TBR=benjhayden

Change-Id: Ib5deffbc307bf3fead0a015f589bcc686a665037
Reviewed-on: https://chromium-review.googlesource.com/534834
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479217}
[modify] https://crrev.com/37df2ae529148adcb5f8a867ed90aa1d05dd5fe8/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

Labels: -Sheriff-Chromium
Status: Archived (was: Assigned)

Sign in to add a comment