Talking with rjkroege@ this seems like a good next step. You'll need to move and refactor some of the existing code so it still works with cash but also works with mus.

1. Move display preference code from ash/display/ to ui/display/manager/.
2. Refactor and move most of the display preference code from chrome/browser/chromeos/display/ to ui/display/manager/. Some things are probably cash only here.
3. Refactor display preference code to work with the display preference service.
4. Use the display preference code in mus-ws to load and save display preferences.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a5d265ee2cc632d0c6c6ee7bcef12c2482d5bf4

commit 9a5d265ee2cc632d0c6c6ee7bcef12c2482d5bf4
Author: thanhph <thanhph@chromium.org>
Date: Sat Mar 18 18:57:11 2017

Move display preference code from ash/display/ to ui/display/manager/.

This cl moves Ash dependencies out of display_preferences.cc. This is
an effort to separate Ash and Chrome in the new split processes
architecture and make DisplayPreferences work with mustash.

BUG= 678949 

Review-Url: https://codereview.chromium.org/2733313002
Cr-Commit-Position: refs/heads/master@{#457974}

[modify] https://crrev.com/9a5d265ee2cc632d0c6c6ee7bcef12c2482d5bf4/ash/BUILD.gn
[delete] https://crrev.com/a6ee9bc5a05ef955bb34d75e49d19c6a69024acf/ash/display/json_converter.h
[modify] https://crrev.com/9a5d265ee2cc632d0c6c6ee7bcef12c2482d5bf4/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/9a5d265ee2cc632d0c6c6ee7bcef12c2482d5bf4/chrome/browser/chromeos/display/display_preferences.cc
[modify] https://crrev.com/9a5d265ee2cc632d0c6c6ee7bcef12c2482d5bf4/chrome/browser/chromeos/display/display_preferences_unittest.cc
[modify] https://crrev.com/9a5d265ee2cc632d0c6c6ee7bcef12c2482d5bf4/ui/display/BUILD.gn
[modify] https://crrev.com/9a5d265ee2cc632d0c6c6ee7bcef12c2482d5bf4/ui/display/manager/BUILD.gn
[rename] https://crrev.com/9a5d265ee2cc632d0c6c6ee7bcef12c2482d5bf4/ui/display/manager/display_pref_util.h
[rename] https://crrev.com/9a5d265ee2cc632d0c6c6ee7bcef12c2482d5bf4/ui/display/manager/json_converter.cc
[add] https://crrev.com/9a5d265ee2cc632d0c6c6ee7bcef12c2482d5bf4/ui/display/manager/json_converter.h
[rename] https://crrev.com/9a5d265ee2cc632d0c6c6ee7bcef12c2482d5bf4/ui/display/manager/json_converter_unittest.cc

 Issue 705091  has been merged into this issue.

You'll want to make sure whatever is done with mushrome too. I'm adding some early outs for mushome referencing this bug.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a

commit 494c6cbdea529cc6aa1e4e344bdc732d61d91d3a
Author: sky <sky@chromium.org>
Date: Mon Mar 27 20:57:48 2017

Gets chrome --mus some what working

This makes chrome work in --mus mode. It comes up and displays stuff,
but I have no doubt a bunch of stuff doesn't work.

BUG= 704985 , 705592 , 705595 , 705591 , 678949 
TEST=none
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2777223002
Cr-Commit-Position: refs/heads/master@{#459875}

[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/common/wm_shell.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/window_manager.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/window_manager.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/mus/window_manager_application.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/public/cpp/BUILD.gn
[add] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/public/cpp/config.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/shell.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/shell.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ash/test/ash_test_helper.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/ash_config.cc
[add] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/ash_config.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_init.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_util.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/ash_util.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/chrome/browser/ui/views/frame/native_browser_frame_factory_chromeos.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/494c6cbdea529cc6aa1e4e344bdc732d61d91d3a/ui/aura/mus/window_tree_client.h

 Issue 686835  has been merged into this issue.

Is this still in active development?

I was going to move display_preferences.cc to src/ash/display because it didn't look like we had any real chrome dependencies, but it turns out components/user_manager is not actually available to ash so we need an alternative to UserCanSaveDisplayPreference() and we need to re-factor display_preferences_unittest.cc to not use Usermanager.

I'm not sure if we should tack that effort on to this issue or start a new one.

The motivation for this effort is to eliminate ChromeShellDelegate::PreInit() and ChromeShellDelegate::PreShutdown().

We need a new owner for this bug.

I can likely take this on at some point, but I have a number of other mushrome related tasks that need to be completed first.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7683e34474cc8e417f142a1d4369da80d660e7e0

commit 7683e34474cc8e417f142a1d4369da80d660e7e0
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jan 03 18:14:22 2018

Shell: Move DisplayManager initialization to a separate method

This CL:
* Moves a bunch of related DisplayManager and DisplayConfigurator
  code to a separate InitializeDisplayManager method to help improve
  managability of Shell::Init.
* Renames ShutdownObserver -> DisplayShutdownObserver.
* Removes unnecessary DBusThreadManager dependencies from shell.cc.
* Moves observer responsibility from Shell to ProjectingObserver

Bug:  678949 
Change-Id: I07159d0562bc032f03c653beb927ab8aaf053bbc
Reviewed-on: https://chromium-review.googlesource.com/833500
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526741}
[modify] https://crrev.com/7683e34474cc8e417f142a1d4369da80d660e7e0/ash/BUILD.gn
[rename] https://crrev.com/7683e34474cc8e417f142a1d4369da80d660e7e0/ash/display/display_shutdown_observer.cc
[rename] https://crrev.com/7683e34474cc8e417f142a1d4369da80d660e7e0/ash/display/display_shutdown_observer.h
[modify] https://crrev.com/7683e34474cc8e417f142a1d4369da80d660e7e0/ash/display/projecting_observer_chromeos.cc
[modify] https://crrev.com/7683e34474cc8e417f142a1d4369da80d660e7e0/ash/display/projecting_observer_chromeos.h
[modify] https://crrev.com/7683e34474cc8e417f142a1d4369da80d660e7e0/ash/display/projecting_observer_chromeos_unittest.cc
[modify] https://crrev.com/7683e34474cc8e417f142a1d4369da80d660e7e0/ash/shell.cc
[modify] https://crrev.com/7683e34474cc8e417f142a1d4369da80d660e7e0/ash/shell.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61e6625f05c73d0a4b7259cdb4cc1e314bd1935a

commit 61e6625f05c73d0a4b7259cdb4cc1e314bd1935a
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jan 04 17:50:43 2018

Add Guest support to AshTestBase

This includes some minor cleanup in preparation for moving
display_preferences.cc to src/ash.

Bug:  678949 
Change-Id: Ieed43321057f720923903550122a9236e0bd930d
Reviewed-on: https://chromium-review.googlesource.com/849303
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527032}
[modify] https://crrev.com/61e6625f05c73d0a4b7259cdb4cc1e314bd1935a/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/61e6625f05c73d0a4b7259cdb4cc1e314bd1935a/ash/test/ash_test_base.cc
[modify] https://crrev.com/61e6625f05c73d0a4b7259cdb4cc1e314bd1935a/ash/test/ash_test_base.h
[modify] https://crrev.com/61e6625f05c73d0a4b7259cdb4cc1e314bd1935a/ash/wallpaper/wallpaper_controller_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03e8c4238c96d15283d5673ff934518579586c3c

commit 03e8c4238c96d15283d5673ff934518579586c3c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Sat Jan 06 00:20:39 2018

Move display_preferences.cc functions to DisplayPrefs class

Moves the code in display_preferences.cc to a new class DisplayPrefs.

This is in preparation for moving DisplayPrefs to Ash.

Bug:  678949 
Change-Id: Ifed8bb885280e159bcb05ce637319fd8a2210fd4
Reviewed-on: https://chromium-review.googlesource.com/850841
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527449}
[modify] https://crrev.com/03e8c4238c96d15283d5673ff934518579586c3c/ash/display/resolution_notification_controller.h
[modify] https://crrev.com/03e8c4238c96d15283d5673ff934518579586c3c/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/03e8c4238c96d15283d5673ff934518579586c3c/chrome/browser/chromeos/display/display_configuration_observer.cc
[delete] https://crrev.com/47cad529403cf8483a616d6f24cc8d3ae287b277/chrome/browser/chromeos/display/display_preferences.h
[rename] https://crrev.com/03e8c4238c96d15283d5673ff934518579586c3c/chrome/browser/chromeos/display/display_prefs.cc
[add] https://crrev.com/03e8c4238c96d15283d5673ff934518579586c3c/chrome/browser/chromeos/display/display_prefs.h
[rename] https://crrev.com/03e8c4238c96d15283d5673ff934518579586c3c/chrome/browser/chromeos/display/display_prefs_unittest.cc
[modify] https://crrev.com/03e8c4238c96d15283d5673ff934518579586c3c/chrome/browser/extensions/display_info_provider_chromeos.cc
[modify] https://crrev.com/03e8c4238c96d15283d5673ff934518579586c3c/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/03e8c4238c96d15283d5673ff934518579586c3c/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/03e8c4238c96d15283d5673ff934518579586c3c/chrome/browser/ui/ash/chrome_shell_delegate.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73ae030543e2bc8d8ceb8841772b754c8caeb17b

commit 73ae030543e2bc8d8ceb8841772b754c8caeb17b
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Jan 08 20:10:31 2018

Move DisplayPrefs to Ash

Moves DisplayPrefs ownership to ash::Shell. DisplayPrefs is
asynchronously initialized when local state is loaded.

For minor chromeos speciifc change to display_info_provider_chromeos.cc
and browser_prefs.cc:
TBR=rdevlin.cronin@chromium.org, gab@chromium.org

Bug:  678949 
Change-Id: I5cf855e41ca14458031d05750dcc14c7405458b5
Reviewed-on: https://chromium-review.googlesource.com/849633
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527727}
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/ash/BUILD.gn
[rename] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/ash/display/display_prefs.cc
[add] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/ash/display/display_prefs.h
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/ash/display/resolution_notification_controller.h
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/ash/public/cpp/ash_pref_names.h
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/ash/shell.cc
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/ash/shell.h
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/chrome/browser/chromeos/display/display_configuration_observer.cc
[delete] https://crrev.com/a82067c9a80fb3db0e3067467f6fd221b54f68da/chrome/browser/chromeos/display/display_prefs.h
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/chrome/browser/chromeos/display/display_prefs_unittest.cc
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/chrome/browser/extensions/display_info_provider_chromeos.cc
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/chrome/common/pref_names.cc
[modify] https://crrev.com/73ae030543e2bc8d8ceb8841772b754c8caeb17b/chrome/common/pref_names.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82883de16585b6392c08459e49c977da65083a3c

commit 82883de16585b6392c08459e49c977da65083a3c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jan 10 00:02:51 2018

Move DisplayConfigurationObserver ownership to Shell

This CL also:
* Removes ShellDelegate::PreShutdown which is no longer
  needed for anything.
* Moves display_prefs_unittest.cc to src/ash now that it no longer
  depends on display_configuration_observer.
* Adds AshTestHelper::DisableTabletMirrorModeForTest() to work around
  tests that do not expect a DisplayConfigurationObserver instance to
  be running.

For minor change to display_info_provider_chromeos_unittest.cc:
TBR=benwells@chromium.org

Bug:  678949 
Change-Id: I9c35eea4cdf6c832e78f17d9c3fb0762f134d8e5
Reviewed-on: https://chromium-review.googlesource.com/851120
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528174}
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/BUILD.gn
[rename] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/display/display_configuration_observer.cc
[rename] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/display/display_configuration_observer.h
[rename] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/display/display_prefs_unittest.cc
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/shell.cc
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/shell.h
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/shell_delegate.h
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/shell_delegate_mus.cc
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/shell_delegate_mus.h
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/system/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/test/ash_test_helper.cc
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/test/ash_test_helper.h
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/test_shell_delegate.cc
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/test_shell_delegate.h
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/82883de16585b6392c08459e49c977da65083a3c/chrome/browser/ui/ash/chrome_shell_delegate.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7614ab5c95de4ceef0a4dab7d052f9ff56593a13

commit 7614ab5c95de4ceef0a4dab7d052f9ff56593a13
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 12 20:48:17 2018

Revert "Move DisplayConfigurationObserver ownership to Shell"

This reverts commit 82883de16585b6392c08459e49c977da65083a3c.

Reason for revert: Dependent on http://crrev.com/c/849633 which
needs to be reverted because of:
*  http://crbug.com/801394 
*  http://crbug.com/800925 


Original change's description:
> Move DisplayConfigurationObserver ownership to Shell
> 
> This CL also:
> * Removes ShellDelegate::PreShutdown which is no longer
>   needed for anything.
> * Moves display_prefs_unittest.cc to src/ash now that it no longer
>   depends on display_configuration_observer.
> * Adds AshTestHelper::DisableTabletMirrorModeForTest() to work around
>   tests that do not expect a DisplayConfigurationObserver instance to
>   be running.
> 
> For minor change to display_info_provider_chromeos_unittest.cc:
> TBR=benwells@chromium.org
> 
> Bug:  678949 
> Change-Id: I9c35eea4cdf6c832e78f17d9c3fb0762f134d8e5
> Reviewed-on: https://chromium-review.googlesource.com/851120
> Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#528174}

TBR=stevenjb@chromium.org,oshima@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  678949 
Change-Id: I78c94ddd13abbfcb0d556f0b3abbbcdb2a188951
Reviewed-on: https://chromium-review.googlesource.com/865234
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529056}
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/BUILD.gn
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/shell.cc
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/shell.h
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/shell_delegate.h
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/shell_delegate_mus.cc
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/shell_delegate_mus.h
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/system/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/test/ash_test_helper.cc
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/test/ash_test_helper.h
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/test_shell_delegate.cc
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/test_shell_delegate.h
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/chrome/browser/chromeos/BUILD.gn
[rename] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/chrome/browser/chromeos/display/display_configuration_observer.cc
[rename] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/chrome/browser/chromeos/display/display_configuration_observer.h
[rename] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/chrome/browser/chromeos/display/display_prefs_unittest.cc
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/7614ab5c95de4ceef0a4dab7d052f9ff56593a13/chrome/browser/ui/ash/chrome_shell_delegate.h

The changes were reverted because of:
*  http://crbug.com/801394 
*  http://crbug.com/800925 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cce939193584dd35fc2f5ab03cec7c7c5933df78

commit cce939193584dd35fc2f5ab03cec7c7c5933df78
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 12 22:57:12 2018

Revert "Move DisplayPrefs to Ash"

This reverts commit 73ae030543e2bc8d8ceb8841772b754c8caeb17b.

Reason for revert:
*  http://crbug.com/801394 
*  http://crbug.com/800925 

Original change's description:
> Move DisplayPrefs to Ash
> 
> Moves DisplayPrefs ownership to ash::Shell. DisplayPrefs is
> asynchronously initialized when local state is loaded.
> 
> For minor chromeos speciifc change to display_info_provider_chromeos.cc
> and browser_prefs.cc:
> TBR=rdevlin.cronin@chromium.org, gab@chromium.org
> 
> Bug:  678949 
> Change-Id: I5cf855e41ca14458031d05750dcc14c7405458b5
> Reviewed-on: https://chromium-review.googlesource.com/849633
> Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#527727}

TBR=xiyuan@chromium.org,stevenjb@chromium.org,oshima@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  678949 
Change-Id: I68913723e32f4f95fdd7a6fcc592ce819a287c83
Reviewed-on: https://chromium-review.googlesource.com/864561
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529097}
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/ash/BUILD.gn
[delete] https://crrev.com/194f8057ef72d82156c394bd6235904ed4d2cfd6/ash/display/display_prefs.h
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/ash/display/resolution_notification_controller.h
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/ash/public/cpp/ash_pref_names.h
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/ash/shell.cc
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/ash/shell.h
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/chrome/browser/chromeos/display/display_configuration_observer.cc
[rename] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/chrome/browser/chromeos/display/display_prefs.cc
[add] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/chrome/browser/chromeos/display/display_prefs.h
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/chrome/browser/chromeos/display/display_prefs_unittest.cc
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/chrome/browser/extensions/display_info_provider_chromeos.cc
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/chrome/common/pref_names.cc
[modify] https://crrev.com/cce939193584dd35fc2f5ab03cec7c7c5933df78/chrome/common/pref_names.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1b13b8085749b31e8c2015a2ba1552f2e2db121

commit e1b13b8085749b31e8c2015a2ba1552f2e2db121
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Apr 02 15:51:00 2018

Elim ash::Shell::GetLocalStatePrefService

In mash, Shell::local_state_ is loaded asynchronously. Components
that require access to local state should implement
ShellObserver::OnLocalStatePrefServiceInitialized.

Bug:  678949 
Change-Id: I72917db3f83f56335333a3e7b40210c289f58a0c
Reviewed-on: https://chromium-review.googlesource.com/988213
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547440}
[modify] https://crrev.com/e1b13b8085749b31e8c2015a2ba1552f2e2db121/ash/shell.cc
[modify] https://crrev.com/e1b13b8085749b31e8c2015a2ba1552f2e2db121/ash/shell.h
[modify] https://crrev.com/e1b13b8085749b31e8c2015a2ba1552f2e2db121/ash/shell_unittest.cc
[modify] https://crrev.com/e1b13b8085749b31e8c2015a2ba1552f2e2db121/ash/system/bluetooth/bluetooth_power_controller_unittest.cc
[modify] https://crrev.com/e1b13b8085749b31e8c2015a2ba1552f2e2db121/ash/system/palette/palette_tray_unittest.cc
[modify] https://crrev.com/e1b13b8085749b31e8c2015a2ba1552f2e2db121/ash/test/ash_test_helper.cc
[modify] https://crrev.com/e1b13b8085749b31e8c2015a2ba1552f2e2db121/ash/test/ash_test_helper.h
[modify] https://crrev.com/e1b13b8085749b31e8c2015a2ba1552f2e2db121/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/e1b13b8085749b31e8c2015a2ba1552f2e2db121/ash/wallpaper/wallpaper_controller.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f575875971dda68bf2f9159d9f0b26ba117f4a2

commit 7f575875971dda68bf2f9159d9f0b26ba117f4a2
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Apr 06 19:13:12 2018

DisplayPrefs cleanup

This removes display_pref_util.h and simplifies some code.

Bug:  678949 
Change-Id: I4e6d805a2fdec4b3f05dd64dbf183ed569ae1eb4
Reviewed-on: https://chromium-review.googlesource.com/994412
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548885}
[modify] https://crrev.com/7f575875971dda68bf2f9159d9f0b26ba117f4a2/chrome/browser/chromeos/display/display_prefs.cc
[modify] https://crrev.com/7f575875971dda68bf2f9159d9f0b26ba117f4a2/ui/display/manager/BUILD.gn
[delete] https://crrev.com/82b06e01667e7a0136ae23091e49c5da2bca37f8/ui/display/manager/display_pref_util.h
[modify] https://crrev.com/7f575875971dda68bf2f9159d9f0b26ba117f4a2/ui/display/manager/json_converter.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1640a22d32ea33993889c00b48a64b71770c180

commit c1640a22d32ea33993889c00b48a64b71770c180
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Apr 10 00:30:41 2018

DisplayConfigurator: Support async initial power state

In order to move DisplayPrefs to src/ash (necessary for mustash)
we need DisplayConfigurator to support asynchronous setting of
the initial power state since prefs are loaded asynchronously
in ash.

Bug:  678949 
Change-Id: I404c63ce7fdab27eee45d30e44b41cc1fcf0d357
Reviewed-on: https://chromium-review.googlesource.com/994282
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549346}
[modify] https://crrev.com/c1640a22d32ea33993889c00b48a64b71770c180/chrome/browser/chromeos/display/display_prefs.cc
[modify] https://crrev.com/c1640a22d32ea33993889c00b48a64b71770c180/chrome/browser/chromeos/display/display_prefs_unittest.cc
[modify] https://crrev.com/c1640a22d32ea33993889c00b48a64b71770c180/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/c1640a22d32ea33993889c00b48a64b71770c180/ui/display/manager/chromeos/display_configurator.cc
[modify] https://crrev.com/c1640a22d32ea33993889c00b48a64b71770c180/ui/display/manager/chromeos/display_configurator.h
[modify] https://crrev.com/c1640a22d32ea33993889c00b48a64b71770c180/ui/display/manager/chromeos/display_configurator_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3688c6039d109aa4a258195545e93bf7e71959c6

commit 3688c6039d109aa4a258195545e93bf7e71959c6
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Apr 13 01:14:23 2018

Move DisplayPrefs to Ash

This CL:
* Moves pref names used by DisplayPrefs to ash_pref_names.cc
* Moves DisplayPrefs to src/ash
* Moves ownership of DisplayPrefs to ash::Shell.

NOTE: This change causes DisplayConfigurator::SetInitialDisplayPower
to be called asynchronously when OnLocalStatePrefServiceInitialized
is called. Support for this was added in crrev.com/c/994282.

NOTE: This does not move display_prefs_unittest.cc because of a
dependency on DisplayConfigurationObserver which needs to be moved
separately because it breaks a number of ash_unittests expectations.
See  crbug.com/831379  for details.

For trivial code removal from browser_prefs:
TBR=bauerb@chromium.org

Bug:  678949 
Change-Id: I078a0f52a38f493d592c92b291c53d6815ccf336
Reviewed-on: https://chromium-review.googlesource.com/1003379
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550457}
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/BUILD.gn
[rename] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/display/display_prefs.cc
[add] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/display/display_prefs.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/display/resolution_notification_controller.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/public/cpp/ash_pref_names.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/shell.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/shell.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/chromeos/display/display_configuration_observer.cc
[delete] https://crrev.com/08a808524398fc77e1cdedb597e605f0a957301a/chrome/browser/chromeos/display/display_prefs.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/chromeos/display/display_prefs_unittest.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/extensions/system_display/display_info_provider_chromeos.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/common/pref_names.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/common/pref_names.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ui/display/manager/chromeos/display_configurator.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3688c6039d109aa4a258195545e93bf7e71959c6

commit 3688c6039d109aa4a258195545e93bf7e71959c6
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Apr 13 01:14:23 2018

Move DisplayPrefs to Ash

This CL:
* Moves pref names used by DisplayPrefs to ash_pref_names.cc
* Moves DisplayPrefs to src/ash
* Moves ownership of DisplayPrefs to ash::Shell.

NOTE: This change causes DisplayConfigurator::SetInitialDisplayPower
to be called asynchronously when OnLocalStatePrefServiceInitialized
is called. Support for this was added in crrev.com/c/994282.

NOTE: This does not move display_prefs_unittest.cc because of a
dependency on DisplayConfigurationObserver which needs to be moved
separately because it breaks a number of ash_unittests expectations.
See  crbug.com/831379  for details.

For trivial code removal from browser_prefs:
TBR=bauerb@chromium.org

Bug:  678949 
Change-Id: I078a0f52a38f493d592c92b291c53d6815ccf336
Reviewed-on: https://chromium-review.googlesource.com/1003379
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550457}
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/BUILD.gn
[rename] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/display/display_prefs.cc
[add] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/display/display_prefs.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/display/resolution_notification_controller.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/public/cpp/ash_pref_names.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/shell.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ash/shell.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/chromeos/display/display_configuration_observer.cc
[delete] https://crrev.com/08a808524398fc77e1cdedb597e605f0a957301a/chrome/browser/chromeos/display/display_prefs.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/chromeos/display/display_prefs_unittest.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/extensions/system_display/display_info_provider_chromeos.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/common/pref_names.cc
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/common/pref_names.h
[modify] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/ui/display/manager/chromeos/display_configurator.h