Media artwork flickers when switching src |
||
Issue descriptionThis is due to the session goes uncontrollable and controllable again, causing a signal for resetting metadata & controls to null to be sent. MediaSessionTabHelper keeps the notification showing for a few seconds thus the artwork is reset to the default image. This signal is unnecessary and safe to remove, since the metadata & controls will be sent another time if the session goes controllable again.
,
Jan 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f64ef58c0294ed6ad7468c9ca7155a6e4430d8f1 commit f64ef58c0294ed6ad7468c9ca7155a6e4430d8f1 Author: zqzhang <zqzhang@chromium.org> Date: Tue Jan 10 22:17:44 2017 [MediaSession] Don't reset metadata and actions when the session goes uncontrollable When switching media element src, MediaSession goes uncontrollable and then controllable. The current MediaSession routing algorithm resets metadata and controls when the session goes uncontrollable. However this resetting is unnecessary but will cause notification flickering as well. This CL removes the unnecessary reset signal. BUG= 678945 Review-Url: https://codereview.chromium.org/2612293003 Cr-Commit-Position: refs/heads/master@{#442708} [modify] https://crrev.com/f64ef58c0294ed6ad7468c9ca7155a6e4430d8f1/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/f64ef58c0294ed6ad7468c9ca7155a6e4430d8f1/content/browser/media/session/media_session_impl_browsertest.cc [modify] https://crrev.com/f64ef58c0294ed6ad7468c9ca7155a6e4430d8f1/content/browser/media/session/media_session_impl_service_routing_unittest.cc [add] https://crrev.com/f64ef58c0294ed6ad7468c9ca7155a6e4430d8f1/content/browser/media/session/mock_media_session_observer.cc [add] https://crrev.com/f64ef58c0294ed6ad7468c9ca7155a6e4430d8f1/content/browser/media/session/mock_media_session_observer.h [modify] https://crrev.com/f64ef58c0294ed6ad7468c9ca7155a6e4430d8f1/content/test/BUILD.gn
,
Jan 11 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mlamouri@chromium.org
, Jan 6 2017