New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678939 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Unable to do a cit restart on chromium.perf

Project Member Reported by eyaich@chromium.org, Jan 6 2017

Issue description

In the past I have done several restarts without a problem but for the last month when I try and do it restart: 

cit restart -m 0 -b 672855 chromium.perf

I get the following output: 

eyaich@snowshoe:~/projects/chromium/src$ cit restart -m 0 -b 672855 chromium.perf
Cloning into '/tmp/tmpXt60Zb'...
remote: Total 5976 (delta 2307), reused 5976 (delta 2307)
Receiving objects: 100% (5976/5976), 3.06 MiB | 0 bytes/s, done.
Resolving deltas: 100% (2307/2307), done.
Please provide a reason for this restart [Restart for https://crbug.com/672855]: Upgrading Mac 10.10
[master 70e89e4] Restarting master chromium.perf
 1 file changed, 2 insertions(+), 2 deletions(-)

Actions for the following masters:
	- Restarting chromium.perf in 0 minutes (UTC: 2017-01-06T14:02:16.086587Z, Local: 2017-01-06 09:02:16.086587-05:00)

This will upload a CL for master_manager.git, TBR an owner, and 
commit the CL through the CQ.

Commit? [Y/n]: Y
To cancel, edit desired_master_state.json in https://chrome-internal.googlesource.com/infradata/master-manager.

Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit upload checks ...

Presubmit checks passed.
 desired_master_state.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Adding self-LGTM (Code-Review +1) because of TBRs
remote: Processing changes: refs: 1, done            
To https://chrome-internal.googlesource.com/infradata/master-manager
 ! [remote rejected] 7cc586b5b6836c273e8400a60a0efbd3d6aa1135 -> refs/for/refs/heads/master%l=Code-Review+1,m=Initial_upload,notify=NONE,r=glider@chromium.org (user "glider@chromium.org" not found)
error: failed to push some refs to 'https://chrome-internal.googlesource.com/infradata/master-manager'
Failed to create a change. Please examine output above for the reason of the failure. 
Traceback (most recent call last):
  File "/usr/local/google/home/eyaich/.chrome-infra/infra/run.py", line 29, in <module>
    sys.exit(run_helper.run_py_main(sys.argv[1:], RUNPY_PATH, ENV_PATH, 'infra'))
  File "/usr/local/google/home/eyaich/.chrome-infra/infra/bootstrap/run_helper.py", line 125, in run_py_main
    runpy.run_module(args[0], run_name='__main__', alter_sys=True)
  File "/usr/lib/python2.7/runpy.py", line 176, in run_module
    fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 82, in _run_module_code
    mod_name, mod_fname, mod_loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/local/google/home/eyaich/.chrome-infra/infra/infra/tools/restart/__main__.py", line 49, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/eyaich/.chrome-infra/infra/infra/tools/restart/__main__.py", line 45, in main
    args.no_commit, args.desired_state, args.reason)
  File "/usr/local/google/home/eyaich/.chrome-infra/infra/infra/tools/restart/restart.py", line 422, in run
    desired_state, reason)
  File "/usr/local/google/home/eyaich/.chrome-infra/infra/infra/tools/restart/restart.py", line 322, in commit
    subprocess.check_call(upload_cmd, cwd=target)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'cl', 'upload', '-m', 'Restarting master chromium.perf\n\nUpgrading Mac 10.10\n\nBUG=672855', '-f', '--tbr-owners', '-c']' returned non-zero exit status 1

 
Owner: martiniss@chromium.org
Stephen do you know who the right person to route this to would be?  I remember having this same problem back in early December and you had to do the restart for me.  
Owner: stip@chromium.org
Status: Assigned (was: Untriaged)
Huh.... I think stip owns that. Not sure why that happens.

Comment 3 by stip@chromium.org, Jan 6 2017

Cc: stip@chromium.org
Components: Infra>Git
Owner: ----
Status: Available (was: Assigned)
master manager has hit a lot of weird git issues lately. I wonder if someone from git-land can help out?
glider@chromium.org has never signed in to gerrit, and so doesn't have an account, and so can't be made a reviewer.

Possible fixes include:
* Getting glider@ to sign in
* Manually creating an account for them
* Teaching 'cit restart' to pick a different owner and retry if it hits the case
(P.S. I'm not sure why @chromium.org addresses are in the OWNERS file for an internal repository.)
Labels: Pri-2
If this is really a Pri-1, find an owner and update the priority.

This is the result of a bulk edit that moved high priority available bugs to a lower priority in an attempt to be more honest with bug filers.

Comment 7 by stip@chromium.org, Feb 10 2017

Cc: -stip@chromium.org
Project Member

Comment 8 by sheriffbot@chromium.org, Feb 15 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -eyaich@chromium.org
Components: Infra>Platform
+Platform - I don't know anything about master restarts, thoughts on how to re-triage this bug? I kind of suspect this is about to be obsolete given the LUCI migration. 
Status: WontFix (was: Untriaged)
This is also so old we don't need to do the restart.

Sign in to add a comment