New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 678918 link

Starred by 2 users
Status: Fixed
Owner:
schenney@chromium.org
Closed: Jan 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
hcarmona@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 671375



Sign in to add a comment

Regression: Focus on 'x' icon is not properly seen on chrome://md-settings/passwords

Reported by jshan...@etouch.net, Jan 6 2017 
Chrome Version:	57.0.2973.0 (Official Build)287e86e1c12c26ad850476f1410f2002b0521c8a-refs/heads/master@{#441616}-32/64 bit
OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LT)

Steps:
1. Launch Chrome, sign in to gmail with valid credential and click on 'Never' of password permission bubble.
2. Now navigate to chrome://md-settings/passwords and press tab key until focus is on 'x' icon.
3. Observe.

Actual: Focus on 'x' icon is not properly seen.

Expected: Focus on 'x' icon should be properly seen.

This is a Regression issue broken in M-57,will soon update other info.

Good build:57.0.2972.0
Bad build:57.0.2973.0
Actual_result.jpg
64.6 KB View Download
Actual_video.mp4
1.5 MB View Download

Comment 1 by jshan...@etouch.net, Jan 6 2017

Summary: Regression: Focus on 'x' icon is not properly seen on chrome://md-settings/passwords (was: Regression: Focus on 'x' icon is not properly seen on Focus on 'x' icon is not properly seen..)

Comment 2 by msrchandra@chromium.org, Jan 6 2017

Labels: hasbisect-per-revision
Owner: schenney@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 57.0.2972.0 (Revision: 441559).
Bad build: 57.0.2973.0 (Revision: 441616).

You are probably looking for a change made after 441591 (known good), but no later than 441592 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/cd8243b3c7f369202cffc7afcc2e75338de3da92..d3ba7664a7ebc6e74861602eb9696c7ca0a4ed2e

@schenney -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.

Comment 3 by schenney@chromium.org, Jan 6 2017 

It's probably my patch but given the importance of the bug it fixes I'd
rather look at CV fixing this issue separately rather than reverting.

I'll get to it Monday.

Comment 4 by tbuck...@chromium.org, Jan 6 2017

Blocking: 671375
Cc: hcarmona@chromium.org
Labels: Hotlist-MD-Settings-PageA11y
We've always had issues with the ripple being cut off ( Issue 619777 ), but I haven't seen it scaled horizontally like that before.

Comment 5 by sureshkumari@chromium.org, Jan 16 2017 

Friendly ping to get an update on this issue.

Comment 6 by hcarmona@chromium.org, Jan 17 2017 

Is this still reproducible? I'm not seeing it happen on canary on mac anymore.
Screen Shot 2017-01-17 at 10.14.57 AM.png
24.7 KB View Download

Comment 7 by schenney@chromium.org, Jan 17 2017

Status: Fixed (was: Assigned)
I can't repro ToT on linux, and in M56 Beta I see the circle cropped to have straight left and right sides. And no repro on Win 10 Canary. So everything seems to be working fine.

I suspect that the focus was originally being cropped, then it was being rescaled to the formerly cropped width, and now the width is right and it looks right.
►

Sign in to add a comment