New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
link

Issue 678905: ☔ Tests in LayoutTests/external/wpt/service-workers/service-worker should pass. ☔

Reported by falken@chromium.org, Jan 6 2017 Project Member

Issue description

We should get all the tests in /src/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker passing.

Here is how to run the tests:
1. Build blink_tests:
$ ninja -C out/Default -j 400 blink_tests
2. Run the tests with run-webkit-tests:
$ ./third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default --enable-wptserve external/wpt/service-workers/service-worker/

--enable-wptserve is still needed until  issue 618366  is fixed.

We can ignore the "passed unexpectedly" failures, I think that's just a byproduct of  issue 618366  being worked on (the test expectations are written for the case where --enable- wptserve is not used).

The test expectations are in two places:
- LayoutTests/TestExpectations
- In "*expected.txt" files in the test directory itself. For example, controller-on-disconnect.https-expected.txt

Basically the goal should be to remove all the "*expected.txt" files. When a test passes normally, it doesn't need an expected.txt file. If you open the expected.txt files, you'll see they have lines like FAIL which indicate the failure. For example:
$ cat controller-on-load.https-expected.txt
This is a testharness.js-based test.
FAIL controller is set for a controlled document Cannot read property 'active' of undefined
Harness: the test ran to completion.
 

Comment 1 by yiyix@chromium.org, Jan 13 2017

Owner: yiyix@chromium.org
Status: Started (was: Assigned)

Comment 2 by yiyix@chromium.org, Jan 13 2017

Cc: falken@chromium.org

Comment 3 by shimazu@chromium.org, Jan 16 2017

Cc: horo@chromium.org nhiroki@chromium.org qyears...@chromium.org shimazu@chromium.org
 Issue 658997  has been merged into this issue.

Comment 4 by falken@chromium.org, Jan 18 2017

Blockedon: 682065

Comment 5 by falken@chromium.org, Jan 24 2017

Summary: Tests in LayoutTests/external/wpt/service-workers/service-worker should pass. (was: Tests in LayoutTests/imported/wpt/service-workers/service-worker should pass.)
Updating path (imported -> external).

Comment 6 by falken@chromium.org, Jan 24 2017

Description: Show this description

Comment 7 by falken@chromium.org, Jan 26 2017

Blockedon: 685531

Comment 8 by falken@chromium.org, Feb 10 2017

Blockedon: 658997

Comment 9 by falken@chromium.org, Feb 13 2017

Blockedon: 691008

Comment 10 by falken@chromium.org, Feb 14 2017

Blockedon: 691944

Comment 11 by bugdroid1@chromium.org, Feb 14 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bcd0bfa180b2e322722679439cfd9e0eba6ec3f

commit 4bcd0bfa180b2e322722679439cfd9e0eba6ec3f
Author: falken <falken@chromium.org>
Date: Tue Feb 14 09:05:10 2017

Gardening: Update some TestExpectations for service worker WPT tests

BUG=678905
TBR=shimazu
NOTRY=true

Review-Url: https://codereview.chromium.org/2689413002
Cr-Commit-Position: refs/heads/master@{#450298}

[modify] https://crrev.com/4bcd0bfa180b2e322722679439cfd9e0eba6ec3f/third_party/WebKit/LayoutTests/TestExpectations

Comment 12 by falken@chromium.org, Feb 14 2017

Blockedon: 688486

Comment 13 by yiyix@chromium.org, Feb 22 2017

Cc: yiyix@chromium.org
Owner: ----

Comment 14 by falken@chromium.org, Mar 17 2017

Blockedon: 702352

Comment 15 by falken@chromium.org, Mar 17 2017

Blockedon: 702361

Comment 16 by falken@chromium.org, Mar 29 2017

Owner: yiyix@chromium.org

Comment 17 by falken@chromium.org, Mar 31 2017

Blockedon: 705685

Comment 18 by falken@chromium.org, Apr 18 2017

Blockedon: 701233

Comment 19 by falken@chromium.org, May 8 2017

Blockedon: 718935

Comment 20 by falken@chromium.org, May 8 2017

Blockedon: 719052

Comment 21 by falken@chromium.org, May 9 2017

Blockedon: 719850

Comment 22 by leon....@intel.com, May 9 2017

Cc: leon....@intel.com

Comment 23 by falken@chromium.org, May 10 2017

Owner: ----
Status: Available (was: Started)
Summary: ☔ Tests in LayoutTests/external/wpt/service-workers/service-worker should pass. ☔ (was: Tests in LayoutTests/external/wpt/service-workers/service-worker should pass.)
As this has become a broad umbrella bug I think this doesn't need a specific owner.

Comment 24 by falken@chromium.org, May 17 2017

Blockedon: 723037

Comment 25 by falken@chromium.org, May 19 2017

Blockedon: 595993

Comment 26 by leon....@intel.com, May 19 2017

Blockedon: 724371

Comment 27 by bugdroid1@chromium.org, May 19 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a736f232d37141444b55fc6a3d36eb78f8c86ec

commit 9a736f232d37141444b55fc6a3d36eb78f8c86ec
Author: mike <mike@mikepennisi.com>
Date: Fri May 19 15:59:57 2017

Upstream service worker "timing" test to WPT

The version of this test in the Chromium source tree is equivalent to
the version available in the Web Platform Tests project. The WPT version
was previously marked as an expected failure because it constructed URLs
in terms of the HTTP protocol. This is correct within the Chromium
infrastructure (where the "secure context" requirement of the service
worker specification is satisfied by the use of the origin `127.0.0.1`),
but it is inappropriate for use within the WPT testing infrastructure
(where HTTPS is used to provide a secure context).

Correct the upstream version of the test, remove Chromium's "expected
failure" file, and remove the Chromium version of the test.

BUG= 688116 , 678905
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2895473002
Cr-Commit-Position: refs/heads/master@{#473206}

[delete] https://crrev.com/2c43ab991daa30205059b6d8a92a3857373061ff/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resource-timing.https-expected.txt
[modify] https://crrev.com/9a736f232d37141444b55fc6a3d36eb78f8c86ec/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resource-timing.https.html
[delete] https://crrev.com/2c43ab991daa30205059b6d8a92a3857373061ff/third_party/WebKit/LayoutTests/http/tests/serviceworker/resource-timing.html
[delete] https://crrev.com/2c43ab991daa30205059b6d8a92a3857373061ff/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/resource-timing-iframe.html
[delete] https://crrev.com/2c43ab991daa30205059b6d8a92a3857373061ff/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/resource-timing-worker.js

Comment 28 by falken@chromium.org, May 24 2017

Blockedon: 725616

Comment 29 by falken@chromium.org, May 29 2017

Blockedon: 602051

Comment 30 by xiaofeng...@intel.com, Jun 7 2017

Cc: xiaofeng...@intel.com

Comment 31 by leon....@intel.com, Jun 9 2017

Blockedon: 731599

Comment 32 by leon....@intel.com, Jun 9 2017

Blockedon: 731604

Comment 33 by falken@chromium.org, Jun 23 2017

Blockedon: 735883

Comment 34 by bugdroid1@chromium.org, Jun 23 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f99513209423e86f3b89ba9bf3d2b85c6b1f27c

commit 5f99513209423e86f3b89ba9bf3d2b85c6b1f27c
Author: Han Leon <leon.han@intel.com>
Date: Fri Jun 23 15:19:27 2017

[ServiceWorker] Fix wpt test claim-fetch.https.html

Only content of claim-fetch.https.html needs to be revised.

BUG=678905
TEST=blink_tests
external/wpt/service-workers/service-worker/claim-fetch.https.html

Change-Id: I0efb5298847bb69c0f29bc2dffb1fc51c5a02960
Reviewed-on: https://chromium-review.googlesource.com/544677
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481891}
[delete] https://crrev.com/0b780180db24e6b76ac8e433e8b02d8c1834667f/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/claim-fetch.https-expected.txt
[modify] https://crrev.com/5f99513209423e86f3b89ba9bf3d2b85c6b1f27c/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/claim-fetch.https.html

Comment 35 by bugdroid1@chromium.org, Jun 28 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78274dc0686b5bb494c00923dc6f9bd8fd1daa74

commit 78274dc0686b5bb494c00923dc6f9bd8fd1daa74
Author: Han Leon <leon.han@intel.com>
Date: Wed Jun 28 07:04:29 2017

[ServiceWorker] Clear controller attribute of ServiceWorkerContainer in time

This CL fixes the wpt test controller-on-disconnect.https.html by
clearing controller attribute of ServiceWorkerContainer when the
execution context is destroyed.

BUG=678905
TEST=blink_tests
external/wpt/service-workers/service-worker/controller-on-disconnect.https.html

Change-Id: I5e8250ae2a90f2fb28b127347340ea430b0ea5a6
Reviewed-on: https://chromium-review.googlesource.com/549587
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#482908}
[delete] https://crrev.com/afa076bcf93368cfd37ca5fa972ce2537eaa1cc7/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/controller-on-disconnect.https-expected.txt
[modify] https://crrev.com/78274dc0686b5bb494c00923dc6f9bd8fd1daa74/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

Comment 36 by leon....@intel.com, Jun 30 2017

Blockedon: 738336

Comment 37 by bugdroid1@chromium.org, Jul 19 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0fe92c5ed031281aa70e8598e03b538b73585a

commit 3f0fe92c5ed031281aa70e8598e03b538b73585a
Author: xiaofeng.zhang <xiaofeng.zhang@intel.com>
Date: Wed Jul 19 01:26:58 2017

[ServiceWorker] FetchEvent should returns integrity attribute

This patch is to pass the web-platform-test:fetch-request-resources.https.html.
Current failed cases(script_integrity_test and css_integrity_test) are caused
by integrity attribute data will not be returned in FetchEvent.

BUG= 718935 , 678905

Review-Url: https://codereview.chromium.org/2941883003
Cr-Commit-Position: refs/heads/master@{#487710}

[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/foreign_fetch_request_handler.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/foreign_fetch_request_handler.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/foreign_fetch_request_handler_unittest.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/link_header_support_unittest.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_request_handler.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_request_handler_unittest.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/child/web_url_request_util.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/child/web_url_request_util.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/common/resource_messages.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/common/service_worker/service_worker_fetch_request_struct_traits.cc
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/common/service_worker/service_worker_fetch_request_struct_traits.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/public/common/resource_request.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/content/renderer/service_worker/service_worker_context_client.cc
[delete] https://crrev.com/b23b23ecf4b942ef20299133947baaac267c61cd/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-resources.https-expected.txt
[delete] https://crrev.com/b23b23ecf4b942ef20299133947baaac267c61cd/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.fetch-request-resources.html
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/third_party/WebKit/Source/core/html/LinkStyle.cpp
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/third_party/WebKit/Source/modules/fetch/Request.cpp
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.cpp
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/third_party/WebKit/public/platform/WebURLRequest.h
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/third_party/WebKit/public/platform/modules/fetch/fetch_api_request.mojom
[modify] https://crrev.com/3f0fe92c5ed031281aa70e8598e03b538b73585a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h

Comment 38 by falken@chromium.org, Aug 2 2017

Blockedon: 745327

Comment 39 by falken@chromium.org, Aug 3 2017

Blockedon: 751959

Comment 40 by falken@chromium.org, Aug 25 2017

Blockedon: 758892

Comment 41 by falken@chromium.org, Sep 21 2017

Blockedon: 767606

Comment 42 by bugdroid1@chromium.org, Jan 10 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e2f14b2df9bae4df5006becbe81bb293ef69a35

commit 7e2f14b2df9bae4df5006becbe81bb293ef69a35
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Jan 10 02:10:42 2018

service worker: Opt in to notifications for WPT failures.

See https://groups.google.com/a/chromium.org/d/msg/blink-dev/B-vHX5Bys24/wpaTXIMIBwAJ

Bug: 678905
Change-Id: I12349cab86ec600e61e3488832ad1899953d6f98
Reviewed-on: https://chromium-review.googlesource.com/856477
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528214}
[modify] https://crrev.com/7e2f14b2df9bae4df5006becbe81bb293ef69a35/content/browser/service_worker/OWNERS
[modify] https://crrev.com/7e2f14b2df9bae4df5006becbe81bb293ef69a35/third_party/WebKit/LayoutTests/external/wpt/service-workers/OWNERS

Comment 43 by falken@chromium.org, Jan 24 2018

Blockedon: 805225

Comment 44 by falken@chromium.org, Jan 24 2018

Blockedon: 805246

Comment 45 by falken@chromium.org, Jan 30 2018

Blockedon: 807126

Comment 46 by falken@chromium.org, Feb 1 2018

Blockedon: 807818

Comment 47 by bugdroid1@chromium.org, Feb 1 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/039eb91a74c8002938f556fb1d7b7f2e08080a7a

commit 039eb91a74c8002938f556fb1d7b7f2e08080a7a
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Feb 01 16:42:17 2018

Gardening: service worker get clients tests are passing after WPT import

These started passing after https://github.com/w3c/web-platform-tests/commit/e5febc7
was imported in r533346.

TBR=shimazu

Bug: 626703, 678905
Change-Id: I1525f8a34ae060db9f0fc404a60f4e5a11ddee61
Reviewed-on: https://chromium-review.googlesource.com/897073
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533697}
[modify] https://crrev.com/039eb91a74c8002938f556fb1d7b7f2e08080a7a/third_party/WebKit/LayoutTests/TestExpectations

Comment 48 by falken@chromium.org, Feb 2 2018

Blockedon: 807720

Comment 49 by falken@chromium.org, Apr 6 2018

Blockedon: 829720

Comment 50 by falken@chromium.org, Apr 28 2018

Blockedon: 836217

Comment 51 by falken@chromium.org, May 11 2018

Blockedon: 834895

Comment 52 by falken@chromium.org, May 14 2018

Blockedon: 675540

Comment 53 by leonhsl@chromium.org, May 14 2018

Blockedon: 842587

Comment 54 by falken@chromium.org, Jun 8 2018

Blockedon: 847428

Comment 55 by falken@chromium.org, Jun 8 2018

Blockedon: 850825

Comment 56 by falken@chromium.org, Jun 8 2018

Blockedon: 831509

Comment 57 by falken@chromium.org, Jun 8 2018

Blockedon: 850842

Comment 58 by falken@chromium.org, Jun 12 2018

Blockedon: 617886

Comment 59 by falken@chromium.org, Jun 12 2018

Blockedon: 828857

Comment 60 by falken@chromium.org, Jun 19 2018

Blockedon: 854058

Comment 61 by falken@chromium.org, Jun 22 2018

Blockedon: 854913

Comment 62 by falken@chromium.org, Jul 20 2018

Blockedon: 865839

Comment 63 by falken@chromium.org, Aug 21

Blockedon: 876223

Comment 64 by falken@chromium.org, Aug 24

Blockedon: 877138

Comment 65 by falken@chromium.org, Aug 24

Blockedon: 877377

Comment 66 by falken@chromium.org, Oct 4

Blockedon: 889798

Comment 67 by falken@chromium.org, Oct 12

Blockedon: 894682

Comment 68 by shimazu@chromium.org, Oct 19

Blockedon: 895845

Comment 69 by falken@chromium.org, Oct 23

Blockedon: 868225

Comment 70 by falken@chromium.org, Oct 23

Cc: bashi@chromium.org worker-dev@chromium.org
 Issue 866965  has been merged into this issue.

Comment 71 by falken@chromium.org, Oct 23

Cc: -worker-dev@chromium.org

Comment 72 by falken@chromium.org, Dec 4

Blockedon: 911442

Comment 73 by falken@chromium.org, Dec 7

Blockedon: 911974

Comment 74 by domfarolino@gmail.com, Dec 13

Cc: domfarolino@gmail.com

Comment 75 by falken@chromium.org, Dec 14

Blockedon: 915140

Comment 76 by falken@chromium.org, Jan 23

Blockedon: 924448

Comment 77 by falken@chromium.org, Jan 28

Blockedon: 925740

Comment 78 by falken@chromium.org, Jan 30

Blockedon: 926670

Sign in to add a comment