We should get all the tests in /src/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker passing.
Here is how to run the tests:
1. Build blink_tests:
$ ninja -C out/Default -j 400 blink_tests
2. Run the tests with run-webkit-tests:
$ ./third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default --enable-wptserve imported/wpt/service-workers/service-worker/
--enable-wptserve is still needed until issue 618366 is fixed.
We can ignore the "passed unexpectedly" failures, I think that's just a byproduct of issue 618366 being worked on (the test expectations are written for the case where --enable- wptserve is not used).
The test expectations are in two places:
- LayoutTests/TestExpectations
- In "*expected.txt" files in the test directory itself. For example, controller-on-disconnect.https-expected.txt
Basically the goal should be to remove all the "*expected.txt" files. When a test passes normally, it doesn't need an expected.txt file. If you open the expected.txt files, you'll see they have lines like FAIL which indicate the failure. For example:
$ cat controller-on-load.https-expected.txt
This is a testharness.js-based test.
FAIL controller is set for a controlled document Cannot read property 'active' of undefined
Harness: the test ran to completion.
We should get all the tests in /src/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker passing.
Here is how to run the tests:
1. Build blink_tests:
$ ninja -C out/Default -j 400 blink_tests
2. Run the tests with run-webkit-tests:
$ ./third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default --enable-wptserve external/wpt/service-workers/service-worker/
--enable-wptserve is still needed until issue 618366 is fixed.
We can ignore the "passed unexpectedly" failures, I think that's just a byproduct of issue 618366 being worked on (the test expectations are written for the case where --enable- wptserve is not used).
The test expectations are in two places:
- LayoutTests/TestExpectations
- In "*expected.txt" files in the test directory itself. For example, controller-on-disconnect.https-expected.txt
Basically the goal should be to remove all the "*expected.txt" files. When a test passes normally, it doesn't need an expected.txt file. If you open the expected.txt files, you'll see they have lines like FAIL which indicate the failure. For example:
$ cat controller-on-load.https-expected.txt
This is a testharness.js-based test.
FAIL controller is set for a controlled document Cannot read property 'active' of undefined
Harness: the test ran to completion.
Summary: Tests in LayoutTests/external/wpt/service-workers/service-worker should pass. (was: Tests in LayoutTests/imported/wpt/service-workers/service-worker should pass.)
Owner: ---- Status: Available (was: Started) Summary: ☔ Tests in LayoutTests/external/wpt/service-workers/service-worker should pass. ☔ (was: Tests in LayoutTests/external/wpt/service-workers/service-worker should pass.)
As this has become a broad umbrella bug I think this doesn't need a specific owner.
Comment 1 by yiyix@chromium.org
, Jan 13 2017Status: Started (was: Assigned)