Resize Camera app window to ensure the entire frame is visible. |
|||
Issue descriptionWhen changing camera devices the aspect ratio may change.
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/3c0eeaec205f3425266cfa8f00f5cf0e858a84ec commit 3c0eeaec205f3425266cfa8f00f5cf0e858a84ec Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Wed Jan 11 02:33:30 2017 Always show the entire frame. Before, in some aspect ratios the preview would be cut, so the taken picture would be different than on the preview. TEST=Tested by resizing the window. BUG= chromium:678900 Change-Id: If2b161fde557986875307394c721c31fb18133f9 Reviewed-on: https://chromium-review.googlesource.com/426441 Reviewed-by: Daichi Hirono <hirono@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org> [modify] https://crrev.com/3c0eeaec205f3425266cfa8f00f5cf0e858a84ec/src/js/views/camera.js [modify] https://crrev.com/3c0eeaec205f3425266cfa8f00f5cf0e858a84ec/src/css/main.css
,
Jan 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/ad67d11254552713d5b136d17b6d1971b0b8093f commit ad67d11254552713d5b136d17b6d1971b0b8093f Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Wed Jan 11 03:19:09 2017 Automatically update the window size when changing camera. TEST=Tested manually by resizing the window, and changing camera. BUG= chromium:678900 Change-Id: Idb1e120c0f03c656aabf6307489070bc0702c774 Reviewed-on: https://chromium-review.googlesource.com/427078 Reviewed-by: Daichi Hirono <hirono@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org> [modify] https://crrev.com/ad67d11254552713d5b136d17b6d1971b0b8093f/src/js/views/camera.js
,
Jan 20 2017
,
Feb 23 2017
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/813b6a8840524a39e83b093f3f4d236b708e7b5d commit 813b6a8840524a39e83b093f3f4d236b708e7b5d Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Wed Jan 11 08:07:29 2017 Migrate from deprecated box model to flexbox. TEST=Tested manually all UI elements. BUG= chromium:678900 Change-Id: Ib73d55d58a7c07ea3df83b0cd33c036064fb0e8d Reviewed-on: https://chromium-review.googlesource.com/426301 Reviewed-by: Daichi Hirono <hirono@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org> [modify] https://crrev.com/813b6a8840524a39e83b093f3f4d236b708e7b5d/src/css/main.css
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c0eeaec205f3425266cfa8f00f5cf0e858a84ec commit 3c0eeaec205f3425266cfa8f00f5cf0e858a84ec Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Wed Jan 11 08:07:55 2017 Always show the entire frame. Before, in some aspect ratios the preview would be cut, so the taken picture would be different than on the preview. TEST=Tested by resizing the window. BUG= chromium:678900 Change-Id: If2b161fde557986875307394c721c31fb18133f9 Reviewed-on: https://chromium-review.googlesource.com/426441 Reviewed-by: Daichi Hirono <hirono@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org> [modify] https://crrev.com/3c0eeaec205f3425266cfa8f00f5cf0e858a84ec/src/css/main.css [modify] https://crrev.com/3c0eeaec205f3425266cfa8f00f5cf0e858a84ec/src/js/views/camera.js
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad67d11254552713d5b136d17b6d1971b0b8093f commit ad67d11254552713d5b136d17b6d1971b0b8093f Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Tue Jan 17 05:15:04 2017 Automatically update the window size when changing camera. TEST=Tested manually by resizing the window, and changing camera. BUG= chromium:678900 Change-Id: Idb1e120c0f03c656aabf6307489070bc0702c774 Reviewed-on: https://chromium-review.googlesource.com/427078 Reviewed-by: Daichi Hirono <hirono@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org> [modify] https://crrev.com/ad67d11254552713d5b136d17b6d1971b0b8093f/src/js/views/camera.js
,
Today
(6 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a588ee11d1ae20e087ed6e53fcada3eb1ff473ec commit a588ee11d1ae20e087ed6e53fcada3eb1ff473ec Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Wed Jan 11 08:07:29 2017 Migrate from deprecated box model to flexbox. TEST=Tested manually all UI elements. BUG= chromium:678900 Change-Id: Ib73d55d58a7c07ea3df83b0cd33c036064fb0e8d Reviewed-on: https://chromium-review.googlesource.com/426301 Reviewed-by: Daichi Hirono <hirono@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org>
,
Today
(6 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c425fc5bb9f3a75f347449dd3ca0e8b03e20d515 commit c425fc5bb9f3a75f347449dd3ca0e8b03e20d515 Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Wed Jan 11 08:07:55 2017 Always show the entire frame. Before, in some aspect ratios the preview would be cut, so the taken picture would be different than on the preview. TEST=Tested by resizing the window. BUG= chromium:678900 Change-Id: If2b161fde557986875307394c721c31fb18133f9 Reviewed-on: https://chromium-review.googlesource.com/426441 Reviewed-by: Daichi Hirono <hirono@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org>
,
Today
(6 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f56d382e0ec67c8d344fc3338a06c2d721d5f639 commit f56d382e0ec67c8d344fc3338a06c2d721d5f639 Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Tue Jan 17 05:15:04 2017 Automatically update the window size when changing camera. TEST=Tested manually by resizing the window, and changing camera. BUG= chromium:678900 Change-Id: Idb1e120c0f03c656aabf6307489070bc0702c774 Reviewed-on: https://chromium-review.googlesource.com/427078 Reviewed-by: Daichi Hirono <hirono@chromium.org> Tested-by: Tomasz Mikolajewski <mtomasz@chromium.org> |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jan 11 2017