New issue
Advanced search Search tips

Issue 678850 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 680764



Sign in to add a comment

Update WebGL's vertexAttribPointer validation around clearing the pointer

Project Member Reported by kbr@chromium.org, Jan 6 2017

Issue description

In https://github.com/KhronosGroup/WebGL/pull/2228 the semantics of WebGL's vertexAttribPointer are being changed so that the combination of a null buffer and 0 offset is legal, and clears out the binding. This change needs to be implemented in Chrome in order to roll the WebGL conformance tests forward. The affected tests are:

conformance/attribs/gl-vertexattribpointer.html
conformance/more/functions/vertexAttribPointerBadArgs.html

 
Owner: yunchao...@intel.com
Status: Assigned (was: Available)
Ken and all, I can take a look.

I suppose that the same rule should be applied to vertexAttribIPointer, see the small change at https://github.com/KhronosGroup/WebGL/pull/2241.

Comment 2 by kbr@chromium.org, Jan 6 2017

Thanks Yunchao.

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/314c0c8fcb9c97c7588a2302df4df7b4b0097c0c

commit 314c0c8fcb9c97c7588a2302df4df7b4b0097c0c
Author: yunchao.he <yunchao.he@intel.com>
Date: Thu Jan 12 14:01:35 2017

Fix the bug for VertexAttrib{I}Pointer when no array buffer bound

BUG= 678850 
TEST=conformance/more/functions/vertexAttribPointerBadArgs.html,
     conformance/attribs/gl-vertexattribpointer.html,
     conformance2/attribs/gl-vertexattribipointer.html.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2610393003
Cr-Commit-Position: refs/heads/master@{#443220}

[modify] https://crrev.com/314c0c8fcb9c97c7588a2302df4df7b4b0097c0c/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/314c0c8fcb9c97c7588a2302df4df7b4b0097c0c/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/314c0c8fcb9c97c7588a2302df4df7b4b0097c0c/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/314c0c8fcb9c97c7588a2302df4df7b4b0097c0c/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/314c0c8fcb9c97c7588a2302df4df7b4b0097c0c/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Cc: geoffl...@chromium.org jmad...@chromium.org
The tests failed when enable pass-through command buffer. I suppose that it should be fixed in ANGLE. 

I will take a look at ANGLE validation code to fix it.

(CC to Jamie and Geoff)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/930a150accb15a15398203214313092d46a131b2

commit 930a150accb15a15398203214313092d46a131b2
Author: zmo <zmo@chromium.org>
Date: Fri Jan 13 21:10:42 2017

Update WebGL conformance test expectations for Nexus 5.

BUG= 678850 
TEST=Nexus 5 bot
TBR=yunchao.he@intel.com
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2629223004
Cr-Commit-Position: refs/heads/master@{#443666}

[modify] https://crrev.com/930a150accb15a15398203214313092d46a131b2/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Comment 6 by zmo@chromium.org, Jan 14 2017

Blockedon: 680764
Status: Fixed (was: Assigned)

Sign in to add a comment