Cannot resume an interrupted download if a file with the same name exists on sdcard |
||||||||
Issue descriptionRepros on both M56 Steps to reproduce: (1) Download a big file once until it completes (2) download the same file, and choose "download" on the duplicate infobar (3) while download starts, kill chrome (4) relaunch chrome, and resume the download from download home Expected result: Download should resume Actual result: Download fails, and a toast showing an error that the file already exists on sdcard
,
Jan 6 2017
for M55, same issue happens when user select the "create new file" option from duplicate infobar
,
Jan 6 2017
,
Jan 6 2017
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41231a3e20197bf9499332f02c69a426186f5fbe commit 41231a3e20197bf9499332f02c69a426186f5fbe Author: qinmin <qinmin@chromium.org> Date: Thu Jan 26 03:26:35 2017 Use previous target path when resuming a download after crash When resuming a download after browser crash, Chrome will regenerate the target path. This could reintroduce name conflict if user has resolved a conflict before the crash. This CL reuses the previous target path Chrome has already generated for the download. BUG= 678835 Review-Url: https://codereview.chromium.org/2618743006 Cr-Commit-Position: refs/heads/master@{#446218} [modify] https://crrev.com/41231a3e20197bf9499332f02c69a426186f5fbe/chrome/browser/download/download_target_determiner.cc [modify] https://crrev.com/41231a3e20197bf9499332f02c69a426186f5fbe/chrome/browser/download/download_target_determiner_unittest.cc
,
Jan 26 2017
,
Jan 26 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e8d5bafdb010fa97aaecb9e0ebf61f462129366 commit 7e8d5bafdb010fa97aaecb9e0ebf61f462129366 Author: Min Qin <qinmin@chromium.org> Date: Fri Jan 27 21:35:46 2017 Use previous target path when resuming a download after crash When resuming a download after browser crash, Chrome will regenerate the target path. This could reintroduce name conflict if user has resolved a conflict before the crash. This CL reuses the previous target path Chrome has already generated for the download. BUG= 678835 TBR=asanka@chromium.org Review-Url: https://codereview.chromium.org/2618743006 Cr-Commit-Position: refs/heads/master@{#446218} (cherry picked from commit 41231a3e20197bf9499332f02c69a426186f5fbe) Review-Url: https://codereview.chromium.org/2665463002 . Cr-Commit-Position: refs/branch-heads/2987@{#154} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/7e8d5bafdb010fa97aaecb9e0ebf61f462129366/chrome/browser/download/download_target_determiner.cc [modify] https://crrev.com/7e8d5bafdb010fa97aaecb9e0ebf61f462129366/chrome/browser/download/download_target_determiner_unittest.cc
,
Jan 27 2017
,
Jan 31 2017
Verified on M57-57.0.2987.19 build
,
Apr 27 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by qin...@chromium.org
, Jan 6 2017