Tail request to Logdog returned empty value |
|||
Issue descriptionUrl to the tail request: https://luci-logdog.appspot.com/rpcexplorer/services/logdog.Logs/Tail?request={%20%20%20%20%22project%22:%20%22chromium%22,%20%20%20%20%22path%22:%20%22bb/chromium.win/Win7_Tests__dbg__1_/56249/+/annotations%22} The return value is empty when there is data in Get request for the same log.
,
Jan 6 2017
Proposed fix: https://codereview.chromium.org/2611253005
,
Jan 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/77c4eac9a4bf4c8818dbddcea7b91cba90a20d75 commit 77c4eac9a4bf4c8818dbddcea7b91cba90a20d75 Author: dnj <dnj@chromium.org> Date: Fri Jan 06 21:01:11 2017 Fix BigTable multi-entry row cached Tail. When performing a Tail, LogDog has to scan through all of a log's BigTable rows to identify the last contiguous entry. In order to optimize this, the BigTable storage implementation caches the last contiguous tail index in memcache. BigTable rows are keyed on their LAST log entry index, not their first, so the cached log index was the last index in the row. If the row contained multiple log entries, this violated an earlier continuity check, which was expecting the first index in the row, not the last, to match the cached index. We fix this by caching the first index in the row, matching continuity expectaitons. BUG= chromium:678831 TEST=unit,local - Added regression unit test, passes now. - Use multi-round Tail on `logdog_bigtable_test` before and after, verify that it works now. R=vadimsh@chromium.org Review-Url: https://codereview.chromium.org/2611253005 [modify] https://crrev.com/77c4eac9a4bf4c8818dbddcea7b91cba90a20d75/logdog/common/storage/bigtable/cache.go [modify] https://crrev.com/77c4eac9a4bf4c8818dbddcea7b91cba90a20d75/logdog/common/storage/bigtable/logdog_bigtable_test/main.go [modify] https://crrev.com/77c4eac9a4bf4c8818dbddcea7b91cba90a20d75/logdog/common/storage/bigtable/rowKey.go [modify] https://crrev.com/77c4eac9a4bf4c8818dbddcea7b91cba90a20d75/logdog/common/storage/bigtable/storage.go [modify] https://crrev.com/77c4eac9a4bf4c8818dbddcea7b91cba90a20d75/logdog/common/storage/bigtable/storage_test.go
,
Jan 6 2017
This should be fixed once I push a new instance. I'll hopefully get that done by the end of the day, but I have some other patches that I have to land first.
,
Jan 7 2017
Uploaded new version, verified that it is working. |
|||
►
Sign in to add a comment |
|||
Comment 1 by d...@chromium.org
, Jan 6 2017