New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678814 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

CrOS: remove use of STLDelete* functions from libchrome base/stl_uitl.h

Project Member Reported by benchan@chromium.org, Jan 5 2017

Issue description

Those STLDelete* functions from libchrome base/stl_util.h have been deprecated and removed from chrome (see  issue 555865 ). We should update CrOS code to remove the use of those functions in order to allow future update of libchrome.
 
Status: Started (was: Assigned)
Cc: ejcaruso@chromium.org vapier@chromium.org derat@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cfe9a3242fadb073b192d18a29de1778d1090f53

commit cfe9a3242fadb073b192d18a29de1778d1090f53
Author: Ben Chan <benchan@chromium.org>
Date: Thu Jan 05 21:18:55 2017

login: remove uses of STLDeleteValues

STLDeleteValues (defined in base/stl_util.h) has been deprecated
(chromium:555865). This CL updates session manager code to keep objects
in form of unique_ptr instead of raw pointer in a STL container, such
that objects are automatically destructed without needing to call
STLDeleteValues.

BUG= chromium:678814 
TEST=Run unit tests.

Change-Id: I34b0895f8f3a772789173cb0cd6998cf28e395f5
Reviewed-on: https://chromium-review.googlesource.com/425478
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/cfe9a3242fadb073b192d18a29de1778d1090f53/login_manager/device_local_account_policy_service.h
[modify] https://crrev.com/cfe9a3242fadb073b192d18a29de1778d1090f53/login_manager/session_manager_impl.cc
[modify] https://crrev.com/cfe9a3242fadb073b192d18a29de1778d1090f53/login_manager/session_manager_impl.h
[modify] https://crrev.com/cfe9a3242fadb073b192d18a29de1778d1090f53/login_manager/device_local_account_policy_service.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c6e6cdd82760375419ebb8bfa6defa20bf4ef933

commit c6e6cdd82760375419ebb8bfa6defa20bf4ef933
Author: Ben Chan <benchan@chromium.org>
Date: Thu Jan 05 21:30:32 2017

authpolicy: remove uses of STLDeleteValues

STLDeleteValues (defined in base/stl_util.h) has been deprecated
(chromium:555865). This CL updates policy::RegistryDict to keep objects
in form of unique_ptr instead of raw pointer in a STL container, such
that objects are automatically destructed without needing to call
STLDeleteValues.

BUG= chromium:678814 
TEST=Run unit tests.

Change-Id: Ia042b320483837c7c65ee971752cb8d06c0e14c1
Reviewed-on: https://chromium-review.googlesource.com/425479
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/c6e6cdd82760375419ebb8bfa6defa20bf4ef933/authpolicy/policy/registry_dict.cc
[modify] https://crrev.com/c6e6cdd82760375419ebb8bfa6defa20bf4ef933/authpolicy/policy/registry_dict.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bba00ef59a6b379f9c4a2a180515117fa89e0d78

commit bba00ef59a6b379f9c4a2a180515117fa89e0d78
Author: Ben Chan <benchan@chromium.org>
Date: Thu Jan 05 21:26:04 2017

cros-disks: remove uses of STLDeleteElements

STLDeleteElements (defined in base/stl_util.h) has been deprecated
(chromium:555865). This CL updates cros_disks::DeviceEjector to keep
objects in form of unique_ptr instead of raw pointer in a STL container,
such that objects are automatically destructed without needing to call
STLDeleteElements.

BUG= chromium:678814 
TEST=Run unit tests.

Change-Id: Iae7ee9337a6e1e6a7be03baef87a8f6ac1d5dedc
Reviewed-on: https://chromium-review.googlesource.com/425480
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/bba00ef59a6b379f9c4a2a180515117fa89e0d78/cros-disks/device_ejector.h
[modify] https://crrev.com/bba00ef59a6b379f9c4a2a180515117fa89e0d78/cros-disks/device_ejector.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/33cac12e09ad954b52245a8f3d483ad3edb5a127

commit 33cac12e09ad954b52245a8f3d483ad3edb5a127
Author: Ben Chan <benchan@chromium.org>
Date: Thu Jan 05 21:24:09 2017

cromo: remove uses of STLDeleteElements and STLDeleteValues

STLDeleteElements and STLDeleteValues (defined in base/stl_util.h) have
been deprecated (chromium:555865). This CL updates cromo code to keep
objects in form of unique_ptr instead of raw pointer in a STL container,
such that objects are automatically destructed without needing to call
STLDeleteElements and STLDeleteValues.

BUG= chromium:678814 
TEST=Run unit tests.

Change-Id: I4c9103b239a5283c46cebdcb6a7196bedbbd967f
Reviewed-on: https://chromium-review.googlesource.com/425481
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/33cac12e09ad954b52245a8f3d483ad3edb5a127/cromo/sms_message.h
[modify] https://crrev.com/33cac12e09ad954b52245a8f3d483ad3edb5a127/cromo/cromo_server.cc
[modify] https://crrev.com/33cac12e09ad954b52245a8f3d483ad3edb5a127/cromo/cromo_server.h
[modify] https://crrev.com/33cac12e09ad954b52245a8f3d483ad3edb5a127/cromo/sms_message.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/daa5201f6428fb084d27a1d6e31905b6f09ac9dc

commit daa5201f6428fb084d27a1d6e31905b6f09ac9dc
Author: Ben Chan <benchan@chromium.org>
Date: Sat Jan 07 22:29:18 2017

cryptohome: remove unnecessary inclusions of base/stl_util.h

This CL removes unnecessary inclusions of base/stl_util.h in files that
don't use any definition from base/stl_util.h.

BUG= chromium:678814 
TEST=Run unit tests.

Change-Id: Idebf94f943468764aab59fda7fc75a262e2f9f54
Reviewed-on: https://chromium-review.googlesource.com/426060
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/daa5201f6428fb084d27a1d6e31905b6f09ac9dc/cryptohome/boot_lockbox_unittest.cc
[modify] https://crrev.com/daa5201f6428fb084d27a1d6e31905b6f09ac9dc/cryptohome/username_passkey.cc
[modify] https://crrev.com/daa5201f6428fb084d27a1d6e31905b6f09ac9dc/cryptohome/tpm_impl.cc
[modify] https://crrev.com/daa5201f6428fb084d27a1d6e31905b6f09ac9dc/cryptohome/cryptohome.cc
[modify] https://crrev.com/daa5201f6428fb084d27a1d6e31905b6f09ac9dc/cryptohome/boot_lockbox.cc
[modify] https://crrev.com/daa5201f6428fb084d27a1d6e31905b6f09ac9dc/cryptohome/cryptolib.cc
[modify] https://crrev.com/daa5201f6428fb084d27a1d6e31905b6f09ac9dc/cryptohome/crypto.cc
[modify] https://crrev.com/daa5201f6428fb084d27a1d6e31905b6f09ac9dc/cryptohome/homedirs_unittest.cc
[modify] https://crrev.com/daa5201f6428fb084d27a1d6e31905b6f09ac9dc/cryptohome/service.cc
[modify] https://crrev.com/daa5201f6428fb084d27a1d6e31905b6f09ac9dc/cryptohome/attestation_unittest.cc
[modify] https://crrev.com/daa5201f6428fb084d27a1d6e31905b6f09ac9dc/cryptohome/homedirs.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2d35d50063adb3075a77d0e6605ff628ba7e6ea8

commit 2d35d50063adb3075a77d0e6605ff628ba7e6ea8
Author: Ben Chan <benchan@chromium.org>
Date: Sat Jan 07 22:15:24 2017

login: remove unnecessary inclusions of base/stl_util.h

This CL removes unnecessary inclusions of base/stl_util.h in files that
don't use any definition from base/stl_util.h.

BUG= chromium:678814 
TEST=Run unit tests.

Change-Id: I50ec5fd3b28a53c35ec3c99c4ad0b4606f69cf10
Reviewed-on: https://chromium-review.googlesource.com/426081
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/2d35d50063adb3075a77d0e6605ff628ba7e6ea8/login_manager/session_manager_impl.cc
[modify] https://crrev.com/2d35d50063adb3075a77d0e6605ff628ba7e6ea8/login_manager/session_manager_dbus_adaptor.cc
[modify] https://crrev.com/2d35d50063adb3075a77d0e6605ff628ba7e6ea8/login_manager/server_backed_state_key_generator.cc

Status: Fixed (was: Started)

Comment 10 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 11 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment