New issue
Advanced search Search tips

Issue 678795 link

Starred by 3 users
Status: Available
Owner: ----
Cc:
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task

Blocking:
issue 670035



Sign in to add a comment

InputEvent Improvement: Move 'beforeinput' logic into |CompositeEditCommand.cpp|

Project Member Reported by chongz@chromium.org, Jan 5 2017 
This is the tracking bug for xiaocheng@'s comments in:
https://codereview.chromium.org/2558643003/#msg73

Detailed Steps:
1. Introduce temporary flag |BeforeInputTiming| indicating whether ‘beforeinput’ has already been fired.
2. Move |InputEvent| related attributes from |EditCommand| to |CompositeEditCommand|
3. Implement 'beforeinput' logic in |will*()|, guarded by |BeforeInputTiming| flag.
4. Move 'beforeinput' one by one, e.g.
  a. Spellchecker
  b. Drag & drop
  c. Cut & paste
  d. TypingCommand related
  e. Undo & redo
  f. Other commands, e.g. Text styling
  g. Reorder 'compositionupdate' and 'beforeinput'
5. Remove |BeforeInputTiming| flag and cleanup

Comment 1 by xiaoche...@chromium.org, Nov 13 2017

Components: Blink>Editing
Labels: Type-Task
Owner: ----
Status: Available (was: Started)
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 14

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by nzolghadr@chromium.org, Nov 15

Status: Available (was: Untriaged)
Still an issue in 2018 Q4 check-in.
►

Sign in to add a comment